RFR(S) : 8219395 : integrate gcov w/ run-test

Igor Ignatyev igor.ignatyev at oracle.com
Wed Feb 20 18:27:26 UTC 2019


Hi Erik,

thanks for your review, I've removed the commented lines and changed default_make_targets, 
http://cr.openjdk.java.net/~iignatyev//8219395/webrev.0-1/index.html <http://cr.openjdk.java.net/~iignatyev//8219395/webrev.0-1/index.html> is incremental webrev.

Thanks,
-- Igor

> On Feb 20, 2019, at 6:59 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
> 
> Hello Igor,
> 
> This looks pretty good. Just a few comments.
> 
> In jib-profiles.js, the linux-x64 profile also builds docs-bundles, so if you base linux-x64-gcov on a clone of that there is some extra build work being done unnecessarily. I would recommend explicitly setting the default_make_targets (which would be product-bundles and test-bundles) for the new *-gcov profiles.
> 
> On lines 795, 804 and 812 you seem to have left commented out code that should probably be removed.
> 
> /Erik
> 
> On 2019-02-19 17:26, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8219395/webrev.00/index.html
>>> 65 lines changed: 59 ins; 0 del; 6 mod;
>> Hi all,
>> 
>> could you please review the patch which makes it easy to run tests on the builds w/ native-code-coverage enabled? to do so the patch
>>  - sets GCOV_PREFIX env. variable, so .gcda files will be stored in build/*/test-results/gcov-output directory, and makes jtreg to propagate this env. variable to JDK under test
>>  - adds linux-x64-gcov and macosx-x64-gcov jib profiles
>>  - changes 'run-test-prebuilt' profile to set GCOV_ENABLED=true if it's the tested profile is -gcov profile
>> 
>> and also fixes comment for JDKOPT_SETUP_CODE_COVERAGE in jdk-options.m4.
>> 
>> webrev: http://cr.openjdk.java.net/~iignatyev//8219395/webrev.00/index.html
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8219395
>> testing:
>>  - :tier1 on {linux,macos}-x64 and {linux,macos}-x64-gcov
>>  - checked that *-gcov builds have .gcno files generated and stored in symbols bundle; and regular builds don't
>>  - checked that *-gcov runs have .gcda files generated in test-results/gcov-output; and runs on regular builds don't
>> 
>> Thanks,
>> -- Igor



More information about the build-dev mailing list