RFR(XS): 8219675: Disable harfbuzz warnings with gcc 8

Mikael Vidstedt mikael.vidstedt at oracle.com
Tue Feb 26 00:09:55 UTC 2019


Erik/Phil, thanks for the reviews. Change pushed!

I also filed https://bugs.openjdk.java.net/browse/JDK-8219676 <https://bugs.openjdk.java.net/browse/JDK-8219676> to cover re-enabling the warnings (effectively reverting this change) once harfbuzz has been upgraded.

Cheers,
Mikael

> On Feb 25, 2019, at 2:16 PM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
> 
> Looks good.
> 
> /Erik
> 
> On 2019-02-25 13:28, Mikael Vidstedt wrote:
>> Please review this change which (temporarily) disables two gcc warnings which are triggered by the harfbuzz code.
>> 
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8219675 <https://bugs.openjdk.java.net/browse/JDK-8219675>
>> webrev: http://cr.openjdk.java.net/~mikael/webrevs/8219675/webrev.00/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8219675/webrev.00/open/webrev/>
>> 
>> This change disables the two warnings in question (missing-attributes and class-memaccess). An alternative would be to make changes to the harfbuzz code itself instead.
>> 
>> Passes tier1.
>> 
>> Cheers,
>> Mikael
>> 



More information about the build-dev mailing list