RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

[Magnus Ihse Bursie]

On 2020-05-13 06:55, David Holmes wrote:
> On 13/05/2020 8:50 am, Mikael Vidstedt wrote:
>> Including hotspot-runtime-dev since the zero patch touches hotspot 
>> (os_linux) - please review!
>>
>>> On May 12, 2020, at 3:05 PM, John Paul Adrian Glaubitz 
>>> <glaubitz at physik.fu-berlin.de> wrote:
>>>
>>> Hi Mikael!
>>>
>>> On 5/12/20 12:08 AM, John Paul Adrian Glaubitz wrote:
>>>>> Adrian, did you have a chance to look at the zero patch? I’m 
>>>>> running out of things to
>>>>> address and I’m planning on moving forward with the JEP targeting 
>>>>> and integration shortly.
>>>>
>>>> I haven't tested the changes by Magnus yet, but they look good to 
>>>> me. Magnus
>>>> create a repo on the Linux SPARC porterbox which I can pull from 
>>>> for testing.
>>>>
>>>> I finally have time to look into it tomorrow morning (CEST) so I can
>>>> officially ACK the changes.
>>>
>>> Changes look fine to me with the additional changes by Magnus squashed
>>> into yours - unless you already have done so in your latest revision.
>>
>> Thank you for verifying it! Webrev here:
>>
>> http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.04/zero.incr/open/webrev/ 
>>
>
> This appears to restore the bits previously removed.
>
> I can't validate whether that is actually enough to build zero on sparc.
Yes, the patch looks good. (Says the man who wrote it ;-)) And I can 
confirm that this is enough to build zero on sparc, and at least pass a 
fair amount of the jtreg tests in tier1. (The issues that was detected 
in tier1 might just as well have been present before.)

In a side note, I'm actually pleasantly surprised at how little extra 
code that is needed to support zero on a "new" platform. I genuinely 
thought that more changes were needed.

/Magnus
>
> Cheers,
> David
> -----
>
>>
>> I’m only including the incremental change. It builds on the 
>> previously reviewed build system and hotspot webrevs:
>>
>> build: 
>> http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.02/build/open/webrev/
>> hotspot: 
>> http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/hotspot/open/webrev/
>>
>> (Note that I already included the 
>> UTIL_DEPRECATED_ARG_ENABLE(deprecated-ports) part of Magnus’ change 
>> in the build/webrev.02 change)
>>
>>> PS: I was just wondering: Would I be eligible to apply to become a 
>>> reviewer?
>>
>> One one and only one condition: Review the webrev to make sure I got 
>> it right ;)
>>
>> Cheers,
>> Mikael
>>