RFR: 8255526: Enable jcheck whitespace checking of build system files

Magnus Ihse Bursie ihse at openjdk.java.net
Wed Oct 28 22:33:44 UTC 2020


On Wed, 28 Oct 2020 12:49:23 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> With the new Skara tooling, we can finally enable whitespace testing for build system files (makefiles and autoconf files).
>
> Awesome, finally!

I need to put this on hold for a while. It turned out that the Skara jcheck disallows initial tabs, which makes sense for sane source code formats (java, c++) but is unfortunately an incorrect assumption for makefiles.

(I tested that the modification to jcheck detected trailing whitespaces, but it never occurred to me that I needed to modify a line starting with tab to show that this fix would not work...)

-------------

PR: https://git.openjdk.java.net/jdk/pull/898



More information about the build-dev mailing list