RFR: 8255526: Enable jcheck whitespace checking of build system files
Magnus Ihse Bursie
ihse at openjdk.java.net
Thu Oct 29 00:57:45 UTC 2020
On Wed, 28 Oct 2020 22:31:06 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Awesome, finally!
>
> I need to put this on hold for a while. It turned out that the Skara jcheck disallows initial tabs, which makes sense for sane source code formats (java, c++) but is unfortunately an incorrect assumption for makefiles.
>
> (I tested that the modification to jcheck detected trailing whitespaces, but it never occurred to me that I needed to modify a line starting with tab to show that this fix would not work...)
Fix for Skara in PR https://github.com/openjdk/skara/pull/929.
-------------
PR: https://git.openjdk.java.net/jdk/pull/898
More information about the build-dev
mailing list