Why do we export "JVM_handle_xxx_signal"?

[Thomas Stüfe]

Thanks for checking, Ioi. I think I'll remove the export and rename the
functions.

Cheers, Thomas

On Fri, Oct 30, 2020 at 7:12 AM Ioi Lam <ioi.lam at oracle.com> wrote:

> I have no idea, but this symbol has been exported since we moved the
> HotSpot source code from SCCS to Mercurial in 2008. It's probably
> vestige from the early days of Java.
>
>
> http://hg.openjdk.java.net/jdk7/modules/hotspot/annotate/9646293b9637/make/linux/makefiles/mapfile-vers-product#l244
>
> I checked all .so files in our JDK build and no one uses
> JVM_handle_linux_signal. I think it's probably safe to hide it. We
> should probably drop the JVM_ prefix, since this function is not
> declared in jvm.h.
>
> Thanks
> - Ioi
>
> On 10/29/20 9:02 AM, Thomas Stüfe wrote:
> > Hi,
> >
> > Does anyone know why we explicitly export JVM_handle_bsd_signal and
> > JVM_handle_linux_signal (the latter also accidentally from symbols-aix)?
> >
> > These functions are not even the real signal handler, just an internal
> > function; the signal handler is "javaSignalHandler", but that one is not
> > exported...
> >
> > Thanks, Thomas
>
>