RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v3]

Andrew Leonard aleonard at openjdk.java.net
Wed Dec 22 15:32:13 UTC 2021


On Wed, 22 Dec 2021 13:41:53 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8278766: Enable OpenJDK build support for reproducible jars and jmods using --date
>>   
>>   Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> make/InitSupport.gmk line 317:
> 
>> 315:     export SOURCE_DATE_EPOCH := $$(SOURCE_DATE)
>> 316:     ifeq ($$(IS_GNU_DATE), yes)
>> 317:       SOURCE_DATE_ISO_8601 := $(shell $(DATE) --utc --date="@$(SOURCE_DATE_EPOCH)" +"%Y-%m-%dT%H:%M:%SZ" 2> /dev/null)
> 
> Are you getting this to work without `export`? I would have expected that to be needed.

@erikj79 fixed it I think, problems is above not enough $'s !! for $(shell.......

-------------

PR: https://git.openjdk.java.net/jdk/pull/6878



More information about the build-dev mailing list