RFR: 8267706: bin/idea.sh tries to use cygpath on WSL
Erik Joelsson
erikj at openjdk.java.net
Thu May 27 16:55:08 UTC 2021
On Tue, 25 May 2021 16:37:30 GMT, Nikita Gubarkov <github.com+9004656+YaaZ at openjdk.org> wrote:
> 8267706: bin/idea.sh tries to use cygpath on WSL
I think this looks ok, though I'm not very familiar with the details of this code. I also very rarely use the idea projects. It would be good if some frequent users could take this for a spin.
make/ide/idea/jdk/idea.gmk line 50:
> 48: idea:
> 49: $(ECHO) "SUPPORT=$(SUPPORT_OUTPUTDIR)" > $(OUT)
> 50: $(ECHO) "MODULES=\"$(foreach mod, $(SEL_MODULES), module='$(mod)' moduleSrcDirs='$(call FindModuleSrcDirs,$(mod))' moduleDependencies='$(call FindTransitiveDepsForModule,$(mod))' #)\"" >> $(OUT)
If you can find a way to break this line, it would be appreciated. We try to keep line length "reasonable" within the build files. (Reasonable meaning, not strict 80, but with future 3-way merges on a normal screen in mind)
-------------
Marked as reviewed by erikj (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4190
More information about the build-dev
mailing list