RFR: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record [v2]

Guoxiong Li gli at openjdk.java.net
Wed Sep 15 06:10:27 UTC 2021


> Hi all,
> 
> After processing annotation, if new source files are generated, the compiler should re-parse and re-enter the source files so that the type and symbol can keep right. The compiler always holds this convention in the past. But when the feature `record` is added, the convention is broken. In this bug, the compiler doesn't  catch or enter the new/good type for record component after processing annotation. So some issues may occur at the later phases.
> 
> This patch fixes the type of the record component so that the phases `Gen` and `ClassWriter` can get the right type. And a test case is added.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:

  Treat source as comment mistakenly. Remove the comment symbol.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5511/files
  - new: https://git.openjdk.java.net/jdk/pull/5511/files/e6b35178..7b756883

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5511&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5511&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5511.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5511/head:pull/5511

PR: https://git.openjdk.java.net/jdk/pull/5511


More information about the compiler-dev mailing list