From tim.bell at sun.com Wed Oct 1 17:57:48 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Wed, 01 Oct 2008 17:57:48 +0000 Subject: hg: jdk7/tl: 5 new changesets Message-ID: <20081001175749.43AC0D84C@hg.openjdk.java.net> Changeset: e18ad724572f Author: ohair Date: 2008-09-09 15:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/e18ad724572f 6746424: Remove build dependency on findbugs and FINDBUGS_HOME Reviewed-by: tbell ! make/Defs-internal.gmk ! make/README.pre-components ! make/jprt.config Changeset: 2fed245641ed Author: ohair Date: 2008-09-11 11:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/2fed245641ed Merge Changeset: 1d9112b073d7 Author: ohair Date: 2008-09-17 13:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/1d9112b073d7 6724787: OpenJDK README-builds.html suggested changes 6746440: Add Fedora 9 & CentOS 5.2 instructions to OpenJDK Build README Reviewed-by: weijun, xdono ! README-builds.html Changeset: 4b4f5fea8d7d Author: xdono Date: 2008-09-17 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/4b4f5fea8d7d Merge ! README-builds.html Changeset: b3eb1d558cd2 Author: xdono Date: 2008-09-25 12:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/b3eb1d558cd2 Added tag jdk7-b36 for changeset 4b4f5fea8d7d ! .hgtags From tim.bell at sun.com Wed Oct 1 17:58:55 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Wed, 01 Oct 2008 17:58:55 +0000 Subject: hg: jdk7/tl/corba: 4 new changesets Message-ID: <20081001175859.E26D4D851@hg.openjdk.java.net> Changeset: 0d92f2ecc8ff Author: ohair Date: 2008-09-09 15:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/0d92f2ecc8ff 6746424: Remove build dependency on findbugs and FINDBUGS_HOME Reviewed-by: tbell ! make/common/shared/Defs-utils.gmk ! make/jprt.config Changeset: 134c361ed49b Author: xdono Date: 2008-09-10 10:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/134c361ed49b Merge Changeset: 0723891eb8d1 Author: xdono Date: 2008-09-17 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/0723891eb8d1 Merge Changeset: d057050bdb27 Author: xdono Date: 2008-09-25 12:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/d057050bdb27 Added tag jdk7-b36 for changeset 0723891eb8d1 ! .hgtags From tim.bell at sun.com Wed Oct 1 18:01:19 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Wed, 01 Oct 2008 18:01:19 +0000 Subject: hg: jdk7/tl/hotspot: 19 new changesets Message-ID: <20081001180158.457CCD856@hg.openjdk.java.net> Changeset: 60bc5071073f Author: never Date: 2008-09-02 15:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/60bc5071073f 6738933: assert with base pointers must match with compressed oops enabled Reviewed-by: kvn, rasbold ! src/share/vm/opto/loopopts.cpp Changeset: cdbee661c7da Author: rasbold Date: 2008-09-04 09:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cdbee661c7da Merge Changeset: 2b73d212b1fd Author: kvn Date: 2008-09-05 13:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2b73d212b1fd 6676462: JVM sometimes would suddenly consume significant amount of memory Summary: Add asserts with dead loop checks in AddNode::Ideal(). Reviewed-by: never ! src/share/vm/opto/addnode.cpp Changeset: 6e7305abe64c Author: never Date: 2008-09-09 12:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6e7305abe64c 6746320: Hotspot regression test for 6512111 fails in -Xmixed mode Reviewed-by: kvn ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: f9847b70eccd Author: rasbold Date: 2008-09-10 06:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f9847b70eccd Merge Changeset: b33eef719520 Author: xlu Date: 2008-08-25 13:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b33eef719520 6740526: sun/management/HotspotThreadMBean/GetInternalThreads.java test failed Reviewed-by: dholmes, dcubed ! src/share/vm/runtime/thread.cpp Changeset: 23c6240101a0 Author: apangin Date: 2008-08-31 15:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/23c6240101a0 Merge Changeset: 93befa083681 Author: coleenp Date: 2008-09-02 15:18 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/93befa083681 6741004: UseLargePages + UseCompressedOops breaks implicit null checking guard page Summary: Turn off c2 implicit null checking on windows and large pages specified. Reviewed-by: jrose, xlu ! src/share/vm/opto/compile.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/virtualspace.cpp Changeset: 24fc405437c9 Author: acorn Date: 2008-09-10 12:31 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/24fc405437c9 Merge - src/cpu/x86/vm/assembler_x86_32.cpp - src/cpu/x86/vm/assembler_x86_32.hpp - src/cpu/x86/vm/assembler_x86_32.inline.hpp - src/cpu/x86/vm/assembler_x86_64.cpp - src/cpu/x86/vm/assembler_x86_64.hpp - src/cpu/x86/vm/assembler_x86_64.inline.hpp - src/os_cpu/linux_x86/vm/assembler_linux_x86_32.cpp - src/os_cpu/linux_x86/vm/assembler_linux_x86_64.cpp - src/os_cpu/solaris_x86/vm/assembler_solaris_x86_32.cpp - src/os_cpu/solaris_x86/vm/assembler_solaris_x86_64.cpp - src/os_cpu/windows_x86/vm/assembler_windows_x86_32.cpp - src/os_cpu/windows_x86/vm/assembler_windows_x86_64.cpp Changeset: 1eb509f14356 Author: acorn Date: 2008-09-11 09:02 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1eb509f14356 Merge Changeset: 68e0443dfd9c Author: ohair Date: 2008-09-11 11:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/68e0443dfd9c 6745363: Add ability to run packtest to hotspot/test/makefile Reviewed-by: ksrini ! make/jprt.properties ! test/Makefile Changeset: 0ba3ec980ae5 Author: dcubed Date: 2008-09-12 07:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0ba3ec980ae5 Merge Changeset: 1c6e3bfb543a Author: kvn Date: 2008-09-10 14:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1c6e3bfb543a 6746892: Register Allocator does not process a data phi with one unique input correctly Summary: Always look for the existing phi for a processed live_range. Reviewed-by: rasbold ! src/share/vm/opto/reg_split.cpp Changeset: cecd8eb4e0ca Author: kvn Date: 2008-09-10 18:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cecd8eb4e0ca 6706829: Compressed Oops: add debug info for narrow oops Summary: Add support for narrow oops in debug info to avoid decoding. Reviewed-by: rasbold, never ! agent/src/share/classes/sun/jvm/hotspot/code/Location.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/CompiledVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! src/share/vm/code/location.cpp ! src/share/vm/code/location.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/stackValue.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: c792b641b8bd Author: kvn Date: 2008-09-10 20:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c792b641b8bd 6746907: Improve implicit null check generation Summary: add missing implicit null check cases. Reviewed-by: never ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/lcm.cpp Changeset: 7484fa4b8825 Author: rasbold Date: 2008-09-15 09:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7484fa4b8825 Merge ! src/share/vm/opto/compile.cpp Changeset: 75e0a5b79b1f Author: trims Date: 2008-09-17 18:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/75e0a5b79b1f Merge Changeset: e91159f921a5 Author: trims Date: 2008-09-17 18:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e91159f921a5 6749707: Update build number for HS14 B05 Summary: Bump the build number for hs14 b05 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 9646293b9637 Author: xdono Date: 2008-09-25 12:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9646293b9637 Added tag jdk7-b36 for changeset e91159f921a5 ! .hgtags From tim.bell at sun.com Wed Oct 1 18:04:16 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Wed, 01 Oct 2008 18:04:16 +0000 Subject: hg: jdk7/tl/jaxp: Added tag jdk7-b36 for changeset c84ca638db42 Message-ID: <20081001180418.AFB4AD85B@hg.openjdk.java.net> Changeset: af49591bc486 Author: xdono Date: 2008-09-25 12:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/af49591bc486 Added tag jdk7-b36 for changeset c84ca638db42 ! .hgtags From tim.bell at sun.com Wed Oct 1 18:05:25 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Wed, 01 Oct 2008 18:05:25 +0000 Subject: hg: jdk7/tl/jaxws: Added tag jdk7-b36 for changeset f60187f44a0d Message-ID: <20081001180528.0F024D860@hg.openjdk.java.net> Changeset: a2a6f9edf761 Author: xdono Date: 2008-09-25 12:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/a2a6f9edf761 Added tag jdk7-b36 for changeset f60187f44a0d ! .hgtags From tim.bell at sun.com Wed Oct 1 18:08:36 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Wed, 01 Oct 2008 18:08:36 +0000 Subject: hg: jdk7/tl/jdk: 37 new changesets Message-ID: <20081001181610.ABC3ED865@hg.openjdk.java.net> Changeset: a23b7f4f8b3c Author: ohair Date: 2008-09-10 09:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a23b7f4f8b3c 6746421: Compare images logic needs to be more forgiving Reviewed-by: tbell ! make/common/shared/Defs.gmk Changeset: 395eb8a7846b Author: ohair Date: 2008-09-10 09:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/395eb8a7846b 6746424: Remove build dependency on findbugs and FINDBUGS_HOME Reviewed-by: tbell ! make/common/Sanity.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/jprt.config Changeset: ec301c0956be Author: ohair Date: 2008-09-10 10:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ec301c0956be 6746430: Fix problems with getting 'ant -version' and the required setting of 'ANT_HOME' Reviewed-by: tbell ! make/common/shared/Defs.gmk ! make/common/shared/Sanity.gmk Changeset: 41bcf49eb3a1 Author: ohair Date: 2008-09-10 10:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/41bcf49eb3a1 6746409: Error: dl failure on line 689: Copies of libjvm.so need to have chcon (selinux) re-applied to them Reviewed-by: tbell ! make/common/Defs.gmk Changeset: c7ab37f5976d Author: ohair Date: 2008-09-11 11:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c7ab37f5976d 6746415: The include file stropts.h is not available in Fedora 9 (STREAMS Kernel Extension?) Reviewed-by: tbell ! src/solaris/native/com/sun/media/sound/PLATFORM_API_SolarisOS_Utils.h Changeset: da5513a6af53 Author: ohair Date: 2008-09-11 11:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/da5513a6af53 Merge ! make/common/Defs.gmk - src/share/javavm/include/opcodes.h - src/share/javavm/include/opcodes.length - src/share/javavm/include/opcodes.list - src/share/javavm/include/opcodes.weight - src/share/javavm/include/opcodes.wide - src/share/javavm/include/sys_api.h - src/share/javavm/include/typedefs.h - src/solaris/javavm/include/typedefs_md.h - src/windows/javavm/include/typedefs_md.h Changeset: 16818689f727 Author: xdono Date: 2008-09-17 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/16818689f727 Merge - src/share/classes/com/sun/jmx/interceptor/MBeanServerSupport.java - src/share/classes/java/nio/channels/package.html - src/share/classes/sun/nio/ch/OptionAdaptor.java - src/share/classes/sun/nio/ch/SocketOpts.java - src/share/classes/sun/nio/ch/SocketOptsImpl.java - src/share/classes/sun/nio/ch/exceptions Changeset: 80a4ace80c31 Author: ant Date: 2008-06-04 12:32 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/80a4ace80c31 6280057: I have audited SystemTray and TrayIcon code Summary: small refactoring Reviewed-by: dcherepanov ! src/share/classes/java/awt/SystemTray.java ! src/share/classes/java/awt/TrayIcon.java Changeset: adebdf3701a4 Author: ant Date: 2008-06-04 14:16 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/adebdf3701a4 6708322: test/closed/java/awt/Focus/TemporaryLostComponentDeadlock fails Summary: Introduced new package private object for synchronization purposes. It should replace "this" in some deadlock prone cases. Reviewed-by: anthony, art ! src/share/classes/java/awt/Component.java Changeset: 58a2ba2767be Author: yan Date: 2008-06-11 01:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/58a2ba2767be Merge - src/solaris/classes/sun/java2d/SurfaceManagerFactory.java - src/windows/classes/sun/java2d/SurfaceManagerFactory.java - test/javax/management/Introspector/LegacyIntrospectorTest.java Changeset: a9b5b5d105a8 Author: ant Date: 2008-06-17 13:37 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a9b5b5d105a8 4685768: A11y issue - Focus set to disabled component, can't Tab/Shift-Tab Summary: The restore-focus procedure should skip disabled components. Reviewed-by: art, dcherepanov ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/share/classes/java/awt/Window.java + test/java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabledCompTest.java + test/java/awt/Focus/RequestFocusToDisabledCompTest/RequestFocusToDisabledCompTest.java ! test/java/awt/regtesthelpers/Util.java Changeset: d407360176c0 Author: dav Date: 2008-06-18 15:35 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d407360176c0 6616323: consider benefits of replacing a componen array with other collection from the awt.Container class Reviewed-by: uta, art ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/ScrollPane.java ! src/windows/native/sun/windows/awt_Container.cpp ! src/windows/native/sun/windows/awt_Container.h + test/java/awt/Container/CheckZOrderChange/CheckZOrderChange.java Changeset: 142e19f00424 Author: dav Date: 2008-06-18 19:20 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/142e19f00424 6716137: Fix 6691328 is broken Reviewed-by: dcherepanov, denis ! src/share/classes/java/awt/dnd/DragSourceContext.java Changeset: 321f5f269836 Author: dav Date: 2008-06-18 19:27 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/321f5f269836 Merge Changeset: 38e32b2db431 Author: yan Date: 2008-06-19 11:26 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/38e32b2db431 6706121: makefile: unnecessary Motif classes compilation in JDK7 Summary: removed 80 obsolete .c and .java files, temporary modified some more Reviewed-by: denis ! make/sun/awt/FILES_c_unix.gmk ! make/sun/awt/FILES_export_unix.gmk ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers-linux ! make/sun/awt/mawt.gmk ! make/sun/jawt/Makefile - src/solaris/classes/sun/awt/motif/MButtonPeer.java - src/solaris/classes/sun/awt/motif/MCanvasPeer.java - src/solaris/classes/sun/awt/motif/MCheckboxMenuItemPeer.java - src/solaris/classes/sun/awt/motif/MCheckboxPeer.java - src/solaris/classes/sun/awt/motif/MChoicePeer.java - src/solaris/classes/sun/awt/motif/MComponentPeer.java - src/solaris/classes/sun/awt/motif/MCustomCursor.java - src/solaris/classes/sun/awt/motif/MDataTransferer.java - src/solaris/classes/sun/awt/motif/MDialogPeer.java - src/solaris/classes/sun/awt/motif/MDragSourceContextPeer.java - src/solaris/classes/sun/awt/motif/MDropTargetContextPeer.java - src/solaris/classes/sun/awt/motif/MEmbedCanvasPeer.java - src/solaris/classes/sun/awt/motif/MEmbeddedFrame.java - src/solaris/classes/sun/awt/motif/MEmbeddedFramePeer.java - src/solaris/classes/sun/awt/motif/MFileDialogPeer.java - src/solaris/classes/sun/awt/motif/MFramePeer.java - src/solaris/classes/sun/awt/motif/MGlobalCursorManager.java - src/solaris/classes/sun/awt/motif/MInputMethod.java - src/solaris/classes/sun/awt/motif/MInputMethodControl.java - src/solaris/classes/sun/awt/motif/MInputMethodDescriptor.java - src/solaris/classes/sun/awt/motif/MLabelPeer.java - src/solaris/classes/sun/awt/motif/MListPeer.java - src/solaris/classes/sun/awt/motif/MMenuBarPeer.java - src/solaris/classes/sun/awt/motif/MMenuItemPeer.java - src/solaris/classes/sun/awt/motif/MMenuPeer.java - src/solaris/classes/sun/awt/motif/MMouseDragGestureRecognizer.java - src/solaris/classes/sun/awt/motif/MPanelPeer.java - src/solaris/classes/sun/awt/motif/MPopupMenuPeer.java - src/solaris/classes/sun/awt/motif/MRobotPeer.java - src/solaris/classes/sun/awt/motif/MScrollPanePeer.java - src/solaris/classes/sun/awt/motif/MScrollbarPeer.java - src/solaris/classes/sun/awt/motif/MTextAreaPeer.java - src/solaris/classes/sun/awt/motif/MTextFieldPeer.java ! src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MWindowPeer.java - src/solaris/classes/sun/awt/motif/X11Clipboard.java - src/solaris/classes/sun/awt/motif/X11DragSourceContextPeer.java - src/solaris/classes/sun/awt/motif/X11DropTargetContextPeer.java - src/solaris/classes/sun/awt/motif/X11Selection.java - src/solaris/classes/sun/awt/motif/X11SelectionHolder.java - src/solaris/native/sun/awt/awt_Button.c - src/solaris/native/sun/awt/awt_Canvas.c - src/solaris/native/sun/awt/awt_Checkbox.c - src/solaris/native/sun/awt/awt_Choice12.c - src/solaris/native/sun/awt/awt_Choice21.c - src/solaris/native/sun/awt/awt_Component.c - src/solaris/native/sun/awt/awt_Cursor.c - src/solaris/native/sun/awt/awt_DataTransferer.c - src/solaris/native/sun/awt/awt_DataTransferer.h ! src/solaris/native/sun/awt/awt_DrawingSurface.c - src/solaris/native/sun/awt/awt_FileDialog.c - src/solaris/native/sun/awt/awt_GlobalCursorManager.c - src/solaris/native/sun/awt/awt_KeyboardFocusManager.c - src/solaris/native/sun/awt/awt_Label.c - src/solaris/native/sun/awt/awt_List.c ! src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_Menu.c - src/solaris/native/sun/awt/awt_Menu.h - src/solaris/native/sun/awt/awt_MenuBar.c - src/solaris/native/sun/awt/awt_MenuBar.h - src/solaris/native/sun/awt/awt_MenuComponent.c - src/solaris/native/sun/awt/awt_MenuItem.c - src/solaris/native/sun/awt/awt_PopupMenu.c ! src/solaris/native/sun/awt/awt_Robot.c - src/solaris/native/sun/awt/awt_ScrollPane.c - src/solaris/native/sun/awt/awt_Scrollbar.c - src/solaris/native/sun/awt/awt_Selection.c - src/solaris/native/sun/awt/awt_TextArea.c - src/solaris/native/sun/awt/awt_TextArea.h - src/solaris/native/sun/awt/awt_TextField.c - src/solaris/native/sun/awt/awt_TextField.h - src/solaris/native/sun/awt/awt_TopLevel.c - src/solaris/native/sun/awt/awt_XmDnD.c - src/solaris/native/sun/awt/awt_XmDnD.h - src/solaris/native/sun/awt/awt_dnd.c - src/solaris/native/sun/awt/awt_dnd.h - src/solaris/native/sun/awt/awt_dnd_ds.c - src/solaris/native/sun/awt/awt_dnd_dt.c - src/solaris/native/sun/awt/awt_motif.c - src/solaris/native/sun/awt/awt_motif12.c - src/solaris/native/sun/awt/awt_motif21.c ! src/solaris/native/sun/awt/awt_p.h - src/solaris/native/sun/awt/awt_xembed.c - src/solaris/native/sun/awt/canvas.c - src/solaris/native/sun/awt/cursor.c ! src/solaris/native/sun/awt/initIDs.c ! src/solaris/native/sun/awt/multi_font.c Changeset: fae7c1f5ba78 Author: dav Date: 2008-06-19 16:09 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fae7c1f5ba78 6694792: Syntax error in java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_2.java Reviewed-by: yan ! test/java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_2.java Changeset: 9b66576b81f0 Author: ant Date: 2008-06-23 14:42 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9b66576b81f0 6682536: java\awt\FullScreen\NonfocusableFrameFullScreenTest\NonfocusableFrameFullScreenTest.java fails Summary: always-on-top property should be restored on exiting full-screen. Reviewed-by: tdv ! src/windows/native/sun/windows/awt_Win32GraphicsDevice.cpp Changeset: 59e34bb65340 Author: anthony Date: 2008-06-23 16:03 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/59e34bb65340 6704896: FD_SET usage can cause stack corruption (sol) Summary: Using poll() instead of select() Reviewed-by: yan, denis ! src/solaris/native/sun/awt/splashscreen/splashscreen_sys.c Changeset: 4ccac6957211 Author: dcherepanov Date: 2008-06-26 14:23 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4ccac6957211 6581899: JTextField & JTextArea - Poor performance with JRE 1.5.0_08 Summary: acquire the first|last components only when the key is a traversal key Reviewed-by: ant ! src/share/classes/sun/awt/EmbeddedFrame.java Changeset: d2165ac39874 Author: dcherepanov Date: 2008-07-07 15:36 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d2165ac39874 6582346: javaw launcher does not display MessageBox after change to the resource files Summary: call InitCommonControlsEx to perform UI initialization Reviewed-by: art ! src/windows/native/sun/windows/ComCtl32Util.cpp ! src/windows/native/sun/windows/ComCtl32Util.h Changeset: d635c9a971c9 Author: dav Date: 2008-07-07 16:09 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d635c9a971c9 6693974: Unify EventQueue$EventQueueItem and SunToolkit.$EventQueueItem classes Reviewed-by: volk, art ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/sun/awt/SunToolkit.java Changeset: 9a1b30777d9d Author: dav Date: 2008-07-07 16:32 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a1b30777d9d Merge Changeset: 5a75640258ba Author: anthony Date: 2008-07-07 17:24 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5a75640258ba 6682046: Mixing code does not always recalculate shapes correctly when resizing components Summary: The valid property is now encapsulated in Component. Reviewed-by: art ! src/share/classes/java/awt/Button.java ! src/share/classes/java/awt/Checkbox.java ! src/share/classes/java/awt/Choice.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/Frame.java ! src/share/classes/java/awt/Label.java ! src/share/classes/java/awt/TextField.java Changeset: 3361b420a0a2 Author: anthony Date: 2008-07-07 17:39 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3361b420a0a2 6723018: Need to push the test for 6682046 Summary: Pushed the test Reviewed-by: art + test/java/awt/Mixing/Validating.java Changeset: 9c9f18a2cdef Author: dav Date: 2008-07-08 16:20 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9c9f18a2cdef 6723013: Incomplete push for 6693974 Reviewed-by: art + src/share/classes/sun/awt/EventQueueItem.java Changeset: 250129565224 Author: art Date: 2008-07-25 15:19 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/250129565224 6235443: REG:Overlapping a swing app with an AWT app causes flickering in the background swing app on Windows Summary: AWT text area no longer uses LockWindowUpdate Reviewed-by: uta, dcherepanov ! src/windows/native/sun/windows/awt_TextArea.cpp Changeset: 97d85ec01100 Author: yan Date: 2008-08-05 15:26 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/97d85ec01100 6454041: decimal separator munches the character standing at the right (sk keyboard) Summary: in a group of keysyms associated with a key, check for keypad-ness of more keysyms Reviewed-by: art ! src/solaris/classes/sun/awt/X11/XKeysym.java ! src/solaris/classes/sun/awt/X11/keysym2ucs.h Changeset: f0043a2428f6 Author: yan Date: 2008-08-08 03:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f0043a2428f6 Merge - make/java/nio/spp.sh ! make/sun/awt/FILES_export_unix.gmk ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers-linux - make/tools/winver/Makefile - make/tools/winver/bin/winver.exe - make/tools/winver/src/StdAfx.cpp - make/tools/winver/src/StdAfx.h - make/tools/winver/src/winver.cpp - src/share/classes/com/sun/jmx/mbeanserver/OpenConverter.java ! src/share/classes/java/awt/Button.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java - src/share/classes/javax/management/ToQueryString.java ! src/solaris/native/sun/awt/splashscreen/splashscreen_sys.c - src/windows/classes/sun/java2d/d3d/D3DBackBufferSurfaceData.java - src/windows/classes/sun/java2d/windows/DDBlitLoops.java - src/windows/classes/sun/java2d/windows/DDRenderer.java - src/windows/classes/sun/java2d/windows/DDScaleLoops.java - src/windows/classes/sun/java2d/windows/Win32OffScreenSurfaceData.java - src/windows/classes/sun/java2d/windows/Win32SurfaceData.java - src/windows/classes/sun/java2d/windows/Win32SurfaceDataProxy.java - src/windows/classes/sun/java2d/windows/WinBackBuffer.java - src/windows/classes/sun/java2d/windows/WinBackBufferSurfaceData.java - src/windows/classes/sun/java2d/windows/WinVolatileSurfaceManager.java - src/windows/native/sun/java2d/d3d/D3DRuntimeTest.cpp - src/windows/native/sun/java2d/d3d/D3DRuntimeTest.h - src/windows/native/sun/java2d/d3d/D3DTestRaster.h - src/windows/native/sun/java2d/d3d/D3DTextRenderer_md.cpp - src/windows/native/sun/java2d/d3d/D3DUtils.cpp - src/windows/native/sun/java2d/d3d/D3DUtils.h - src/windows/native/sun/java2d/windows/DDBlitLoops.cpp - src/windows/native/sun/java2d/windows/DDRenderer.cpp - src/windows/native/sun/java2d/windows/RegistryKey.cpp - src/windows/native/sun/java2d/windows/RegistryKey.h - src/windows/native/sun/java2d/windows/Win32OffScreenSurfaceData.cpp - src/windows/native/sun/java2d/windows/Win32SurfaceData.cpp - src/windows/native/sun/java2d/windows/Win32SurfaceData.h - src/windows/native/sun/java2d/windows/WinBackBufferSurfaceData.cpp - src/windows/native/sun/java2d/windows/ddrawObject.cpp - src/windows/native/sun/java2d/windows/ddrawObject.h - src/windows/native/sun/java2d/windows/ddrawUtils.cpp - src/windows/native/sun/java2d/windows/ddrawUtils.h - src/windows/native/sun/java2d/windows/dxCapabilities.cpp - src/windows/native/sun/java2d/windows/dxCapabilities.h - src/windows/native/sun/java2d/windows/dxInit.cpp - src/windows/native/sun/java2d/windows/dxInit.h ! src/windows/native/sun/windows/awt_Win32GraphicsDevice.cpp Changeset: 5e61b8180623 Author: art Date: 2008-08-12 12:00 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5e61b8180623 6735584: XNETProtocol:setStateHelper() produces bad _NET_WM_STATE messages Reviewed-by: yan ! src/solaris/classes/sun/awt/X11/XNETProtocol.java Changeset: 99658a8d42fa Author: art Date: 2008-08-14 12:58 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/99658a8d42fa 6708392: Provide internal API to create OverrideRedirect windows, XToolkit Summary: SunToolkit.setOverrideRedirect() method is introduced Reviewed-by: mlapshin, yan ! src/share/classes/javax/swing/Popup.java ! src/share/classes/sun/awt/SunToolkit.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java Changeset: e8301d67f7fa Author: dcherepanov Date: 2008-08-25 19:15 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e8301d67f7fa 6737722: api/java_awt/TrayIcon/index.html#TrayIconHeadlessMode Summary: isSupported() should skip tray initialization in case of headless Reviewed-by: art, ant ! src/share/classes/java/awt/SystemTray.java ! src/share/classes/java/awt/TrayIcon.java + test/java/awt/Toolkit/HeadlessTray/HeadlessTray.java Changeset: 9d5e52760d53 Author: lana Date: 2008-08-25 13:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9d5e52760d53 Merge - src/solaris/classes/sun/awt/motif/MButtonPeer.java - src/solaris/classes/sun/awt/motif/MCanvasPeer.java - src/solaris/classes/sun/awt/motif/MCheckboxMenuItemPeer.java - src/solaris/classes/sun/awt/motif/MCheckboxPeer.java - src/solaris/classes/sun/awt/motif/MChoicePeer.java - src/solaris/classes/sun/awt/motif/MComponentPeer.java - src/solaris/classes/sun/awt/motif/MCustomCursor.java - src/solaris/classes/sun/awt/motif/MDataTransferer.java - src/solaris/classes/sun/awt/motif/MDialogPeer.java - src/solaris/classes/sun/awt/motif/MDragSourceContextPeer.java - src/solaris/classes/sun/awt/motif/MDropTargetContextPeer.java - src/solaris/classes/sun/awt/motif/MEmbedCanvasPeer.java - src/solaris/classes/sun/awt/motif/MEmbeddedFrame.java - src/solaris/classes/sun/awt/motif/MEmbeddedFramePeer.java - src/solaris/classes/sun/awt/motif/MFileDialogPeer.java - src/solaris/classes/sun/awt/motif/MFramePeer.java - src/solaris/classes/sun/awt/motif/MGlobalCursorManager.java - src/solaris/classes/sun/awt/motif/MInputMethod.java - src/solaris/classes/sun/awt/motif/MInputMethodControl.java - src/solaris/classes/sun/awt/motif/MInputMethodDescriptor.java - src/solaris/classes/sun/awt/motif/MLabelPeer.java - src/solaris/classes/sun/awt/motif/MListPeer.java - src/solaris/classes/sun/awt/motif/MMenuBarPeer.java - src/solaris/classes/sun/awt/motif/MMenuItemPeer.java - src/solaris/classes/sun/awt/motif/MMenuPeer.java - src/solaris/classes/sun/awt/motif/MMouseDragGestureRecognizer.java - src/solaris/classes/sun/awt/motif/MPanelPeer.java - src/solaris/classes/sun/awt/motif/MPopupMenuPeer.java - src/solaris/classes/sun/awt/motif/MRobotPeer.java - src/solaris/classes/sun/awt/motif/MScrollPanePeer.java - src/solaris/classes/sun/awt/motif/MScrollbarPeer.java - src/solaris/classes/sun/awt/motif/MTextAreaPeer.java - src/solaris/classes/sun/awt/motif/MTextFieldPeer.java - src/solaris/classes/sun/awt/motif/MWindowPeer.java - src/solaris/classes/sun/awt/motif/X11Clipboard.java - src/solaris/classes/sun/awt/motif/X11DragSourceContextPeer.java - src/solaris/classes/sun/awt/motif/X11DropTargetContextPeer.java - src/solaris/classes/sun/awt/motif/X11Selection.java - src/solaris/classes/sun/awt/motif/X11SelectionHolder.java - src/solaris/native/sun/awt/awt_Button.c - src/solaris/native/sun/awt/awt_Canvas.c - src/solaris/native/sun/awt/awt_Checkbox.c - src/solaris/native/sun/awt/awt_Choice12.c - src/solaris/native/sun/awt/awt_Choice21.c - src/solaris/native/sun/awt/awt_Component.c - src/solaris/native/sun/awt/awt_Cursor.c - src/solaris/native/sun/awt/awt_DataTransferer.c - src/solaris/native/sun/awt/awt_DataTransferer.h - src/solaris/native/sun/awt/awt_FileDialog.c - src/solaris/native/sun/awt/awt_GlobalCursorManager.c - src/solaris/native/sun/awt/awt_KeyboardFocusManager.c - src/solaris/native/sun/awt/awt_Label.c - src/solaris/native/sun/awt/awt_List.c - src/solaris/native/sun/awt/awt_Menu.c - src/solaris/native/sun/awt/awt_Menu.h - src/solaris/native/sun/awt/awt_MenuBar.c - src/solaris/native/sun/awt/awt_MenuBar.h - src/solaris/native/sun/awt/awt_MenuComponent.c - src/solaris/native/sun/awt/awt_MenuItem.c - src/solaris/native/sun/awt/awt_PopupMenu.c - src/solaris/native/sun/awt/awt_ScrollPane.c - src/solaris/native/sun/awt/awt_Scrollbar.c - src/solaris/native/sun/awt/awt_Selection.c - src/solaris/native/sun/awt/awt_TextArea.c - src/solaris/native/sun/awt/awt_TextArea.h - src/solaris/native/sun/awt/awt_TextField.c - src/solaris/native/sun/awt/awt_TextField.h - src/solaris/native/sun/awt/awt_TopLevel.c - src/solaris/native/sun/awt/awt_XmDnD.c - src/solaris/native/sun/awt/awt_XmDnD.h - src/solaris/native/sun/awt/awt_dnd.c - src/solaris/native/sun/awt/awt_dnd.h - src/solaris/native/sun/awt/awt_dnd_ds.c - src/solaris/native/sun/awt/awt_dnd_dt.c - src/solaris/native/sun/awt/awt_motif.c - src/solaris/native/sun/awt/awt_motif12.c - src/solaris/native/sun/awt/awt_motif21.c - src/solaris/native/sun/awt/awt_xembed.c - src/solaris/native/sun/awt/canvas.c - src/solaris/native/sun/awt/cursor.c Changeset: 134fd1a656ea Author: lana Date: 2008-09-19 19:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/134fd1a656ea Merge - src/solaris/classes/sun/awt/motif/MButtonPeer.java - src/solaris/classes/sun/awt/motif/MCanvasPeer.java - src/solaris/classes/sun/awt/motif/MCheckboxMenuItemPeer.java - src/solaris/classes/sun/awt/motif/MCheckboxPeer.java - src/solaris/classes/sun/awt/motif/MChoicePeer.java - src/solaris/classes/sun/awt/motif/MComponentPeer.java - src/solaris/classes/sun/awt/motif/MCustomCursor.java - src/solaris/classes/sun/awt/motif/MDataTransferer.java - src/solaris/classes/sun/awt/motif/MDialogPeer.java - src/solaris/classes/sun/awt/motif/MDragSourceContextPeer.java - src/solaris/classes/sun/awt/motif/MDropTargetContextPeer.java - src/solaris/classes/sun/awt/motif/MEmbedCanvasPeer.java - src/solaris/classes/sun/awt/motif/MEmbeddedFrame.java - src/solaris/classes/sun/awt/motif/MEmbeddedFramePeer.java - src/solaris/classes/sun/awt/motif/MFileDialogPeer.java - src/solaris/classes/sun/awt/motif/MFramePeer.java - src/solaris/classes/sun/awt/motif/MGlobalCursorManager.java - src/solaris/classes/sun/awt/motif/MInputMethod.java - src/solaris/classes/sun/awt/motif/MInputMethodControl.java - src/solaris/classes/sun/awt/motif/MInputMethodDescriptor.java - src/solaris/classes/sun/awt/motif/MLabelPeer.java - src/solaris/classes/sun/awt/motif/MListPeer.java - src/solaris/classes/sun/awt/motif/MMenuBarPeer.java - src/solaris/classes/sun/awt/motif/MMenuItemPeer.java - src/solaris/classes/sun/awt/motif/MMenuPeer.java - src/solaris/classes/sun/awt/motif/MMouseDragGestureRecognizer.java - src/solaris/classes/sun/awt/motif/MPanelPeer.java - src/solaris/classes/sun/awt/motif/MPopupMenuPeer.java - src/solaris/classes/sun/awt/motif/MRobotPeer.java - src/solaris/classes/sun/awt/motif/MScrollPanePeer.java - src/solaris/classes/sun/awt/motif/MScrollbarPeer.java - src/solaris/classes/sun/awt/motif/MTextAreaPeer.java - src/solaris/classes/sun/awt/motif/MTextFieldPeer.java - src/solaris/classes/sun/awt/motif/MWindowPeer.java - src/solaris/classes/sun/awt/motif/X11Clipboard.java - src/solaris/classes/sun/awt/motif/X11DragSourceContextPeer.java - src/solaris/classes/sun/awt/motif/X11DropTargetContextPeer.java - src/solaris/classes/sun/awt/motif/X11Selection.java - src/solaris/classes/sun/awt/motif/X11SelectionHolder.java - src/solaris/native/sun/awt/awt_Button.c - src/solaris/native/sun/awt/awt_Canvas.c - src/solaris/native/sun/awt/awt_Checkbox.c - src/solaris/native/sun/awt/awt_Choice12.c - src/solaris/native/sun/awt/awt_Choice21.c - src/solaris/native/sun/awt/awt_Component.c - src/solaris/native/sun/awt/awt_Cursor.c - src/solaris/native/sun/awt/awt_DataTransferer.c - src/solaris/native/sun/awt/awt_DataTransferer.h - src/solaris/native/sun/awt/awt_FileDialog.c - src/solaris/native/sun/awt/awt_GlobalCursorManager.c - src/solaris/native/sun/awt/awt_KeyboardFocusManager.c - src/solaris/native/sun/awt/awt_Label.c - src/solaris/native/sun/awt/awt_List.c - src/solaris/native/sun/awt/awt_Menu.c - src/solaris/native/sun/awt/awt_Menu.h - src/solaris/native/sun/awt/awt_MenuBar.c - src/solaris/native/sun/awt/awt_MenuBar.h - src/solaris/native/sun/awt/awt_MenuComponent.c - src/solaris/native/sun/awt/awt_MenuItem.c - src/solaris/native/sun/awt/awt_PopupMenu.c - src/solaris/native/sun/awt/awt_ScrollPane.c - src/solaris/native/sun/awt/awt_Scrollbar.c - src/solaris/native/sun/awt/awt_Selection.c - src/solaris/native/sun/awt/awt_TextArea.c - src/solaris/native/sun/awt/awt_TextArea.h - src/solaris/native/sun/awt/awt_TextField.c - src/solaris/native/sun/awt/awt_TextField.h - src/solaris/native/sun/awt/awt_TopLevel.c - src/solaris/native/sun/awt/awt_XmDnD.c - src/solaris/native/sun/awt/awt_XmDnD.h - src/solaris/native/sun/awt/awt_dnd.c - src/solaris/native/sun/awt/awt_dnd.h - src/solaris/native/sun/awt/awt_dnd_ds.c - src/solaris/native/sun/awt/awt_dnd_dt.c - src/solaris/native/sun/awt/awt_motif.c - src/solaris/native/sun/awt/awt_motif12.c - src/solaris/native/sun/awt/awt_motif21.c - src/solaris/native/sun/awt/awt_xembed.c - src/solaris/native/sun/awt/canvas.c - src/solaris/native/sun/awt/cursor.c Changeset: b54ba7058851 Author: tbell Date: 2008-09-22 22:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b54ba7058851 Merge Changeset: 73b3e1a40bdf Author: xdono Date: 2008-09-25 12:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/73b3e1a40bdf Added tag jdk7-b36 for changeset 134fd1a656ea ! .hgtags Changeset: ed8f850f9f94 Author: tbell Date: 2008-09-26 15:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ed8f850f9f94 Merge Changeset: b3234ba261fa Author: tbell Date: 2008-09-29 22:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b3234ba261fa Merge - src/share/classes/sun/launcher/LauncherHelp.java - test/tools/launcher/Arrrghs.sh From tim.bell at sun.com Wed Oct 1 18:21:05 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Wed, 01 Oct 2008 18:21:05 +0000 Subject: hg: jdk7/tl/langtools: 3 new changesets Message-ID: <20081001182112.56900D86A@hg.openjdk.java.net> Changeset: 2c643f1be517 Author: xdono Date: 2008-09-25 12:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2c643f1be517 Added tag jdk7-b36 for changeset 258af9b67b7c ! .hgtags Changeset: 2e3d9966e62b Author: tbell Date: 2008-09-26 15:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2e3d9966e62b Merge Changeset: 4ef127d365dd Author: tbell Date: 2008-09-29 22:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4ef127d365dd Merge - test/tools/javac/policy/A.java - test/tools/javac/policy/B.java - test/tools/javac/policy/C.java - test/tools/javac/policy/D.java - test/tools/javac/policy/Test.java - test/tools/javac/policy/byfile.ABD.out - test/tools/javac/policy/byfile.ACD.out - test/tools/javac/policy/bytodo.ABD.out - test/tools/javac/policy/bytodo.ACD.out - test/tools/javac/policy/simple.ABD.out - test/tools/javac/policy/simple.ACD.out From jonathan.gibbons at sun.com Wed Oct 1 23:28:48 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 01 Oct 2008 23:28:48 +0000 Subject: hg: jdk7/tl/langtools: 6748601: javadoc API should allow varargs use Message-ID: <20081001232850.8BB64D8D2@hg.openjdk.java.net> Changeset: d593587c5938 Author: jjg Date: 2008-10-01 16:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d593587c5938 6748601: javadoc API should allow varargs use Reviewed-by: bpatel ! src/share/classes/com/sun/tools/javadoc/Main.java ! src/share/classes/com/sun/tools/javadoc/Start.java From jim.holmlund at sun.com Fri Oct 3 01:25:51 2008 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Fri, 03 Oct 2008 01:25:51 +0000 Subject: hg: jdk7/tl/jdk: 6751643: ThreadReference.ownedMonitors() can return null Message-ID: <20081003012629.EF056DA9F@hg.openjdk.java.net> Changeset: c272f261ad10 Author: jjh Date: 2008-10-02 18:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c272f261ad10 6751643: ThreadReference.ownedMonitors() can return null Summary: Make a local copy of the cache so it doesn't get modified by a racy resume Reviewed-by: dcubed, swamyv ! src/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java + test/com/sun/jdi/SimulResumerTest.java From mandy.chung at sun.com Fri Oct 3 17:01:34 2008 From: mandy.chung at sun.com (mandy.chung at sun.com) Date: Fri, 03 Oct 2008 17:01:34 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20081003170225.D9F65DAFD@hg.openjdk.java.net> Changeset: faa3673d7624 Author: mchung Date: 2008-10-02 16:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/faa3673d7624 6581243: Service Tag and Product Registration Support in JDK 7 Summary: Include service tag creation and product registration support in JDK Reviewed-by: ksrini ! make/com/sun/Makefile + make/com/sun/servicetag/Makefile + src/share/classes/com/sun/servicetag/BrowserSupport.java + src/share/classes/com/sun/servicetag/Installer.java + src/share/classes/com/sun/servicetag/LinuxSystemEnvironment.java + src/share/classes/com/sun/servicetag/RegistrationData.java + src/share/classes/com/sun/servicetag/RegistrationDocument.java + src/share/classes/com/sun/servicetag/Registry.java + src/share/classes/com/sun/servicetag/ServiceTag.java + src/share/classes/com/sun/servicetag/SolarisServiceTag.java + src/share/classes/com/sun/servicetag/SolarisSystemEnvironment.java + src/share/classes/com/sun/servicetag/SunConnection.java + src/share/classes/com/sun/servicetag/SystemEnvironment.java + src/share/classes/com/sun/servicetag/UnauthorizedAccessException.java + src/share/classes/com/sun/servicetag/Util.java + src/share/classes/com/sun/servicetag/WindowsSystemEnvironment.java + src/share/classes/com/sun/servicetag/package.html + src/share/classes/com/sun/servicetag/resources/Putback-Notes.txt + src/share/classes/com/sun/servicetag/resources/javase_5_swordfish.properties + src/share/classes/com/sun/servicetag/resources/javase_6_swordfish.properties + src/share/classes/com/sun/servicetag/resources/javase_7_swordfish.properties + src/share/classes/com/sun/servicetag/resources/jdk_header.png + src/share/classes/com/sun/servicetag/resources/product_registration.xsd + src/share/classes/com/sun/servicetag/resources/register.html + src/share/classes/com/sun/servicetag/resources/register_ja.html + src/share/classes/com/sun/servicetag/resources/register_zh_CN.html + test/com/sun/servicetag/DeleteServiceTag.java + test/com/sun/servicetag/DuplicateNotFound.java + test/com/sun/servicetag/FindServiceTags.java + test/com/sun/servicetag/InstanceUrnCheck.java + test/com/sun/servicetag/InvalidRegistrationData.java + test/com/sun/servicetag/InvalidServiceTag.java + test/com/sun/servicetag/JavaServiceTagTest.java + test/com/sun/servicetag/JavaServiceTagTest1.java + test/com/sun/servicetag/NewRegistrationData.java + test/com/sun/servicetag/SvcTagClient.java + test/com/sun/servicetag/SystemRegistryTest.java + test/com/sun/servicetag/TestLoadFromXML.java + test/com/sun/servicetag/UpdateServiceTagTest.java + test/com/sun/servicetag/Util.java + test/com/sun/servicetag/ValidRegistrationData.java + test/com/sun/servicetag/environ.properties + test/com/sun/servicetag/missing-environ-field.xml + test/com/sun/servicetag/newer-registry-version.xml + test/com/sun/servicetag/registration.xml + test/com/sun/servicetag/servicetag1.properties + test/com/sun/servicetag/servicetag2.properties + test/com/sun/servicetag/servicetag3.properties + test/com/sun/servicetag/servicetag4.properties + test/com/sun/servicetag/servicetag5.properties Changeset: d74db4a9799a Author: mchung Date: 2008-10-03 09:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d74db4a9799a Merge From kumar.srinivasan at sun.com Fri Oct 3 23:05:41 2008 From: kumar.srinivasan at sun.com (kumar.srinivasan at sun.com) Date: Fri, 03 Oct 2008 23:05:41 +0000 Subject: hg: jdk7/tl/jdk: 4459600: java -jar fails to run Main-Class if classname followed by whitespace. Message-ID: <20081003230628.06016DB69@hg.openjdk.java.net> Changeset: 906b5be0eca5 Author: ksrini Date: 2008-10-01 09:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/906b5be0eca5 4459600: java -jar fails to run Main-Class if classname followed by whitespace. Summary: Fixed whitespace trimming in the manifest as well as post review comments on CR: 6742159 Reviewed-by: darcy, dholmes ! src/share/classes/sun/launcher/LauncherHelper.java ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/TestHelper.java From jaroslav.tulach at sun.com Sat Oct 4 17:28:25 2008 From: jaroslav.tulach at sun.com (Jaroslav Tulach) Date: Sat, 04 Oct 2008 19:28:25 +0200 Subject: [PATCH] Enhance ServiceLoader to understand factory methods Message-ID: Proposal: Enhance ServiceLoader to understand factory methods Justification: A lot of our services in NetBeans are final classes. Still, we would like to use the META-INF/services registration to register their providers. Currently this does not work, we either need to unfinalize the classes (which restricts future evolution options) or use different ways of registering the providers. We propose simple and backward compatible extension to current ServiceLoader registration scheme. If accepted, NetBeans'll eliminate our non-standard registration methods, while keeping benefits of final classes. Moreover the same techniques will be available to any JavaSE project. Risks: API change includes simple, compatible extension. New code is able to accept old registrations. Old code (JDK6) will generate ServiceConfigurationError in case of seeing new registration, however. Test: I have found tests in test/java/util/ServiceLoader/ directory and I've modified them to verify also our new usecase. All of them are passing, if I run them by running ./basic.sh script - I am not sure if that is the right way of running your tests. I am attaching my current patch. Let me know what shall I change to allow this to be integrated to OpenJDK7. Thanks a lot. Jaroslav Tulach NetBeans Platform Architect -------------- next part -------------- A non-text attachment was scrubbed... Name: ServiceLoaderForFactories.diff Type: text/x-diff Size: 4591 bytes Desc: not available URL: From tim.bell at sun.com Mon Oct 6 05:01:54 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 06 Oct 2008 05:01:54 +0000 Subject: hg: jdk7/tl: 6754988: Update copyright year Message-ID: <20081006050154.7C501DBF6@hg.openjdk.java.net> Changeset: 744554f5a329 Author: xdono Date: 2008-10-02 19:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/744554f5a329 6754988: Update copyright year Summary: Update for files that have been modified starting July 2008 Reviewed-by: ohair, tbell ! make/jprt.gmk From tim.bell at sun.com Mon Oct 6 05:03:04 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 06 Oct 2008 05:03:04 +0000 Subject: hg: jdk7/tl/corba: 6754988: Update copyright year Message-ID: <20081006050305.8AE0DDBFB@hg.openjdk.java.net> Changeset: 59d5848bdede Author: xdono Date: 2008-10-02 19:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/59d5848bdede 6754988: Update copyright year Summary: Update for files that have been modified starting July 2008 Reviewed-by: ohair, tbell ! make/com/sun/corba/minclude/com_sun_corba_se_impl_dynamicany.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_impl_encoding.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_impl_ior.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_impl_orbutil.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_impl_protocol.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_spi_legacy_interceptor.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_spi_monitoring.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_spi_presentation_rmi.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_spi_transport.jmk ! make/com/sun/corba/minclude/org_omg_CosNaming.jmk ! make/com/sun/corba/minclude/org_omg_DynamicAny.jmk ! make/com/sun/corba/minclude/org_omg_PortableInterceptor.jmk ! make/com/sun/corba/se/sources/Makefile ! make/javax/xa/Makefile ! make/org/omg/CORBA/Makefile From tim.bell at sun.com Mon Oct 6 05:04:18 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 06 Oct 2008 05:04:18 +0000 Subject: hg: jdk7/tl/hotspot: 6754988: Update copyright year Message-ID: <20081006050422.99E52DC06@hg.openjdk.java.net> Changeset: 9ee9cf798b59 Author: xdono Date: 2008-10-02 19:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9ee9cf798b59 6754988: Update copyright year Summary: Update for files that have been modified starting July 2008 Reviewed-by: ohair, tbell ! agent/make/bugspot.bat ! agent/make/build.xml ! agent/make/hsdb.bat ! agent/make/hsdb.sh ! agent/make/saenv.bat ! agent/make/saenv.sh ! agent/make/saenv64.bat ! agent/make/saenv64.sh ! agent/src/share/classes/sun/jvm/hotspot/runtime/CompiledVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PermStat.java ! src/cpu/x86/vm/assembler_x86.inline.hpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/x86/vm/c1_Defs_x86.hpp ! src/cpu/x86/vm/c1_FrameMap_x86.cpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.hpp ! src/cpu/x86/vm/c1_LinearScan_x86.hpp ! src/cpu/x86/vm/c1_MacroAssembler_x86.hpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/dump_x86_32.cpp ! src/cpu/x86/vm/dump_x86_64.cpp ! src/cpu/x86/vm/icache_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/cpu/x86/vm/interpreterRT_x86_32.cpp ! src/cpu/x86/vm/interpreterRT_x86_64.cpp ! src/cpu/x86/vm/interpreter_x86_32.cpp ! src/cpu/x86/vm/jniFastGetField_x86_32.cpp ! src/cpu/x86/vm/jniFastGetField_x86_64.cpp ! src/cpu/x86/vm/runtime_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.hpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_32.hpp ! src/cpu/x86/vm/vtableStubs_x86_32.cpp ! src/os/solaris/vm/osThread_solaris.cpp ! src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/solaris_x86_32.ad ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/c1/c1_FrameMap.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_LinearScan.hpp ! src/share/vm/ci/ciTypeFlow.hpp ! src/share/vm/code/relocInfo.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/psOldGen.hpp ! src/share/vm/gc_implementation/parallelScavenge/psVirtualspace.cpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.hpp ! src/share/vm/gc_implementation/shared/gcUtil.hpp ! src/share/vm/gc_implementation/shared/spaceDecorator.cpp ! src/share/vm/gc_implementation/shared/spaceDecorator.hpp ! src/share/vm/includeDB_features ! src/share/vm/memory/blockOffsetTable.hpp ! src/share/vm/memory/compactingPermGenGen.hpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/coalesce.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/ifg.cpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/runtime/statSampler.cpp ! src/share/vm/runtime/threadLocalStorage.cpp ! src/share/vm/runtime/threadLocalStorage.hpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/virtualspace.hpp ! src/share/vm/utilities/macros.hpp From tim.bell at sun.com Mon Oct 6 05:05:52 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 06 Oct 2008 05:05:52 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20081006050643.477D9DC14@hg.openjdk.java.net> Changeset: 14f50aee4989 Author: xdono Date: 2008-10-02 19:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/14f50aee4989 6754988: Update copyright year Summary: Update for files that have been modified starting July 2008 Reviewed-by: ohair, tbell ! make/com/sun/inputmethods/indicim/Makefile ! make/com/sun/inputmethods/thaiim/Makefile ! make/com/sun/java/pack/Makefile ! make/com/sun/security/auth/module/Makefile ! make/common/BuildToolJar.gmk ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/internal/ImportComponents.gmk ! make/common/shared/Defs-java.gmk ! make/common/shared/Defs-windows.gmk ! make/java/fdlibm/Makefile ! make/java/hpi/windows/Makefile ! make/java/java/FILES_java.gmk ! make/java/java_crw_demo/Makefile ! make/java/java_hprof_demo/Makefile ! make/java/management/Makefile ! make/java/net/Makefile ! make/java/net/mapfile-vers ! make/java/nio/FILES_java.gmk ! make/java/nio/genCoder.sh ! make/java/npt/Makefile ! make/java/zip/Makefile ! make/javax/swing/beaninfo/SwingBeans.gmk ! make/jpda/back/Makefile ! make/jpda/transport/shmem/Makefile ! make/jpda/transport/socket/Makefile ! make/jprt.properties ! make/mksample/nio/Makefile ! make/mksample/nio/multicast/Makefile ! make/netbeans/jconsole/build.properties ! make/netbeans/jconsole/build.xml ! make/sun/cmm/kcms/Makefile ! make/sun/font/t2k/Makefile ! make/sun/image/generic/Makefile ! make/sun/image/vis/Makefile ! make/sun/jconsole/Makefile ! make/sun/jdbc/Makefile ! make/sun/jpeg/Makefile ! make/sun/net/spi/nameservice/dns/Makefile ! make/sun/text/Makefile ! src/share/back/ThreadReferenceImpl.c ! src/share/back/eventFilter.c ! src/share/back/transport.c ! src/share/classes/com/sun/jmx/defaults/JmxProperties.java ! src/share/classes/com/sun/jmx/event/DaemonThreadFactory.java ! src/share/classes/com/sun/jmx/event/EventBuffer.java ! src/share/classes/com/sun/jmx/event/EventClientFactory.java ! src/share/classes/com/sun/jmx/event/EventConnection.java ! src/share/classes/com/sun/jmx/event/EventParams.java ! src/share/classes/com/sun/jmx/event/LeaseManager.java ! src/share/classes/com/sun/jmx/event/LeaseRenewer.java ! src/share/classes/com/sun/jmx/event/ReceiverBuffer.java ! src/share/classes/com/sun/jmx/event/RepeatedSingletonJob.java ! src/share/classes/com/sun/jmx/mbeanserver/DynamicMBean2.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanInjector.java ! src/share/classes/com/sun/jmx/mbeanserver/NotifySupport.java ! src/share/classes/com/sun/jmx/mbeanserver/PerThreadGroupPool.java ! src/share/classes/com/sun/jmx/mbeanserver/StandardMBeanIntrospector.java ! src/share/classes/com/sun/jmx/mbeanserver/SunJmxMBeanServer.java ! src/share/classes/com/sun/jmx/remote/internal/ClientCommunicatorAdmin.java ! src/share/classes/com/sun/jmx/remote/internal/ProxyInputStream.java ! src/share/classes/com/sun/jmx/remote/internal/ProxyRef.java ! src/share/classes/com/sun/jmx/remote/util/EnvHelp.java ! src/share/classes/com/sun/jmx/remote/util/EventClientConnection.java ! src/share/classes/com/sun/jmx/snmp/tasks/ThreadService.java ! src/share/classes/com/sun/tools/jdi/MonitorInfoImpl.java ! src/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/VMAction.java ! src/share/classes/com/sun/tools/jdi/VMState.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/StringBuffer.java ! src/share/classes/java/lang/StringBuilder.java ! src/share/classes/java/net/Inet6Address.java ! src/share/classes/java/nio/Bits.java ! src/share/classes/java/nio/ByteBufferAs-X-Buffer.java ! src/share/classes/java/nio/Direct-X-Buffer.java ! src/share/classes/java/nio/Heap-X-Buffer.java ! src/share/classes/java/nio/X-Buffer.java ! src/share/classes/java/nio/channels/DatagramChannel.java ! src/share/classes/java/nio/channels/SelectionKey.java ! src/share/classes/java/nio/channels/ServerSocketChannel.java ! src/share/classes/java/nio/channels/SocketChannel.java ! src/share/classes/java/nio/channels/exceptions ! src/share/classes/java/nio/channels/package-info.java ! src/share/classes/java/nio/channels/spi/AbstractSelector.java ! src/share/classes/java/nio/charset/Charset-X-Coder.java ! src/share/classes/java/nio/charset/CoderResult.java ! src/share/classes/java/util/CurrencyData.properties ! src/share/classes/java/util/EnumSet.java ! src/share/classes/java/util/Timer.java ! src/share/classes/javax/management/Description.java ! src/share/classes/javax/management/Descriptor.java ! src/share/classes/javax/management/DescriptorFields.java ! src/share/classes/javax/management/DescriptorKey.java ! src/share/classes/javax/management/DynamicWrapperMBean.java ! src/share/classes/javax/management/Impact.java ! src/share/classes/javax/management/InstanceNotFoundException.java ! src/share/classes/javax/management/MBean.java ! src/share/classes/javax/management/MBeanOperationInfo.java ! src/share/classes/javax/management/MBeanPermission.java ! src/share/classes/javax/management/MBeanRegistration.java ! src/share/classes/javax/management/MBeanServerConnection.java ! src/share/classes/javax/management/MBeanServerDelegate.java ! src/share/classes/javax/management/MBeanServerFactory.java ! src/share/classes/javax/management/MBeanServerNotification.java ! src/share/classes/javax/management/ManagedAttribute.java ! src/share/classes/javax/management/ManagedOperation.java ! src/share/classes/javax/management/NotificationBroadcasterSupport.java ! src/share/classes/javax/management/NotificationInfo.java ! src/share/classes/javax/management/NotificationInfos.java ! src/share/classes/javax/management/SendNotification.java ! src/share/classes/javax/management/StandardEmitterMBean.java ! src/share/classes/javax/management/event/EventClient.java ! src/share/classes/javax/management/event/EventClientDelegate.java ! src/share/classes/javax/management/event/EventClientDelegateMBean.java ! src/share/classes/javax/management/event/EventClientNotFoundException.java ! src/share/classes/javax/management/event/EventConsumer.java ! src/share/classes/javax/management/event/EventForwarder.java ! src/share/classes/javax/management/event/EventReceiver.java ! src/share/classes/javax/management/event/EventRelay.java ! src/share/classes/javax/management/event/FetchingEventForwarder.java ! src/share/classes/javax/management/event/FetchingEventRelay.java ! src/share/classes/javax/management/event/ListenerInfo.java ! src/share/classes/javax/management/event/NotificationManager.java ! src/share/classes/javax/management/event/RMIPushEventForwarder.java ! src/share/classes/javax/management/event/RMIPushEventRelay.java ! src/share/classes/javax/management/event/RMIPushServer.java ! src/share/classes/javax/management/openmbean/CompositeDataSupport.java ! src/share/classes/javax/management/openmbean/TabularDataSupport.java ! src/share/classes/javax/management/remote/JMXConnector.java ! src/share/classes/javax/management/remote/JMXConnectorServer.java ! src/share/classes/javax/management/remote/JMXConnectorServerMBean.java ! src/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java ! src/share/classes/javax/net/ssl/SSLServerSocket.java ! src/share/classes/sun/font/NullFontScaler.java ! src/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/LocalMonitoredVm.java ! src/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/MonitoredHostProvider.java ! src/share/classes/sun/misc/SharedSecrets.java ! src/share/classes/sun/net/httpserver/ChunkedOutputStream.java ! src/share/classes/sun/net/httpserver/ServerImpl.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/DatagramSocketAdaptor.java ! src/share/classes/sun/nio/ch/Net.java ! src/share/classes/sun/nio/ch/SelectorImpl.java ! src/share/classes/sun/nio/ch/SelectorProviderImpl.java ! src/share/classes/sun/nio/ch/ServerSocketAdaptor.java ! src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/share/classes/sun/nio/cs/standard-charsets ! src/share/classes/sun/reflect/generics/factory/CoreReflectionFactory.java ! src/share/classes/sun/text/resources/FormatData_sv.java ! src/share/classes/sun/tools/jconsole/Plotter.java ! src/share/classes/sun/tools/jmap/JMap.java ! src/share/demo/jvmti/hprof/hprof_io.c ! src/share/demo/jvmti/hprof/hprof_util.c ! src/share/native/java/net/net_util.h ! src/share/native/java/nio/Bits.c ! src/share/native/sun/nio/ch/genSocketOptionRegistry.c ! src/share/transport/shmem/shmemBack.c ! src/share/transport/shmem/shmemBase.c ! src/share/transport/socket/socketTransport.c ! src/share/transport/socket/sysSocket.h ! src/solaris/classes/sun/nio/ch/DevPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/EPollArrayWrapper.java ! src/solaris/classes/sun/nio/ch/EPollSelectorImpl.java ! src/solaris/native/com/sun/media/sound/PLATFORM_API_SolarisOS_Utils.h ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/SocketInputStream.c ! src/solaris/native/java/net/SocketOutputStream.c ! src/solaris/native/java/net/linux_close.c ! src/solaris/native/java/net/net_util_md.c ! src/solaris/native/java/nio/MappedByteBuffer.c ! src/solaris/native/sun/nio/ch/DatagramChannelImpl.c ! src/solaris/native/sun/nio/ch/EPollArrayWrapper.c ! src/solaris/native/sun/nio/ch/FileKey.c ! src/solaris/native/sun/nio/ch/InheritedChannel.c ! src/solaris/native/sun/nio/ch/Net.c ! src/solaris/native/sun/nio/ch/ServerSocketChannelImpl.c ! src/solaris/native/sun/nio/ch/SocketChannelImpl.c ! src/solaris/native/sun/nio/ch/nio_util.h ! src/solaris/transport/socket/socket_md.c ! src/windows/classes/sun/nio/ch/PipeImpl.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java ! src/windows/javavm/export/jvm_md.h ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface.h ! src/windows/native/java/net/NetworkInterface_win9x.c ! src/windows/native/java/net/NetworkInterface_winXP.c ! src/windows/native/java/net/SocketOutputStream.c ! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c ! src/windows/native/java/net/TwoStacksPlainSocketImpl.c ! src/windows/native/java/net/net_util_md.h ! src/windows/native/sun/net/dns/ResolverConfigurationImpl.c ! src/windows/native/sun/nio/ch/DatagramChannelImpl.c ! src/windows/native/sun/nio/ch/Net.c ! src/windows/native/sun/nio/ch/ServerSocketChannelImpl.c ! src/windows/native/sun/nio/ch/SocketChannelImpl.c ! src/windows/native/sun/nio/ch/WindowsSelectorImpl.c ! src/windows/native/sun/windows/ComCtl32Util.cpp ! src/windows/native/sun/windows/ComCtl32Util.h ! src/windows/native/sun/windows/awt_TextArea.cpp ! src/windows/transport/socket/socket_md.c ! src/windows/transport/socket/socket_md.h ! test/com/sun/jdi/ClassesByName2Test.java ! test/com/sun/jdi/ConnectedVMs.java ! test/com/sun/jdi/MonitorFrameInfo.java ! test/com/sun/jdi/Solaris32AndSolaris64Test.sh ! test/com/sun/jdi/SourceNameFilterTest.java ! test/com/sun/jdi/VMConnection.java ! test/com/sun/net/httpserver/bugs/B6744329.java ! test/java/lang/management/ManagementFactory/ThreadMXBeanProxy.java ! test/java/lang/management/ThreadMXBean/Locks.java ! test/java/net/CookieHandler/TestHttpCookie.java ! test/java/net/Inet6Address/serialize/Serialize.java ! test/java/nio/channels/FileChannel/ExpandingMap.java ! test/java/nio/channels/Selector/Wakeup.java ! test/javax/management/Introspector/AnnotatedMBeanTest.java ! test/javax/management/Introspector/AnnotatedNotificationInfoTest.java ! test/javax/management/Introspector/MBeanDescriptionTest.java ! test/javax/management/Introspector/ParameterNameTest.java ! test/javax/management/Introspector/ResourceInjectionTest.java ! test/javax/management/Introspector/annot/Name.java ! test/javax/management/MBeanInfo/NotificationInfoTest.java ! test/javax/management/MBeanServer/DynamicWrapperMBeanTest.java ! test/javax/management/MBeanServer/OldMBeanServerTest.java ! test/javax/management/MBeanServerFactory/NamedMBeanServerTest.java ! test/javax/management/ObjectName/ApplyWildcardTest.java ! test/javax/management/ObjectName/SerialCompatTest.java ! test/javax/management/eventService/AddRemoveListenerTest.java ! test/javax/management/eventService/CustomForwarderTest.java ! test/javax/management/eventService/EventManagerTest.java ! test/javax/management/eventService/FetchingTest.java ! test/javax/management/eventService/LeaseTest.java ! test/javax/management/eventService/ListenerTest.java ! test/javax/management/eventService/NotSerializableNotifTest.java ! test/javax/management/eventService/PublishTest.java ! test/javax/management/eventService/ReconnectableConnectorTest.java ! test/javax/management/eventService/SharingThreadTest.java ! test/javax/management/mxbean/ComparatorExceptionTest.java ! test/javax/management/mxbean/GenericArrayTypeTest.java ! test/javax/management/mxbean/LeakTest.java ! test/javax/management/mxbean/MBeanOperationInfoTest.java ! test/javax/management/mxbean/MXBeanTest.java ! test/javax/management/mxbean/SameObjectTwoNamesTest.java ! test/javax/management/mxbean/ThreadMXBeanTest.java ! test/javax/management/mxbean/TigerMXBean.java ! test/javax/management/remote/mandatory/connection/CloseServerTest.java ! test/javax/management/remote/mandatory/connection/DeadLockTest.java ! test/javax/management/remote/mandatory/connection/IdleTimeoutTest.java ! test/javax/management/remote/mandatory/connection/RMIExitTest.java ! test/javax/management/remote/mandatory/connection/ReconnectTest.java ! test/javax/management/remote/mandatory/loading/MissingClassTest.java ! test/javax/management/remote/mandatory/notif/AddRemoveTest.java ! test/javax/management/remote/mandatory/notif/DiffHBTest.java ! test/javax/management/remote/mandatory/notif/EmptyDomainNotificationTest.java ! test/javax/management/remote/mandatory/notif/ListenerScaleTest.java ! test/javax/management/remote/mandatory/notif/NotifBufferSizePropertyNameTest.java ! test/javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java ! test/javax/management/remote/mandatory/notif/NotificationAccessControllerTest.java ! test/javax/management/remote/mandatory/notif/NotificationBufferCreationTest.java ! test/javax/management/remote/mandatory/notif/NotificationBufferDeadlockTest.java ! test/javax/management/remote/mandatory/notif/NotificationEmissionTest.java ! test/javax/management/remote/mandatory/notif/RMINotifTest.java ! test/javax/management/remote/mandatory/notif/UnexpectedNotifTest.java ! test/javax/script/E4XErrorTest.java ! test/javax/script/JavaScriptScopeTest.java ! test/javax/script/NullUndefinedVarTest.java ! test/javax/script/PluggableContextTest.java ! test/javax/script/ProviderTest.java ! test/javax/script/RhinoExceptionTest.java ! test/javax/script/Test1.java ! test/javax/script/Test2.java ! test/javax/script/Test3.java ! test/javax/script/Test4.java ! test/javax/script/Test5.java ! test/javax/script/Test6.java ! test/javax/script/Test7.java ! test/javax/script/Test8.java ! test/javax/script/VersionTest.java ! test/sun/tools/jrunscript/common.sh ! test/sun/tools/jrunscript/jrunscript-DTest.sh ! test/sun/tools/jrunscript/jrunscript-argsTest.sh ! test/sun/tools/jrunscript/jrunscript-cpTest.sh ! test/sun/tools/jrunscript/jrunscript-eTest.sh ! test/sun/tools/jrunscript/jrunscript-fTest.sh ! test/sun/tools/jrunscript/jrunscriptTest.sh Changeset: a16f1d0cbff3 Author: tbell Date: 2008-10-04 22:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a16f1d0cbff3 Merge Changeset: 8e14a7bd6753 Author: tbell Date: 2008-10-04 22:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8e14a7bd6753 Merge ! src/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java From tim.bell at sun.com Mon Oct 6 05:08:51 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 06 Oct 2008 05:08:51 +0000 Subject: hg: jdk7/tl/langtools: 3 new changesets Message-ID: <20081006050859.0F35ADC19@hg.openjdk.java.net> Changeset: 24a47c3062fe Author: xdono Date: 2008-10-02 19:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/24a47c3062fe 6754988: Update copyright year Summary: Update for files that have been modified starting July 2008 Reviewed-by: ohair, tbell ! src/share/classes/com/sun/source/util/Trees.java ! src/share/classes/com/sun/tools/apt/mirror/AptEnv.java ! src/share/classes/com/sun/tools/apt/util/Bark.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstantsSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassDocCatalog.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassUseMapper.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DeprecatedAPIListBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFinder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Group.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ImplementedMethods.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/IndexBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MetaKeywords.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/javac/Server.java ! src/share/classes/com/sun/tools/javac/api/JavacScope.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/api/WrappingJavaFileManager.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/AttrContext.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Env.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/javac/model/FilteredMemberList.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/parser/DocCommentScanner.java ! src/share/classes/com/sun/tools/javac/parser/EndPosParser.java ! src/share/classes/com/sun/tools/javac/parser/Keywords.java ! src/share/classes/com/sun/tools/javac/parser/Token.java ! src/share/classes/com/sun/tools/javac/processing/JavacFiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacMessager.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java ! src/share/classes/com/sun/tools/javac/processing/ServiceProxy.java ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/util/ByteBuffer.java ! src/share/classes/com/sun/tools/javac/util/Context.java ! src/share/classes/com/sun/tools/javac/util/Convert.java ! src/share/classes/com/sun/tools/javac/util/ListBuffer.java ! src/share/classes/com/sun/tools/javac/util/Name.java ! src/share/classes/com/sun/tools/javac/util/Names.java ! src/share/classes/com/sun/tools/javac/util/SharedNameTable.java ! src/share/classes/com/sun/tools/javac/util/UnsharedNameTable.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/SeeTagImpl.java ! src/share/classes/com/sun/tools/javadoc/SerializedForm.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! src/share/classes/com/sun/tools/javah/Gen.java ! src/share/classes/javax/lang/model/type/ErrorType.java ! src/share/classes/javax/tools/StandardLocation.java ! test/tools/javac/5045412/Bar.java ! test/tools/javac/5045412/Foo.java ! test/tools/javac/6199662/Tree.java ! test/tools/javac/6627362/T6627362.java ! test/tools/javac/6627362/x/E.java ! test/tools/javac/6627362/x/Object.java ! test/tools/javac/api/6557752/T6557752.java ! test/tools/javac/foreach/T6500701.java ! test/tools/javac/synthesize/Boolean.java ! test/tools/javac/synthesize/Byte.java ! test/tools/javac/synthesize/Character.java ! test/tools/javac/synthesize/Cloneable.java ! test/tools/javac/synthesize/Integer.java ! test/tools/javac/synthesize/Long.java ! test/tools/javac/synthesize/Main.java ! test/tools/javac/synthesize/Number.java ! test/tools/javac/synthesize/Object.java ! test/tools/javac/synthesize/Serializable.java ! test/tools/javac/synthesize/Short.java ! test/tools/javac/synthesize/Test.java ! test/tools/javac/synthesize/Void.java ! test/tools/javac/unit/util/convert/EnclosingCandidates.java Changeset: 8e56394f54f5 Author: tbell Date: 2008-10-04 22:49 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8e56394f54f5 Merge Changeset: 539eb80f2a1a Author: tbell Date: 2008-10-04 22:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/539eb80f2a1a Merge From kumar.srinivasan at sun.com Mon Oct 6 15:08:22 2008 From: kumar.srinivasan at sun.com (kumar.srinivasan at sun.com) Date: Mon, 06 Oct 2008 15:08:22 +0000 Subject: hg: jdk7/tl/jdk: 6755847: (launcher) will trigger assertions in debug build Message-ID: <20081006150849.0429BDC3A@hg.openjdk.java.net> Changeset: e7f373751c6b Author: ksrini Date: 2008-10-05 18:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e7f373751c6b 6755847: (launcher) will trigger assertions in debug build Summary: Adds a temporary counter measure to to prevent assertions CR: 6755845 Reviewed-by: darcy, dholmes ! src/share/bin/java.h ! src/solaris/bin/java_md.c ! src/windows/bin/java_md.c From bradford.wetmore at sun.com Mon Oct 6 22:38:20 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Mon, 06 Oct 2008 22:38:20 +0000 Subject: hg: jdk7/tl/jdk: 10 new changesets Message-ID: <20081006224123.E0DB7DCB6@hg.openjdk.java.net> Changeset: c7fae5013939 Author: michaelm Date: 2008-09-19 13:32 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c7fae5013939 6750364: Error in test for 6744329 Reviewed-by: chegar ! test/com/sun/net/httpserver/bugs/B6744329.java Changeset: e57447118235 Author: michaelm Date: 2008-09-19 14:03 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e57447118235 Merge Changeset: c54ce70a3668 Author: chegar Date: 2008-09-19 15:14 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c54ce70a3668 6746836: java.net exception classes don't specify serialVersionUID Reviewed-by: alanb, jccollet ! make/sun/net/spi/Makefile ! make/sun/net/spi/nameservice/Makefile ! make/sun/net/spi/nameservice/dns/Makefile ! src/share/classes/java/net/BindException.java ! src/share/classes/java/net/ConnectException.java ! src/share/classes/java/net/HttpRetryException.java ! src/share/classes/java/net/MalformedURLException.java ! src/share/classes/java/net/NoRouteToHostException.java ! src/share/classes/java/net/PortUnreachableException.java ! src/share/classes/java/net/ProtocolException.java ! src/share/classes/java/net/SocketException.java ! src/share/classes/java/net/SocketTimeoutException.java ! src/share/classes/java/net/URISyntaxException.java ! src/share/classes/java/net/UnknownHostException.java ! src/share/classes/java/net/UnknownServiceException.java ! src/share/classes/sun/net/ConnectionResetException.java ! src/share/classes/sun/net/ProgressEvent.java ! src/share/classes/sun/net/TelnetProtocolException.java ! src/share/classes/sun/net/ftp/FtpLoginException.java ! src/share/classes/sun/net/ftp/FtpProtocolException.java ! src/share/classes/sun/net/httpserver/HttpError.java ! src/share/classes/sun/net/httpserver/StreamClosedException.java ! src/share/classes/sun/net/smtp/SmtpProtocolException.java ! src/share/classes/sun/net/www/ApplicationLaunchException.java ! src/share/classes/sun/net/www/http/KeepAliveStreamCleaner.java ! src/share/classes/sun/net/www/protocol/http/DigestAuthentication.java ! src/solaris/classes/sun/net/www/protocol/http/NTLMAuthentication.java Changeset: abf3e1aa8031 Author: michaelm Date: 2008-09-22 15:53 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/abf3e1aa8031 6739920: java 6u4~ use larger C heap if there are many threads Reviewed-by: chegar ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/solaris/native/java/net/PlainSocketImpl.c Changeset: 976c7eb88476 Author: michaelm Date: 2008-09-22 16:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/976c7eb88476 Merge Changeset: 74fc78477907 Author: mullan Date: 2008-09-22 10:43 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/74fc78477907 6469266: Integrate Apache XMLSec 1.4.2 into JDK 7 Reviewed-by: valeriep ! src/share/classes/com/sun/org/apache/xml/internal/security/Init.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/Algorithm.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/JCEMapper.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/MessageDigestAlgorithm.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/SignatureAlgorithm.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/SignatureAlgorithmSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/IntegrityHmac.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureBaseRSA.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureDSA.java + src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureECDSA.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/CanonicalizationException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/Canonicalizer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/InvalidCanonicalizerException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/helper/AttrCompare.java + src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer11.java + src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer11_OmitComments.java + src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer11_WithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315Excl.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315ExclWithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315WithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/CanonicalizerBase.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/NameSpaceSymbTable.java + src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/UtfHelpper.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipherInput.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/ContentHandlerAlreadyRegisteredException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/KeyInfo.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/KeyUtils.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/KeyInfoContent.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/KeyName.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/KeyValue.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/MgmtData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/PGPData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/RetrievalMethod.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/SPKIData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/X509Data.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/keyvalues/DSAKeyValue.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/keyvalues/KeyValueContent.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/keyvalues/RSAKeyValue.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509CRL.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509Certificate.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509DataContent.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509IssuerSerial.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509SKI.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509SubjectName.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/InvalidKeyResolverException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolverException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolverSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/DSAKeyValueResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/EncryptedKeyResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/RSAKeyValueResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/RetrievalMethodResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/X509CertificateResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/X509IssuerSerialResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/X509SKIResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/X509SubjectNameResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/StorageResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/StorageResolverException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/StorageResolverSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/CertsInFilesystemDirectoryResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/KeyStoreResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/SingleCertificateResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/config.dtd ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/config.xml ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/schema/etsi.xsd ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/schema/xmldsig-core-schema.dtd ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/schema/xmldsig-core-schema.xsd ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/xmlsecurity_en.properties ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/InvalidDigestValueException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/InvalidSignatureValueException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/Manifest.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/MissingResourceFailureException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/NodeFilter.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/ObjectContainer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/Reference.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/ReferenceNotInitializedException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/SignatureProperties.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/SignatureProperty.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/SignedInfo.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignature.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignatureException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignatureInput.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignatureInputDebugger.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/InvalidTransformException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/Transform.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/TransformParam.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/TransformSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/TransformationException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/Transforms.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformBase64Decode.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14N.java + src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14N11.java + src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14N11_WithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14NExclusive.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14NExclusiveWithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14NWithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformEnvelopedSignature.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXPath.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXPath2Filter.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXPointer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXSLT.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/XPath2FilterContainer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/XPath2FilterContainer04.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/XPathFilterCHGPContainer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/Base64.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/Constants.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/DigesterOutputStream.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementChecker.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementCheckerImpl.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementProxy.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionConstants.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionElementProxy.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/HelperNodeList.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/I18n.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/IdResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/JavaUtils.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/SignatureElementProxy.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/SignerOutputStream.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/UnsyncBufferedOutputStream.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/UnsyncByteArrayOutputStream.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/XMLUtils.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolverException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolverSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverAnonymous.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverDirectHTTP.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverFragment.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverLocalFilesystem.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverXPointer.java ! src/share/classes/org/jcp/xml/dsig/internal/DigesterOutputStream.java ! src/share/classes/org/jcp/xml/dsig/internal/MacOutputStream.java ! src/share/classes/org/jcp/xml/dsig/internal/SignerOutputStream.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheCanonicalizer.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheNodeSetData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheOctetStreamData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMBase64Transform.java + src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14N11Method.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14NMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalizationMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCryptoBinary.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMDigestMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMEnvelopedTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMExcC14NMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMHMACSignatureMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfo.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfoFactory.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyName.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyValue.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMManifest.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMPGPData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperties.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperty.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMStructure.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSubTreeData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMURIDereferencer.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMUtils.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509Data.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509IssuerSerial.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLObject.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignatureFactory.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXSLTTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/Utils.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/XMLDSigRI.java - src/share/classes/org/jcp/xml/dsig/internal/package.html ! test/javax/xml/crypto/dsig/GenerationTests.java Changeset: 81de7c8225c3 Author: mullan Date: 2008-09-22 11:26 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/81de7c8225c3 Merge - src/share/classes/org/jcp/xml/dsig/internal/package.html Changeset: de7864ec310c Author: chegar Date: 2008-09-24 17:10 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/de7864ec310c 6621697: Problem with file test/sun/net/www/http/ChunkedInputStream/test.txt Reviewed-by: michaelm ! test/sun/net/www/http/ChunkedInputStream/ChunkedEncodingTest.java - test/sun/net/www/http/ChunkedInputStream/test.txt Changeset: 8b0be0bc4b14 Author: chegar Date: 2008-09-26 11:24 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8b0be0bc4b14 6752807: java.net test ADatagramSocket.sh is broken Summary: update bootclasspath set by test to simply prepend TESTCLASSES Reviewed-by: michaelm ! test/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.sh Changeset: 2f38da01dcf4 Author: wetmore Date: 2008-10-06 09:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2f38da01dcf4 Merge ! make/sun/net/spi/nameservice/dns/Makefile - src/share/classes/org/jcp/xml/dsig/internal/package.html ! test/com/sun/net/httpserver/bugs/B6744329.java - test/sun/net/www/http/ChunkedInputStream/test.txt From jonathan.gibbons at sun.com Mon Oct 6 23:59:05 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Mon, 06 Oct 2008 23:59:05 +0000 Subject: hg: jdk7/tl/langtools: 6748546: javadoc API should be classloader-friendly Message-ID: <20081006235909.2DC3DDCFD@hg.openjdk.java.net> Changeset: 944790f83b57 Author: jjg Date: 2008-10-06 16:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/944790f83b57 6748546: javadoc API should be classloader-friendly Reviewed-by: bpatel ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/Main.java ! src/share/classes/com/sun/tools/javadoc/Start.java From jonathan.gibbons at sun.com Tue Oct 7 22:42:04 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 07 Oct 2008 22:42:04 +0000 Subject: hg: jdk7/tl/langtools: 6749967: regression tests for apt should be same-vm friendly Message-ID: <20081007224208.2AAC9DDD4@hg.openjdk.java.net> Changeset: a54ef8459576 Author: jjg Date: 2008-10-07 15:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a54ef8459576 6749967: regression tests for apt should be same-vm friendly Reviewed-by: darcy ! test/tools/apt/mirror/declaration/AnnoMirror.java ! test/tools/apt/mirror/declaration/AnnoTypeDecl.java ! test/tools/apt/mirror/declaration/AnnoTypeElemDecl.java ! test/tools/apt/mirror/declaration/AnnoVal.java ! test/tools/apt/mirror/declaration/ClassDecl.java ! test/tools/apt/mirror/declaration/ConstExpr.java ! test/tools/apt/mirror/declaration/ConstructorDecl.java ! test/tools/apt/mirror/declaration/EnumDecl.java ! test/tools/apt/mirror/declaration/FieldDecl.java ! test/tools/apt/mirror/declaration/GetAnno.java ! test/tools/apt/mirror/declaration/InterfaceDecl.java ! test/tools/apt/mirror/declaration/MethodDecl.java ! test/tools/apt/mirror/declaration/PackageDecl.java ! test/tools/apt/mirror/declaration/ParameterDecl.java ! test/tools/apt/mirror/type/AnnoTyp.java ! test/tools/apt/mirror/type/ArrayTyp.java ! test/tools/apt/mirror/type/ClassTyp.java ! test/tools/apt/mirror/type/EnumTyp.java ! test/tools/apt/mirror/type/InterfaceTyp.java ! test/tools/apt/mirror/type/PrimitiveTyp.java ! test/tools/apt/mirror/type/TypeVar.java ! test/tools/apt/mirror/type/WildcardTyp.java ! test/tools/apt/mirror/util/Overrides.java ! test/tools/apt/mirror/util/TypeCreation.java From eamonn.mcmanus at sun.com Wed Oct 8 16:41:19 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Wed, 08 Oct 2008 16:41:19 +0000 Subject: hg: jdk7/tl/jdk: 6757225: MXBean: Incorrect type names for parametrized types, dealing with arrays Message-ID: <20081008164149.AAE50DE16@hg.openjdk.java.net> Changeset: 86799e45c230 Author: emcmanus Date: 2008-10-08 18:38 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/86799e45c230 6757225: MXBean: Incorrect type names for parametrized types, dealing with arrays Reviewed-by: sjiang ! src/share/classes/com/sun/jmx/mbeanserver/MXBeanIntrospector.java ! src/share/classes/javax/management/event/EventClient.java ! src/share/classes/javax/management/event/FetchingEventRelay.java ! src/share/classes/javax/management/monitor/Monitor.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java + test/javax/management/mxbean/TypeNameTest.java From ole.ersoy at gmail.com Thu Oct 9 03:53:45 2008 From: ole.ersoy at gmail.com (Ole Ersoy) Date: Wed, 08 Oct 2008 22:53:45 -0500 Subject: Is com.sun.image.codec.jpeg.JPEGCodec Included in OpenJDK? Message-ID: <48ED8049.6080104@gmail.com> Hi, Hope this is the right list (If not please let me know). Anyone know if com.sun.image.codec.jpeg.JPEGCodec is included in OpenJDK? Thanks, - Ole From twisti at complang.tuwien.ac.at Thu Oct 9 06:41:16 2008 From: twisti at complang.tuwien.ac.at (Christian Thalinger) Date: Thu, 09 Oct 2008 08:41:16 +0200 Subject: Is com.sun.image.codec.jpeg.JPEGCodec Included in OpenJDK? In-Reply-To: <48ED8049.6080104@gmail.com> References: <48ED8049.6080104@gmail.com> Message-ID: <1223534476.21942.1.camel@workstation> On Wed, 2008-10-08 at 22:53 -0500, Ole Ersoy wrote: > Hi, > > Hope this is the right list (If not please let me know). Anyone know > if com.sun.image.codec.jpeg.JPEGCodec is included in OpenJDK? It seems it is not. But IcedTea has a replacement for it (a stub one I guess). - Christian From gnu_andrew at member.fsf.org Thu Oct 9 07:26:31 2008 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 9 Oct 2008 08:26:31 +0100 Subject: Is com.sun.image.codec.jpeg.JPEGCodec Included in OpenJDK? In-Reply-To: <48ED8049.6080104@gmail.com> References: <48ED8049.6080104@gmail.com> Message-ID: <17c6771e0810090026j6bc7988dt75426cebcd973e9@mail.gmail.com> 2008/10/9 Ole Ersoy : > Hi, > > Hope this is the right list (If not please let me know). Anyone know if > com.sun.image.codec.jpeg.JPEGCodec is included in OpenJDK? > Thanks, > - Ole > > It's been removed from 1.7 AFAIK. You should now be using the javax.imageio API introduced in 1.4. The com.sun API was never officially supported and means code won't run on other non-Sun JDKs (e.g. GNU Classpath, Apache Harmony). -- Andrew :-) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Alan.Bateman at Sun.COM Thu Oct 9 07:28:47 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Thu, 09 Oct 2008 08:28:47 +0100 Subject: Is com.sun.image.codec.jpeg.JPEGCodec Included in OpenJDK? In-Reply-To: <48ED8049.6080104@gmail.com> References: <48ED8049.6080104@gmail.com> Message-ID: <48EDB2AF.2010708@sun.com> Ole Ersoy wrote: > Hi, > > Hope this is the right list (If not please let me know). Anyone know > if com.sun.image.codec.jpeg.JPEGCodec is included in OpenJDK? > Thanks, > - Ole > The write-up in this bug may be useful: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6527962 The 2D mailing list (2d-dev at openjdk.java.net) is probably the best place to go for more information. -Alan. From mark at klomp.org Thu Oct 9 08:09:16 2008 From: mark at klomp.org (Mark Wielaard) Date: Thu, 09 Oct 2008 10:09:16 +0200 Subject: Is com.sun.image.codec.jpeg.JPEGCodec Included in OpenJDK? In-Reply-To: <1223534476.21942.1.camel@workstation> References: <48ED8049.6080104@gmail.com> <1223534476.21942.1.camel@workstation> Message-ID: <1223539756.3260.0.camel@dijkstra.wildebeest.org> Hi, On Thu, 2008-10-09 at 08:41 +0200, Christian Thalinger wrote: > On Wed, 2008-10-08 at 22:53 -0500, Ole Ersoy wrote: > > Hope this is the right list (If not please let me know). Anyone know > > if com.sun.image.codec.jpeg.JPEGCodec is included in OpenJDK? > > It seems it is not. But IcedTea has a replacement for it (a stub one I > guess). It is not complete. There has been some activity on the bug though: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=192 Cheers, Mark From daniel.fuchs at sun.com Thu Oct 9 12:14:10 2008 From: daniel.fuchs at sun.com (daniel.fuchs at sun.com) Date: Thu, 09 Oct 2008 12:14:10 +0000 Subject: hg: jdk7/tl/jdk: 6332953: JMX agent should bind to loopback address when starting the local connector server Message-ID: <20081009121453.06B7CDE56@hg.openjdk.java.net> Changeset: 6a76dcaf15e3 Author: dfuchs Date: 2008-10-09 14:10 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a76dcaf15e3 6332953: JMX agent should bind to loopback address when starting the local connector server Reviewed-by: emcmanus ! src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java + src/share/classes/sun/management/jmxremote/LocalRMIServerSocketFactory.java ! src/share/lib/management/management.properties From Phil.Race at Sun.COM Thu Oct 9 14:51:31 2008 From: Phil.Race at Sun.COM (Phil Race) Date: Thu, 09 Oct 2008 07:51:31 -0700 Subject: Is com.sun.image.codec.jpeg.JPEGCodec Included in OpenJDK? In-Reply-To: <48EDB2AF.2010708@sun.com> References: <48ED8049.6080104@gmail.com> <48EDB2AF.2010708@sun.com> Message-ID: <48EE1A73.506@sun.com> Alan is right that the 2D list is the right place for this. But that bug report is mainly about a migration plan for removing it from even the "closed" JDK, which then aligns better with openjdk. A principal reason this is not in openjdk is that the code is encumbered, and given that is not part of the platform spec, that it was always advertised as an interim solution, and was superseded a long time ago it was a waste of effort to even consider re-implementing it. -phil. Alan Bateman wrote: > Ole Ersoy wrote: >> Hi, >> >> Hope this is the right list (If not please let me know). Anyone know >> if com.sun.image.codec.jpeg.JPEGCodec is included in OpenJDK? Thanks, >> - Ole >> > The write-up in this bug may be useful: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6527962 > > The 2D mailing list (2d-dev at openjdk.java.net) is probably the best > place to go for more information. > > -Alan. > > > From ole.ersoy at gmail.com Thu Oct 9 14:56:26 2008 From: ole.ersoy at gmail.com (Ole Ersoy) Date: Thu, 09 Oct 2008 09:56:26 -0500 Subject: Is com.sun.image.codec.jpeg.JPEGCodec Included in OpenJDK? In-Reply-To: <48EDB2AF.2010708@sun.com> References: <48ED8049.6080104@gmail.com> <48EDB2AF.2010708@sun.com> Message-ID: <48EE1B9A.3080205@gmail.com> Alan, Andrew, Christian, Mark, Thanks for all the tips! I'll use javax.imageio.ImageIO instead. Thanks again, Ole From maurizio.cimadamore at sun.com Thu Oct 9 16:39:03 2008 From: maurizio.cimadamore at sun.com (maurizio.cimadamore at sun.com) Date: Thu, 09 Oct 2008 16:39:03 +0000 Subject: hg: jdk7/tl/langtools: 6 new changesets Message-ID: <20081009163914.51E9DDE7A@hg.openjdk.java.net> Changeset: c0372d1097c0 Author: mcimadamore Date: 2008-10-09 15:56 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c0372d1097c0 6751514: Unary post-increment with type variables crash javac during lowering Summary: Lower.abstractRval should take into account parenthesized expressions Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java + test/tools/javac/generics/T6751514.java Changeset: 8c098cf64ab5 Author: mcimadamore Date: 2008-10-09 16:02 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8c098cf64ab5 6738538: javac crashes when using a type parameter as a covariant method return type Summary: Capture conversion should be applied when acccessing a member of an intersection type Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/OverrideChecks/6738538/T6738538a.java + test/tools/javac/OverrideChecks/6738538/T6738538b.java Changeset: ac6ce899d007 Author: mcimadamore Date: 2008-10-09 16:04 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ac6ce899d007 6724345: incorrect method resolution for enum classes entered as source files Summary: Enum's abstract methods shouldn't be skipped during method resolution Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/enum/T6724345.java Changeset: 8eafba4f61be Author: mcimadamore Date: 2008-10-09 16:07 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8eafba4f61be 6406133: JCDiagnostic.getMessage ignores locale argument Summary: Compiler API should take into account locale settings Reviewed-by: jjg ! src/share/classes/com/sun/tools/apt/util/Bark.java ! src/share/classes/com/sun/tools/javac/api/Formattable.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java + src/share/classes/com/sun/tools/javac/api/Messages.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/parser/Token.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java + src/share/classes/com/sun/tools/javac/util/JavacMessages.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java ! test/tools/javac/6457284/T6457284.java + test/tools/javac/api/6406133/Erroneous.java + test/tools/javac/api/6406133/T6406133.java Changeset: e4eaddca54b7 Author: mcimadamore Date: 2008-10-09 16:19 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e4eaddca54b7 6731573: diagnostic output should optionally include source line Summary: Added an -XD option to optionally prints out source lines in error messages Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java + test/tools/javac/api/6731573/Erroneous.java + test/tools/javac/api/6731573/T6731573.java Changeset: d766e40e49d6 Author: mcimadamore Date: 2008-10-09 16:21 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d766e40e49d6 6586091: javac crashes with StackOverflowError Summary: Types.adapt should avoid infinite loops by exploiting a local cache Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/cast/6586091/T6586091.java From daniel.fuchs at sun.com Fri Oct 10 09:00:53 2008 From: daniel.fuchs at sun.com (daniel.fuchs at sun.com) Date: Fri, 10 Oct 2008 09:00:53 +0000 Subject: hg: jdk7/tl/jdk: 6758165: ConnectorBootstrap.DefaultValues should have a default value for USE_LOCAL_ONLY Message-ID: <20081010090124.71ABADF55@hg.openjdk.java.net> Changeset: f50f9b0d18a8 Author: dfuchs Date: 2008-10-10 10:58 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f50f9b0d18a8 6758165: ConnectorBootstrap.DefaultValues should have a default value for USE_LOCAL_ONLY Reviewed-by: alanb, emcmanus ! src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java From xueming.shen at sun.com Mon Oct 13 21:54:38 2008 From: xueming.shen at sun.com (xueming.shen at sun.com) Date: Mon, 13 Oct 2008 21:54:38 +0000 Subject: hg: jdk7/tl/jdk: 5025260: Register methods should throw ClosedChannelException instead of NPE Message-ID: <20081013215518.5DDDAD0CF@hg.openjdk.java.net> Changeset: 214ebdcf7252 Author: sherman Date: 2008-10-13 14:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/214ebdcf7252 5025260: Register methods should throw ClosedChannelException instead of NPE Summary: update the spec and implementation to throw ClosedSelectorException Reviewed-by: alanb ! src/share/classes/java/nio/channels/SelectableChannel.java ! src/share/classes/java/nio/channels/spi/AbstractSelectableChannel.java ! src/share/classes/sun/nio/ch/AbstractPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/DevPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/EPollSelectorImpl.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java + test/java/nio/channels/Selector/CloseThenRegister.java From maurizio.cimadamore at sun.com Tue Oct 14 16:06:45 2008 From: maurizio.cimadamore at sun.com (maurizio.cimadamore at sun.com) Date: Tue, 14 Oct 2008 16:06:45 +0000 Subject: hg: jdk7/tl/langtools: 6759143: com.sun.tools.javac.util.Messages is obsolete and should be removed Message-ID: <20081014160648.8856ED129@hg.openjdk.java.net> Changeset: e03459165ec4 Author: mcimadamore Date: 2008-10-14 17:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e03459165ec4 6759143: com.sun.tools.javac.util.Messages is obsolete and should be removed Summary: push for 6406133 should have removed com.sun.tools.javac.util.Messages Reviewed-by: jjg - src/share/classes/com/sun/tools/javac/util/Messages.java From jonathan.gibbons at sun.com Wed Oct 15 15:09:39 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 15 Oct 2008 15:09:39 +0000 Subject: hg: jdk7/tl/langtools: 6748541: javadoc should be reusable Message-ID: <20081015150943.05500D26F@hg.openjdk.java.net> Changeset: 22c4c1143a3a Author: jjg Date: 2008-10-15 08:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/22c4c1143a3a 6748541: javadoc should be reusable Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Group.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MetaKeywords.java ! test/com/sun/javadoc/AuthorDD/AuthorDD.java ! test/com/sun/javadoc/lib/JavadocTester.java ! test/tools/javadoc/BooleanConst.java ! test/tools/javadoc/BreakIteratorWarning.java ! test/tools/javadoc/FlagsTooEarly.java ! test/tools/javadoc/InlineTagsWithBraces.java ! test/tools/javadoc/LangVers.java ! test/tools/javadoc/MethodLinks.java ! test/tools/javadoc/NoStar.java ! test/tools/javadoc/T4994049/T4994049.java ! test/tools/javadoc/XWerror.java ! test/tools/javadoc/completionFailure/CompletionFailure.java ! test/tools/javadoc/dupOk/DupOk.java ! test/tools/javadoc/imports/MissingImport.java ! test/tools/javadoc/lib/Tester.java ! test/tools/javadoc/nestedClass/NestedClass.java ! test/tools/javadoc/sourceOnly/p/SourceOnly.java ! test/tools/javadoc/sourceOption/SourceOption.java ! test/tools/javadoc/subpackageIgnore/SubpackageIgnore.java From maurizio.cimadamore at sun.com Wed Oct 15 16:24:24 2008 From: maurizio.cimadamore at sun.com (maurizio.cimadamore at sun.com) Date: Wed, 15 Oct 2008 16:24:24 +0000 Subject: hg: jdk7/tl/langtools: 6759682: APT: compiler message file broken after refactoring of com.sun.tools.javac.util.Message Message-ID: <20081015162426.7A616D281@hg.openjdk.java.net> Changeset: 83ffdd1a6294 Author: mcimadamore Date: 2008-10-15 17:23 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/83ffdd1a6294 6759682: APT: compiler message file broken after refactoring of com.sun.tools.javac.util.Message Summary: JavacMessages should refresh its own bundle cache when a new resource bundle is added by APT Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/JavacMessages.java From jonathan.gibbons at sun.com Wed Oct 15 18:17:15 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 15 Oct 2008 18:17:15 +0000 Subject: hg: jdk7/tl/langtools: 6759795: test/tools/apt/Basic/print.sh may fail depending on jtreg options Message-ID: <20081015181719.2157AD28C@hg.openjdk.java.net> Changeset: e1332c04f6b6 Author: jjg Date: 2008-10-15 11:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e1332c04f6b6 6759795: test/tools/apt/Basic/print.sh may fail depending on jtreg options Reviewed-by: darcy ! test/tools/apt/Basics/print.sh From jonathan.gibbons at sun.com Wed Oct 15 20:23:35 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 15 Oct 2008 20:23:35 +0000 Subject: hg: jdk7/tl/langtools: 6759796: test/tools/javac/6348193/T6348193.java fails if there are empty entries on the bootclasspath Message-ID: <20081015202339.123DCD2BA@hg.openjdk.java.net> Changeset: 4feda9f0dbe7 Author: jjg Date: 2008-10-15 13:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4feda9f0dbe7 6759796: test/tools/javac/6348193/T6348193.java fails if there are empty entries on the bootclasspath Reviewed-by: darcy ! test/tools/javac/processing/6348193/T6348193.java From jonathan.gibbons at sun.com Thu Oct 16 14:33:10 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 16 Oct 2008 14:33:10 +0000 Subject: hg: jdk7/tl/langtools: 6759775: RegularFileObject.inferBinaryName gives bad result on empty path Message-ID: <20081016143314.07A82D38B@hg.openjdk.java.net> Changeset: 173162d6eb1d Author: jjg Date: 2008-10-16 07:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/173162d6eb1d 6759775: RegularFileObject.inferBinaryName gives bad result on empty path Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java From jonathan.gibbons at sun.com Thu Oct 16 14:42:04 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 16 Oct 2008 14:42:04 +0000 Subject: hg: jdk7/tl/langtools: 6759810: bad regression test causes source file to be deleted Message-ID: <20081016144208.1F823D390@hg.openjdk.java.net> Changeset: 2c1ef6ec9413 Author: jjg Date: 2008-10-16 07:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2c1ef6ec9413 6759810: bad regression test causes source file to be deleted Reviewed-by: mcimadamore ! test/tools/javac/links/T.java ! test/tools/javac/links/links.sh From maurizio.cimadamore at sun.com Thu Oct 16 17:08:48 2008 From: maurizio.cimadamore at sun.com (maurizio.cimadamore at sun.com) Date: Thu, 16 Oct 2008 17:08:48 +0000 Subject: hg: jdk7/tl/langtools: 6760226: test/tools/javap/T6622260.java fails with specific locale settings Message-ID: <20081016170852.CE426D395@hg.openjdk.java.net> Changeset: 6fcc8de719f5 Author: mcimadamore Date: 2008-10-16 18:07 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6fcc8de719f5 6760226: test/tools/javap/T6622260.java fails with specific locale settings Summary: Changed the regression test in order to make it more robust w.r.t. to locale settings Reviewed-by: jjg ! test/tools/javap/T6622260.java From jtulach at netbeans.org Thu Oct 16 17:38:23 2008 From: jtulach at netbeans.org (Jaroslav Tulach) Date: Thu, 16 Oct 2008 19:38:23 +0200 Subject: [PATCH] Enhance ServiceLoader to understand factory methods References: Message-ID: Hi. I can imagine, dear core-libs members, that you are all busy with your jobs, however at least give me hope: Can I get my patch into the OpenJDK in reasonable timeframe or not? Thanks in advance for your reply. -jst Jaroslav Tulach wrote: > Proposal: Enhance ServiceLoader to understand factory methods > > Justification: A lot of our services in NetBeans are final classes. Still, > we > would like to use the META-INF/services registration to register their > providers. Currently this does not work, we either need to unfinalize the > classes (which restricts future evolution options) or use different ways > of registering the providers. We propose simple and backward compatible > extension to current ServiceLoader registration scheme. If accepted, > NetBeans'll eliminate our non-standard registration methods, while keeping > benefits of final classes. Moreover the same techniques will be available > to any JavaSE project. > > Risks: API change includes simple, compatible extension. New code is able > to accept old registrations. Old code (JDK6) will generate > ServiceConfigurationError in case of seeing new registration, however. > > Test: I have found tests in test/java/util/ServiceLoader/ directory and > I've modified them to verify also our new usecase. All of them are > passing, if I run them by running ./basic.sh script - I am not sure if > that is the right way of running your tests. > > I am attaching my current patch. Let me know what shall I change to allow > this > to be integrated to OpenJDK7. Thanks a lot. > > Jaroslav Tulach > NetBeans Platform Architect From martinrb at google.com Thu Oct 16 19:46:05 2008 From: martinrb at google.com (Martin Buchholz) Date: Thu, 16 Oct 2008 12:46:05 -0700 Subject: SecurityException in AnnotationInvocationHandler.getMemberMethods Message-ID: <1ccfd1c10810161246l51643ddfi7d13e094ad11ccb4@mail.gmail.com> Hi all, This is a bug report with fix. Joe Darcy, please file a bug and review this change, and perhaps provide a small test case (it is impractical to share the test we have at Google). Description: sun/reflect/annotation/AnnotationInvocationHandler.java.getMemberMethods might throw if there is a security manager that does not allow getDeclaredMethods. The author of this code (Josh Bloch) confirms that the intent was for the doPrivileged block in this method to prevent security exceptions. The methods cannot escape to untrusted code. Evaluation: Yes. Fix provided courtesy of Toby Reyelts and Josh Bloch at Google. # HG changeset patch # User martin # Date 1224185752 25200 # Node ID 68730f05449cd4f39ce1cb82adc6c4e57f87554f # Parent 214ebdcf7252d4862449fe0ae295e6c60a127315 SecurityException in AnnotationInvocationHandler.getMemberMethods Summary: Move call to getDeclaredMethods inside doPrivileged Reviewed-by: Contributed-by: jjb at google.com diff --git a/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java b/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java --- a/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java +++ b/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java @@ -272,14 +272,14 @@ */ private Method[] getMemberMethods() { if (memberMethods == null) { - final Method[] mm = type.getDeclaredMethods(); - AccessController.doPrivileged(new PrivilegedAction() { - public Void run() { - AccessibleObject.setAccessible(mm, true); - return null; - } - }); - memberMethods = mm; + memberMethods = AccessController.doPrivileged( + new PrivilegedAction() { + public Method[] run() { + final Method[] mm = type.getDeclaredMethods(); + AccessibleObject.setAccessible(mm, true); + return mm; + } + }); } return memberMethods; } From David.Holmes at Sun.COM Thu Oct 16 19:56:13 2008 From: David.Holmes at Sun.COM (David Holmes - Sun Microsystems) Date: Fri, 17 Oct 2008 05:56:13 +1000 Subject: [PATCH] Enhance ServiceLoader to understand factory methods In-Reply-To: References: Message-ID: <48F79C5D.6020802@sun.com> Hi Jaroslav, If this is a modification to the API not just a patch for the implementation then the short answer is No. API changes have to be made via a JSR. David Holmes On 17/10/08 03:38 AM, Jaroslav Tulach wrote: > Hi. > I can imagine, dear core-libs members, that you are all busy with your jobs, > however at least give me hope: Can I get my patch into the OpenJDK in > reasonable timeframe or not? > > Thanks in advance for your reply. > -jst > > > Jaroslav Tulach wrote: >> Proposal: Enhance ServiceLoader to understand factory methods >> >> Justification: A lot of our services in NetBeans are final classes. Still, >> we >> would like to use the META-INF/services registration to register their >> providers. Currently this does not work, we either need to unfinalize the >> classes (which restricts future evolution options) or use different ways >> of registering the providers. We propose simple and backward compatible >> extension to current ServiceLoader registration scheme. If accepted, >> NetBeans'll eliminate our non-standard registration methods, while keeping >> benefits of final classes. Moreover the same techniques will be available >> to any JavaSE project. >> >> Risks: API change includes simple, compatible extension. New code is able >> to accept old registrations. Old code (JDK6) will generate >> ServiceConfigurationError in case of seeing new registration, however. >> >> Test: I have found tests in test/java/util/ServiceLoader/ directory and >> I've modified them to verify also our new usecase. All of them are >> passing, if I run them by running ./basic.sh script - I am not sure if >> that is the right way of running your tests. >> >> I am attaching my current patch. Let me know what shall I change to allow >> this >> to be integrated to OpenJDK7. Thanks a lot. >> >> Jaroslav Tulach >> NetBeans Platform Architect > > From Bradford.Wetmore at Sun.COM Thu Oct 16 22:15:08 2008 From: Bradford.Wetmore at Sun.COM (Brad Wetmore) Date: Thu, 16 Oct 2008 15:15:08 -0700 Subject: JSN Gate is being EOL'd. Message-ID: <48F7BCEC.9020706@sun.com> As you may know, I have been the gatekeeper for the JSN (Java Security & Networking) gate for the last 4 or so years. As many of JSN and TL (Tools & Libraries) changes are interrelated, we have been combining/testing/integrating the JSN & TL changes together into the MASTER workspaces. JSN has been a "subgate" of TL for several years. I have been asked to lead a new OpenJDK infrastructure project. In order to reduce my workload, we have decided that the JSN gate will be End-Of-Life'd following next week's integration into TL on 20 Oct 2008. All developers working in the JSN gate will immediately transition to the TL gate under gatekeeper Tim Bell. I will resync the JSN workspaces one last time on Monday, but after that, all pulls/pushes should be done to TL. http://hg.openjdk.java.net/jdk7/tl I hope to make the JSN gate READ-ONLY at that point, not sure if I can do that yet. It's with mixed feelings, I've been doing this for quite a while and have it down to an art. Brad From jonathan.gibbons at sun.com Thu Oct 16 23:56:10 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 16 Oct 2008 23:56:10 +0000 Subject: hg: jdk7/tl/langtools: 6760500: test com/sun/javadoc/testSupplementary/TestSupplementary.java is not same-VM safe Message-ID: <20081016235614.321A6D4A6@hg.openjdk.java.net> Changeset: 402183e8d6e1 Author: jjg Date: 2008-10-16 16:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/402183e8d6e1 6760500: test com/sun/javadoc/testSupplementary/TestSupplementary.java is not same-VM safe Reviewed-by: darcy ! test/com/sun/javadoc/testSupplementary/TestSupplementary.java From mr at sun.com Fri Oct 17 04:24:13 2008 From: mr at sun.com (Mark Reinhold) Date: Thu, 16 Oct 2008 21:24:13 -0700 Subject: [PATCH] Enhance ServiceLoader to understand factory methods In-Reply-To: david.holmes@sun.com; Fri, 17 Oct 2008 05:56:13 +1000; <48F79C5D.6020802@sun.com> Message-ID: <20081017042413.F176D2C39D@callebaut.niobe.net> > Date: Fri, 17 Oct 2008 05:56:13 +1000 > From: david.holmes at sun.com > If this is a modification to the API not just a patch for the > implementation then the short answer is No. Well, not exactly. > API changes have to be made > via a JSR. ... or in a Maintenance Review of an existing JSR. Small API revisions and additions do not require their own JSR; that would be ridiculously inefficient. Instead we roll them up into a series of Maintenance Reviews of the previous Platform JSR [1]. There have already been many small API changes in the JDK 7 codebase. Suggested patches for further such changes are welcome, and will be discussed and judged on their own technical merit. All implemented changes will, in due course, be aggregated into an appropriate JCP Maintenance Review. With regard to this particular proposal, as the original author of the class in question I suppose I should have an opinion about it, but that's a topic for a different message. - Mark [1] http://weblogs.java.net/blog/mreinhold/archive/2006/03/mustang_mainten.html From jaroslav.tulach at sun.com Fri Oct 17 12:28:36 2008 From: jaroslav.tulach at sun.com (Jaroslav Tulach) Date: Fri, 17 Oct 2008 14:28:36 +0200 Subject: Maintenance Reviews was: [PATCH] Enhance ServiceLoader to understand factory methods References: <48F79C5D.6020802@sun.com> <20081017042413.F176D2C39D@callebaut.niobe.net> Message-ID: Thanks for the clarification, Mark. I've heard about some umbrella JSR for each release of the JDK before and I was hoping that my proposed change could be covered as part of it. Thanks for confirming that such aggregation is possible. > With regard to this particular proposal, as the original author of ... OK, I can promise that I will work hard on polishing my proposal. I can improve the code, I can add more documentation, I can write more tests, change the new API semantics, etc. I just need a sponsor to tell me what to change and where and then take and apply my final patch. Thanks in advance for your help. -jst Dne Friday 17 October 2008 06:24:13 Mark Reinhold napsal(a): > > Date: Fri, 17 Oct 2008 05:56:13 +1000 > > From: david.holmes at sun.com > > > > If this is a modification to the API not just a patch for the > > implementation then the short answer is No. > > Well, not exactly. > > >????????????????????????????????????? ? ? ?API changes have to be made > > via a JSR. > > ... or in a Maintenance Review of an existing JSR. > > Small API revisions and additions do not require their own JSR; that > would be ridiculously inefficient. ?Instead we roll them up into a > series of Maintenance Reviews of the previous Platform JSR [1]. > > There have already been many small API changes in the JDK 7 codebase. > Suggested patches for further such changes are welcome, and will be > discussed and judged on their own technical merit. ?All implemented > changes will, in due course, be aggregated into an appropriate JCP > Maintenance Review. > > With regard to this particular proposal, as the original author of > the class in question I suppose I should have an opinion about it, > but that's a topic for a different message. > > - Mark > > > [1] > http://weblogs.java.net/blog/mreinhold/archive/2006/03/mustang_mainten.html From jonathan.gibbons at sun.com Fri Oct 17 17:36:37 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Fri, 17 Oct 2008 17:36:37 +0000 Subject: hg: jdk7/tl/langtools: 6760805: empty element on bootclasspath breaks test/tools/apt/Compile/compile.sh Message-ID: <20081017173640.CFB0BD4C5@hg.openjdk.java.net> Changeset: eca4bf37b66e Author: jjg Date: 2008-10-17 10:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/eca4bf37b66e 6760805: empty element on bootclasspath breaks test/tools/apt/Compile/compile.sh Reviewed-by: darcy ! test/tools/apt/Compile/compile.sh From i30817 at gmail.com Fri Oct 17 19:49:11 2008 From: i30817 at gmail.com (Paulo Levi) Date: Fri, 17 Oct 2008 20:49:11 +0100 Subject: Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin) Message-ID: <212322090810171249u5d7cd272gb51e0ce545802be9@mail.gmail.com> Get chars could be always implemented by a method already existing on the interface (getChar(int i)) but more efficently. Moreover this is the only missing piece to create read-only api's that work on all kinds of charsequences, be it swing.text Content, String, Stringbuffer, StringBuilder, CharBuffer etc. I just can't understand why this did not happen. From i30817 at gmail.com Fri Oct 17 19:58:41 2008 From: i30817 at gmail.com (Paulo Levi) Date: Fri, 17 Oct 2008 20:58:41 +0100 Subject: Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin) In-Reply-To: <212322090810171249u5d7cd272gb51e0ce545802be9@mail.gmail.com> References: <212322090810171249u5d7cd272gb51e0ce545802be9@mail.gmail.com> Message-ID: <212322090810171258y2c50bda0o1c26f56650b90d1b@mail.gmail.com> Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin) should be Why does CharSequence not have CharSequence getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin) With appropriate covariant returns down the inheritance tree. From martinrb at google.com Fri Oct 17 20:08:11 2008 From: martinrb at google.com (Martin Buchholz) Date: Fri, 17 Oct 2008 13:08:11 -0700 Subject: Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin) In-Reply-To: <212322090810171258y2c50bda0o1c26f56650b90d1b@mail.gmail.com> References: <212322090810171249u5d7cd272gb51e0ce545802be9@mail.gmail.com> <212322090810171258y2c50bda0o1c26f56650b90d1b@mail.gmail.com> Message-ID: <1ccfd1c10810171308l3852223ci692e9dcddcc613ca@mail.gmail.com> Paulo, I think you're right, that bulk char reading operations should have been part of this interface. But it's too late now; interfaces can never be changed. Hotspot does not do such a bad job optimizing calls through interfaces. Do we know what the penalty is? (usual micro-benchmark warnings apply) Martin On Fri, Oct 17, 2008 at 12:58, Paulo Levi wrote: > Why does CharSequence not have String getChars(int srcBegin, int > srcEnd, char[] dst, int dstBegin) > should be > Why does CharSequence not have CharSequence getChars(int srcBegin, int > srcEnd, char[] dst, int dstBegin) > > With appropriate covariant returns down the inheritance tree. > From i30817 at gmail.com Fri Oct 17 20:26:44 2008 From: i30817 at gmail.com (Paulo Levi) Date: Fri, 17 Oct 2008 21:26:44 +0100 Subject: Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin) In-Reply-To: <1ccfd1c10810171308l3852223ci692e9dcddcc613ca@mail.gmail.com> References: <212322090810171249u5d7cd272gb51e0ce545802be9@mail.gmail.com> <212322090810171258y2c50bda0o1c26f56650b90d1b@mail.gmail.com> <1ccfd1c10810171308l3852223ci692e9dcddcc613ca@mail.gmail.com> Message-ID: <212322090810171326n7f2d689eh660f23868b3cad88@mail.gmail.com> Can't be changed? No user of the api is currently using getChars on a Charsequence (because it doesn't exist!) If you're talking about other implementers of Charsequence than the jdk, well, i don't see why do we have to suffer ignominious interface incompleteness just because someone doesn't want to compile the code ever again. And couldn't it be made to work anyway? From cairndubh at gmail.com Fri Oct 17 21:54:02 2008 From: cairndubh at gmail.com (Brian Duff) Date: Fri, 17 Oct 2008 14:54:02 -0700 Subject: Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin) In-Reply-To: <212322090810171326n7f2d689eh660f23868b3cad88@mail.gmail.com> References: <212322090810171249u5d7cd272gb51e0ce545802be9@mail.gmail.com> <212322090810171258y2c50bda0o1c26f56650b90d1b@mail.gmail.com> <1ccfd1c10810171308l3852223ci692e9dcddcc613ca@mail.gmail.com> <212322090810171326n7f2d689eh660f23868b3cad88@mail.gmail.com> Message-ID: <70E31E93-BB61-4A79-BC07-9903445C08A3@gmail.com> This doesn't just introduce a source incompatibility (requiring code to be recompiled), it also introduces a binary incompatibility. If any object receives a CharSequence instance that happened to have been compiled against an older version of the platform, it will have no way of knowing that this method does not exist on the object. Java hasn't (to my knowledge) ever broken compatibility with an interface in the platform API before. I consider that a great strength of the platform. Brian On Oct 17, 2008, at 13:26, "Paulo Levi" wrote: > Can't be changed? No user of the api is currently using getChars on a > Charsequence (because it doesn't exist!) > > If you're talking about other implementers of Charsequence than the > jdk, well, i don't see why do we have to suffer ignominious interface > incompleteness just because someone doesn't want to compile the code > ever again. > > And couldn't it be made to work anyway? From david.lloyd at redhat.com Fri Oct 17 22:20:39 2008 From: david.lloyd at redhat.com (David M. Lloyd) Date: Fri, 17 Oct 2008 17:20:39 -0500 Subject: Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin) In-Reply-To: <70E31E93-BB61-4A79-BC07-9903445C08A3@gmail.com> References: <212322090810171249u5d7cd272gb51e0ce545802be9@mail.gmail.com> <212322090810171258y2c50bda0o1c26f56650b90d1b@mail.gmail.com> <1ccfd1c10810171308l3852223ci692e9dcddcc613ca@mail.gmail.com> <212322090810171326n7f2d689eh660f23868b3cad88@mail.gmail.com> <70E31E93-BB61-4A79-BC07-9903445C08A3@gmail.com> Message-ID: <48F90FB7.4000608@redhat.com> One could always go the awt route: public interface CharSequence2 extends CharSequence { ...new methods here... } then change things to implement CharSequence2 instead, using covariance as appropriate (thus at least somewhat avoiding the casting problem). At least then the program would fail early :-) - DML On 10/17/2008 04:54 PM, Brian Duff wrote: > This doesn't just introduce a source incompatibility (requiring code to > be recompiled), it also introduces a binary incompatibility. If any > object receives a CharSequence instance that happened to have been > compiled against an older version of the platform, it will have no way > of knowing that this method does not exist on the object. > > Java hasn't (to my knowledge) ever broken compatibility with an > interface in the platform API before. I consider that a great strength > of the platform. > > Brian > > On Oct 17, 2008, at 13:26, "Paulo Levi" wrote: > >> Can't be changed? No user of the api is currently using getChars on a >> Charsequence (because it doesn't exist!) >> >> If you're talking about other implementers of Charsequence than the >> jdk, well, i don't see why do we have to suffer ignominious interface >> incompleteness just because someone doesn't want to compile the code >> ever again. >> >> And couldn't it be made to work anyway? From jonathan.gibbons at sun.com Fri Oct 17 23:08:09 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Fri, 17 Oct 2008 23:08:09 +0000 Subject: hg: jdk7/tl/langtools: 6760930: empty element on bootclasspath breaks test/tools/apt/Discovery/discovery.sh Message-ID: <20081017230812.8C60FD51E@hg.openjdk.java.net> Changeset: 2eec479619d8 Author: jjg Date: 2008-10-17 16:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2eec479619d8 6760930: empty element on bootclasspath breaks test/tools/apt/Discovery/discovery.sh Reviewed-by: darcy ! test/tools/apt/Discovery/discovery.sh From tim.bell at sun.com Sun Oct 19 02:21:46 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 19 Oct 2008 02:21:46 +0000 Subject: hg: jdk7/tl: Added tag jdk7-b37 for changeset 744554f5a329 Message-ID: <20081019022146.DBA57D5E3@hg.openjdk.java.net> Changeset: cc47a76899ed Author: xdono Date: 2008-10-09 11:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/cc47a76899ed Added tag jdk7-b37 for changeset 744554f5a329 ! .hgtags From tim.bell at sun.com Sun Oct 19 02:23:19 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 19 Oct 2008 02:23:19 +0000 Subject: hg: jdk7/tl/corba: Added tag jdk7-b37 for changeset 59d5848bdede Message-ID: <20081019022321.8407CD5E8@hg.openjdk.java.net> Changeset: e1db87477f0c Author: xdono Date: 2008-10-09 11:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/e1db87477f0c Added tag jdk7-b37 for changeset 59d5848bdede ! .hgtags From tim.bell at sun.com Sun Oct 19 02:25:19 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 19 Oct 2008 02:25:19 +0000 Subject: hg: jdk7/tl/hotspot: Added tag jdk7-b37 for changeset 9ee9cf798b59 Message-ID: <20081019022525.3BC70D5ED@hg.openjdk.java.net> Changeset: d9bc824aa078 Author: xdono Date: 2008-10-09 11:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d9bc824aa078 Added tag jdk7-b37 for changeset 9ee9cf798b59 ! .hgtags From tim.bell at sun.com Sun Oct 19 02:28:11 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 19 Oct 2008 02:28:11 +0000 Subject: hg: jdk7/tl/jaxp: Added tag jdk7-b37 for changeset af49591bc486 Message-ID: <20081019022814.32464D5F3@hg.openjdk.java.net> Changeset: e9f750f0a3a0 Author: xdono Date: 2008-10-09 11:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/e9f750f0a3a0 Added tag jdk7-b37 for changeset af49591bc486 ! .hgtags From tim.bell at sun.com Sun Oct 19 02:29:36 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 19 Oct 2008 02:29:36 +0000 Subject: hg: jdk7/tl/jaxws: Added tag jdk7-b37 for changeset a2a6f9edf761 Message-ID: <20081019022939.545FBD5FC@hg.openjdk.java.net> Changeset: 9ce439969184 Author: xdono Date: 2008-10-09 11:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/9ce439969184 Added tag jdk7-b37 for changeset a2a6f9edf761 ! .hgtags From tim.bell at sun.com Sun Oct 19 02:33:01 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 19 Oct 2008 02:33:01 +0000 Subject: hg: jdk7/tl/jdk: 53 new changesets Message-ID: <20081019024701.A558CD605@hg.openjdk.java.net> Changeset: db2e128d9f68 Author: xdono Date: 2008-10-09 11:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db2e128d9f68 Added tag jdk7-b37 for changeset 14f50aee4989 ! .hgtags Changeset: bd208584e8af Author: tbell Date: 2008-10-10 13:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bd208584e8af Merge Changeset: cfbc79081769 Author: ksrini Date: 2008-10-14 13:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cfbc79081769 6758881: (launcher) needs to throw NoClassDefFoundError instead of JavaRuntimeException Summary: The launcher will throw the Error vs. Exception, also fixed some minor issues with the tests. Reviewed-by: darcy ! src/share/classes/sun/launcher/LauncherHelper.java ! test/tools/launcher/Arrrghs.java Changeset: fa7147a26cd2 Author: malenkov Date: 2008-06-19 18:03 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa7147a26cd2 4114658: DOC: Unspecified behaviour for java.beans.PropertyEditorSupport Reviewed-by: peterz, loneid ! src/share/classes/java/beans/PropertyEditor.java ! src/share/classes/java/beans/PropertyEditorSupport.java Changeset: fc09152d5cf6 Author: idk Date: 2008-06-23 15:21 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fc09152d5cf6 6623943: javax.swing.TimerQueue's thread occasionally fails to start Reviewed-by: alexp ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/javax/swing/TimerQueue.java Changeset: 282c86389114 Author: malenkov Date: 2008-06-26 15:11 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/282c86389114 6718964: Swing border tests should be open source Reviewed-by: peterz + test/javax/swing/border/Test4120351.java + test/javax/swing/border/Test4124729.java + test/javax/swing/border/Test4243289.html + test/javax/swing/border/Test4243289.java + test/javax/swing/border/Test4247606.html + test/javax/swing/border/Test4247606.java + test/javax/swing/border/Test4252164.html + test/javax/swing/border/Test4252164.java + test/javax/swing/border/Test6461042.java Changeset: 581440ba714a Author: malenkov Date: 2008-06-26 15:39 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/581440ba714a 6718965: Swing color chooser tests should be open source Reviewed-by: peterz + test/javax/swing/JColorChooser/Test4165217.java + test/javax/swing/JColorChooser/Test4177735.java + test/javax/swing/JColorChooser/Test4193384.java + test/javax/swing/JColorChooser/Test4234761.java + test/javax/swing/JColorChooser/Test4380468.html + test/javax/swing/JColorChooser/Test4380468.java + test/javax/swing/JColorChooser/Test4461329.java + test/javax/swing/JColorChooser/Test4711996.java + test/javax/swing/JColorChooser/Test4759306.html + test/javax/swing/JColorChooser/Test4759306.java + test/javax/swing/JColorChooser/Test4759934.html + test/javax/swing/JColorChooser/Test4759934.java + test/javax/swing/JColorChooser/Test4887836.html + test/javax/swing/JColorChooser/Test4887836.java Changeset: 13586ebcd761 Author: mlapshin Date: 2008-07-02 18:17 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/13586ebcd761 6618401: Input method cannot be selected from System menu Summary: lock.wait() added in sun.awt.im.InputMethodManager.showInputMethodMenuOnRequesterEDT() Reviewed-by: alexp ! src/share/classes/sun/awt/im/InputMethodManager.java Changeset: 99ea868a1d31 Author: mlapshin Date: 2008-07-07 16:56 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/99ea868a1d31 6647340: Minimized JInternalFrame icons appear in incorrect positions if the main frame is resized Summary: Now BasicInternalFrameUI and BasicDesktopIconUI both recalculate frame icon position Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/basic/BasicDesktopIconUI.java ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameUI.java + src/share/classes/javax/swing/plaf/basic/DesktopIconMover.java + test/javax/swing/JInternalFrame/6647340/bug6647340.java Changeset: 34b312e8344b Author: peterz Date: 2008-07-08 11:36 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/34b312e8344b 6635663: make/tools/AutoMulti/{AutoMulti,TestALFGenerator}.java still generate files with wrong legal notices Summary: Removed unused files Reviewed-by: ohair ! make/tools/Makefile - make/tools/auto_multi/Makefile - make/tools/src/build/tools/automulti/AutoMulti.java - make/tools/src/build/tools/automulti/README.txt - make/tools/src/build/tools/automulti/TestALFGenerator.java - make/tools/src/build/tools/automulti/TestALFLookAndFeel.java Changeset: d5e658be14f7 Author: malenkov Date: 2008-07-08 16:40 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d5e658be14f7 4916852: RFE: LTP: BorderLayout Persistence Delegate should use 1.5 API Reviewed-by: peterz, loneid ! src/share/classes/java/beans/MetaData.java + test/java/beans/XMLEncoder/java_awt_BorderLayout.java + test/java/beans/XMLEncoder/java_awt_Component.java Changeset: f98824b5fe08 Author: malenkov Date: 2008-07-09 15:25 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f98824b5fe08 6351692: catch(Throwable) in java.beans.MetaData preventing thread shutdown Reviewed-by: peterz, loneid ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/EventHandler.java Changeset: ccdfb79c9864 Author: malenkov Date: 2008-07-09 19:29 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ccdfb79c9864 4994637: LTP: java.beans.java_util_Map_PersistenceDelegate: ConcurrentModificationException Reviewed-by: peterz, loneid ! src/share/classes/java/beans/MetaData.java + test/java/beans/XMLEncoder/Test4994637.java ! test/java/beans/XMLEncoder/java_util_HashMap.java Changeset: f7585c3756ee Author: malenkov Date: 2008-07-18 18:26 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f7585c3756ee 6552812: Add HSL tab to JColorChooser Reviewed-by: peterz, avu ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties ! src/share/classes/javax/swing/colorchooser/ColorChooserComponentFactory.java + src/share/classes/javax/swing/colorchooser/ColorChooserPanel.java + src/share/classes/javax/swing/colorchooser/ColorModel.java + src/share/classes/javax/swing/colorchooser/ColorModelCMYK.java + src/share/classes/javax/swing/colorchooser/ColorModelHSL.java + src/share/classes/javax/swing/colorchooser/ColorModelHSV.java + src/share/classes/javax/swing/colorchooser/ColorPanel.java - src/share/classes/javax/swing/colorchooser/DefaultHSBChooserPanel.java - src/share/classes/javax/swing/colorchooser/DefaultRGBChooserPanel.java + src/share/classes/javax/swing/colorchooser/DiagramComponent.java + src/share/classes/javax/swing/colorchooser/SlidingSpinner.java - src/share/classes/javax/swing/colorchooser/SyntheticImage.java + src/share/classes/javax/swing/colorchooser/ValueFormatter.java ! src/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java ! test/javax/swing/JColorChooser/Test6524757.java + test/javax/swing/JColorChooser/Test6559154.java Changeset: fdbc0517be43 Author: idk Date: 2008-07-21 10:21 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fdbc0517be43 6668281: NullPointerException in DefaultTableCellHeaderRenderer.getColumnSortOrder() Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTableHeaderUI.java Changeset: 8b59beb64ee9 Author: mlapshin Date: 2008-07-21 19:58 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8b59beb64ee9 6607130: REGRESSION: JComboBox cell editor isn't hidden if the same value is selected with keyboard Summary: JComboBox cell editor now hides if the same value is selected with keyboard Reviewed-by: peterz, alexp ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java + test/javax/swing/JComboBox/6607130/bug6607130.java Changeset: e4d87f3c8858 Author: mlapshin Date: 2008-07-24 14:34 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e4d87f3c8858 6725409: Unable to localize JInternalFrame system menu during run-time Summary: Use of the static final constants replaced by direct calls of UIManager.getString(). Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameTitlePane.java + test/javax/swing/JInternalFrame/6725409/bug6725409.java Changeset: ef591cd4c463 Author: malenkov Date: 2008-07-24 14:51 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ef591cd4c463 4778988: CompoundBorder.isBorderOpaque() has incorrect documentation. Reviewed-by: peterz, rupashka ! src/share/classes/javax/swing/border/CompoundBorder.java Changeset: b334982cdefe Author: rupashka Date: 2008-07-24 16:43 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b334982cdefe 6722802: Code improvement and warnings removing from the javax.swing.text package Summary: Removed unnecessary castings and other warnings Reviewed-by: peterz Contributed-by: Florian Brunner ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/AsyncBoxView.java ! src/share/classes/javax/swing/text/ComponentView.java ! src/share/classes/javax/swing/text/DefaultCaret.java ! src/share/classes/javax/swing/text/DefaultFormatter.java ! src/share/classes/javax/swing/text/DefaultHighlighter.java ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/ElementIterator.java ! src/share/classes/javax/swing/text/FlowView.java ! src/share/classes/javax/swing/text/GapContent.java ! src/share/classes/javax/swing/text/InternationalFormatter.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/LayoutQueue.java ! src/share/classes/javax/swing/text/MaskFormatter.java ! src/share/classes/javax/swing/text/NumberFormatter.java ! src/share/classes/javax/swing/text/PlainDocument.java ! src/share/classes/javax/swing/text/SegmentCache.java ! src/share/classes/javax/swing/text/SimpleAttributeSet.java ! src/share/classes/javax/swing/text/StringContent.java ! src/share/classes/javax/swing/text/StyleContext.java ! src/share/classes/javax/swing/text/TableView.java ! src/share/classes/javax/swing/text/TextAction.java ! src/share/classes/javax/swing/text/TextLayoutStrategy.java ! src/share/classes/javax/swing/text/ZoneView.java ! src/share/classes/javax/swing/text/html/AccessibleHTML.java ! src/share/classes/javax/swing/text/html/CSS.java ! src/share/classes/javax/swing/text/html/HTML.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/share/classes/javax/swing/text/html/HTMLWriter.java ! src/share/classes/javax/swing/text/html/Map.java ! src/share/classes/javax/swing/text/html/MinimalHTMLWriter.java ! src/share/classes/javax/swing/text/html/OptionListModel.java ! src/share/classes/javax/swing/text/html/StyleSheet.java ! src/share/classes/javax/swing/text/html/TableView.java ! src/share/classes/javax/swing/text/html/parser/AttributeList.java ! src/share/classes/javax/swing/text/html/parser/DTD.java ! src/share/classes/javax/swing/text/html/parser/Element.java ! src/share/classes/javax/swing/text/html/parser/Entity.java ! src/share/classes/javax/swing/text/html/parser/Parser.java ! src/share/classes/javax/swing/text/html/parser/TagStack.java ! src/share/classes/javax/swing/text/rtf/MockAttributeSet.java ! src/share/classes/javax/swing/text/rtf/RTFAttributes.java ! src/share/classes/javax/swing/text/rtf/RTFGenerator.java ! src/share/classes/javax/swing/text/rtf/RTFParser.java ! src/share/classes/javax/swing/text/rtf/RTFReader.java Changeset: 91722ce41508 Author: malenkov Date: 2008-07-24 17:30 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/91722ce41508 6707406: BasicColorChooserUI tests throw NPE while getColorSelectionModel if isPropertyChanged() returns true Reviewed-by: peterz, rupashka ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKColorChooserPanel.java ! src/share/classes/javax/swing/colorchooser/AbstractColorChooserPanel.java ! src/share/classes/javax/swing/colorchooser/ColorChooserPanel.java ! src/share/classes/javax/swing/colorchooser/ColorPanel.java ! src/share/classes/javax/swing/colorchooser/DefaultSwatchChooserPanel.java + test/javax/swing/JColorChooser/Test6707406.java Changeset: a2266940ae33 Author: mlapshin Date: 2008-07-25 14:14 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a2266940ae33 6727829: BasicLabelUI rendering fails if multiple AppContexts exist in same java JVM Summary: Several private static variables made local Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicLabelUI.java Changeset: 85f6a6d7d812 Author: rupashka Date: 2008-07-25 17:50 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/85f6a6d7d812 6727661: Code improvement and warnings removing from the swing/plaf packages Summary: Removed unnecessary castings and other warnings Reviewed-by: alexp Contributed-by: Florian Brunner ! src/share/classes/com/sun/java/swing/plaf/windows/DesktopProperty.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsDesktopManager.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsInternalFrameTitlePane.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsScrollBarUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicButtonListener.java ! src/share/classes/javax/swing/plaf/basic/BasicButtonUI.java ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxEditor.java ! src/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicGraphicsUtils.java ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameUI.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuUI.java ! src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java ! src/share/classes/javax/swing/plaf/basic/BasicRadioButtonUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSplitPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToggleButtonUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToolBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java ! src/share/classes/javax/swing/plaf/basic/DragRecognitionSupport.java ! src/share/classes/javax/swing/plaf/basic/LazyActionMap.java ! src/share/classes/javax/swing/plaf/metal/DefaultMetalTheme.java ! src/share/classes/javax/swing/plaf/metal/MetalBumps.java ! src/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java ! src/share/classes/javax/swing/plaf/metal/MetalIconFactory.java ! src/share/classes/javax/swing/plaf/metal/MetalInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/plaf/metal/MetalRadioButtonUI.java ! src/share/classes/javax/swing/plaf/metal/MetalToolBarUI.java ! src/share/classes/javax/swing/plaf/synth/DefaultSynthStyleFactory.java ! src/share/classes/javax/swing/plaf/synth/ImagePainter.java ! src/share/classes/javax/swing/plaf/synth/Region.java ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java ! src/share/classes/javax/swing/plaf/synth/SynthContext.java ! src/share/classes/javax/swing/plaf/synth/SynthEditorPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java ! src/share/classes/javax/swing/plaf/synth/SynthInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuItemUI.java ! src/share/classes/javax/swing/plaf/synth/SynthParser.java ! src/share/classes/javax/swing/plaf/synth/SynthSplitPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthStyle.java ! src/share/classes/javax/swing/plaf/synth/SynthTextAreaUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextFieldUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java ! src/share/classes/sun/swing/plaf/synth/DefaultSynthStyle.java ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java Changeset: 86b43f44bcc4 Author: idk Date: 2008-07-25 11:32 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/86b43f44bcc4 6608456: need API to define RepaintManager per components hierarchy Reviewed-by: alexp ! make/javax/swing/Makefile + src/share/classes/com/sun/java/swing/SwingUtilities3.java ! src/share/classes/javax/swing/RepaintManager.java + test/javax/swing/RepaintManager/6608456/bug6608456.java Changeset: 1c4449ef03ce Author: malenkov Date: 2008-07-25 21:00 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1c4449ef03ce 6630275: The spec on VetoableChangeSupport.fireVetoableChange should be updated Reviewed-by: peterz, rupashka ! src/share/classes/java/beans/PropertyChangeSupport.java ! src/share/classes/java/beans/VetoableChangeSupport.java + test/java/beans/VetoableChangeSupport/Test6630275.java Changeset: 619874c5989f Author: idk Date: 2008-07-25 14:13 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/619874c5989f 6638195: need API for EventQueueDelegate Reviewed-by: bchristi ! src/share/classes/com/sun/java/swing/SwingUtilities3.java ! src/share/classes/java/awt/EventDispatchThread.java + src/share/classes/sun/awt/EventQueueDelegate.java + test/java/awt/EventQueue/6638195/bug6638195.java Changeset: 59940b984f90 Author: idk Date: 2008-07-25 14:26 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/59940b984f90 6699328: NullPointerException in EventQueue.dispatchEvent when applet is closed, only reprise/scenario applet Reviewed-by: bchristi ! src/share/classes/com/sun/java/swing/SwingUtilities3.java ! src/share/classes/sun/awt/EventQueueDelegate.java Changeset: 7d45141e5d30 Author: mlapshin Date: 2008-08-08 20:49 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7d45141e5d30 6584657: GTK Look and Feel: Bugs in menu item layout Reviewed-by: peterz, alexp ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java ! src/share/classes/javax/swing/plaf/basic/DefaultMenuLayout.java ! src/share/classes/javax/swing/plaf/synth/DefaultMenuLayout.java ! src/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java + src/share/classes/javax/swing/plaf/synth/SynthMenuItemLayoutHelper.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuItemUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuUI.java ! src/share/classes/javax/swing/plaf/synth/SynthPopupMenuUI.java + src/share/classes/sun/swing/MenuItemLayoutHelper.java Changeset: 3f7b2ea2d611 Author: rupashka Date: 2008-08-11 16:39 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3f7b2ea2d611 6604281: NimbusL&F :Regression in Focus traversal in JFileChooser in pit build. Summary: Fixed calculation of preferred size in SynthButtonUI Reviewed-by: loneid, peterz ! src/share/classes/javax/swing/plaf/synth/SynthButtonUI.java + test/javax/swing/JButton/6604281/bug6604281.java Changeset: 5504518c0d1d Author: mlapshin Date: 2008-08-11 16:49 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5504518c0d1d 6579243: Windows, GTK: Internal frame title is drawn wrong if the frame has RTL orientation Summary: Added right-to-left code branches to WindowsInternalFrameTitlePane and Metacity classes Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/synth/SynthInternalFrameTitlePane.java Changeset: b5b7ec629a50 Author: mlapshin Date: 2008-08-12 12:52 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b5b7ec629a50 6735918: test/closed/javax/swing/JMenuItem/6458123/bug6458123.java fails on Linux Summary: All the bearings-related code is removed from MenuItemLayoutHelper class Reviewed-by: alexp ! src/share/classes/sun/swing/MenuItemLayoutHelper.java Changeset: c9d407ab2309 Author: lana Date: 2008-08-12 17:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c9d407ab2309 Merge ! make/tools/Makefile - make/tools/auto_multi/Makefile - make/tools/src/build/tools/automulti/AutoMulti.java - make/tools/src/build/tools/automulti/README.txt - make/tools/src/build/tools/automulti/TestALFGenerator.java - make/tools/src/build/tools/automulti/TestALFLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKColorChooserPanel.java ! src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java ! src/share/classes/java/beans/EventHandler.java - src/share/classes/javax/swing/colorchooser/DefaultHSBChooserPanel.java - src/share/classes/javax/swing/colorchooser/DefaultRGBChooserPanel.java - src/share/classes/javax/swing/colorchooser/SyntheticImage.java ! src/share/classes/javax/swing/plaf/basic/BasicButtonUI.java ! src/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java ! src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToolBarUI.java ! src/share/classes/javax/swing/plaf/metal/MetalIconFactory.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/plaf/synth/SynthSplitPaneUI.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/FlowView.java ! src/share/classes/javax/swing/text/NumberFormatter.java ! src/share/classes/javax/swing/text/PlainDocument.java ! src/share/classes/javax/swing/text/html/AccessibleHTML.java ! src/share/classes/javax/swing/text/html/CSS.java ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/share/classes/javax/swing/text/html/parser/AttributeList.java ! src/share/classes/javax/swing/text/html/parser/DTD.java ! src/share/classes/javax/swing/text/html/parser/Element.java ! src/share/classes/javax/swing/text/html/parser/Entity.java ! src/share/classes/javax/swing/text/html/parser/Parser.java ! src/share/classes/javax/swing/text/rtf/RTFAttributes.java ! src/share/classes/javax/swing/text/rtf/RTFGenerator.java Changeset: e78c2f17a606 Author: mlapshin Date: 2008-08-26 12:16 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e78c2f17a606 6736649: test/closed/javax/swing/JMenuItem/6458123/ManualBug6458123.java fails on Linux Summary: Now text bearings are taken into account when labelRect width is calculated Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/synth/SynthMenuItemLayoutHelper.java ! src/share/classes/sun/swing/MenuItemLayoutHelper.java Changeset: 336877026f07 Author: rupashka Date: 2008-08-26 15:12 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/336877026f07 6727662: Code improvement and warnings removing from swing packages Summary: Removed unnecessary castings and other warnings Reviewed-by: malenkov ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/AbstractCellEditor.java ! src/share/classes/javax/swing/AbstractListModel.java ! src/share/classes/javax/swing/AbstractSpinnerModel.java ! src/share/classes/javax/swing/ActionMap.java ! src/share/classes/javax/swing/AncestorNotifier.java ! src/share/classes/javax/swing/ArrayTable.java ! src/share/classes/javax/swing/ButtonGroup.java ! src/share/classes/javax/swing/DebugGraphicsInfo.java ! src/share/classes/javax/swing/DefaultBoundedRangeModel.java ! src/share/classes/javax/swing/DefaultButtonModel.java ! src/share/classes/javax/swing/DefaultFocusManager.java ! src/share/classes/javax/swing/DefaultListSelectionModel.java ! src/share/classes/javax/swing/DefaultSingleSelectionModel.java ! src/share/classes/javax/swing/GroupLayout.java ! src/share/classes/javax/swing/InputMap.java ! src/share/classes/javax/swing/JComboBox.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JDesktopPane.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/JFileChooser.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/JList.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JMenuBar.java ! src/share/classes/javax/swing/JMenuItem.java ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/javax/swing/JProgressBar.java ! src/share/classes/javax/swing/JScrollBar.java ! src/share/classes/javax/swing/JSlider.java ! src/share/classes/javax/swing/JSpinner.java ! src/share/classes/javax/swing/JTabbedPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/JTextField.java ! src/share/classes/javax/swing/JTree.java ! src/share/classes/javax/swing/JViewport.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/KeyboardManager.java ! src/share/classes/javax/swing/LayoutComparator.java ! src/share/classes/javax/swing/LayoutFocusTraversalPolicy.java ! src/share/classes/javax/swing/LegacyGlueFocusTraversalPolicy.java ! src/share/classes/javax/swing/MenuSelectionManager.java ! src/share/classes/javax/swing/MultiUIDefaults.java ! src/share/classes/javax/swing/PopupFactory.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/javax/swing/SortingFocusTraversalPolicy.java ! src/share/classes/javax/swing/SpringLayout.java ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/Timer.java ! src/share/classes/javax/swing/TimerQueue.java ! src/share/classes/javax/swing/UIDefaults.java ! src/share/classes/javax/swing/UIManager.java ! src/share/classes/javax/swing/filechooser/FileSystemView.java ! src/share/classes/javax/swing/table/AbstractTableModel.java ! src/share/classes/javax/swing/table/DefaultTableModel.java ! src/share/classes/javax/swing/tree/DefaultTreeCellEditor.java ! src/share/classes/javax/swing/tree/DefaultTreeModel.java ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/share/classes/javax/swing/tree/FixedHeightLayoutCache.java ! src/share/classes/javax/swing/tree/VariableHeightLayoutCache.java ! src/share/classes/javax/swing/undo/StateEdit.java ! src/share/classes/javax/swing/undo/UndoManager.java ! src/share/classes/javax/swing/undo/UndoableEditSupport.java ! src/share/classes/sun/swing/AccessibleMethod.java ! src/share/classes/sun/swing/FilePane.java ! src/share/classes/sun/swing/SwingLazyValue.java ! src/share/classes/sun/swing/SwingUtilities2.java Changeset: 7a3fd5d65936 Author: rupashka Date: 2008-08-27 20:49 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7a3fd5d65936 6351074: JFileChooser removes leading space in filename Summary: Removed trimming of leading spaces in filename Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java Changeset: 85d71654a220 Author: rupashka Date: 2008-08-29 13:23 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/85d71654a220 6742490: JSlider tests are located in JFileChooser directory Summary: Tests were moved to appropriate folder Reviewed-by: peterz - test/javax/swing/JFileChooser/4252173/bug4252173.java - test/javax/swing/JFileChooser/6524424/bug6524424.html - test/javax/swing/JFileChooser/6524424/bug6524424.java + test/javax/swing/JSlider/4252173/bug4252173.java + test/javax/swing/JSlider/6524424/bug6524424.html + test/javax/swing/JSlider/6524424/bug6524424.java Changeset: 8c34b54ef09c Author: rupashka Date: 2008-08-29 18:58 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8c34b54ef09c 6742358: MetalSliderUI paint wrong vertical disabled filled JSlider for DefaultMetalTheme Summary: Corrected the method MetalSliderUI.paintTrack Reviewed-by: malenkov ! src/share/classes/javax/swing/plaf/metal/MetalSliderUI.java + test/javax/swing/JSlider/6742358/bug6742358.html + test/javax/swing/JSlider/6742358/bug6742358.java Changeset: a4125097db18 Author: rupashka Date: 2008-08-30 17:29 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a4125097db18 6554743: JFileChooser dn't close after pressing escape key after changing the views Summary: Restore focus after changing the views in JFileChooser Reviewed-by: loneid ! src/share/classes/sun/swing/FilePane.java Changeset: 291feed36076 Author: peterz Date: 2008-09-01 15:21 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/291feed36076 5062055: JEditorPane HTML: HR-tag with attribute size=1px causes NumberFormatException Summary: Wrapped parseInt() with try/catch Reviewed-by: gsm ! src/share/classes/javax/swing/text/html/HRuleView.java + test/javax/swing/text/html/HRuleView/Test5062055.java Changeset: 71df74bef5ba Author: malenkov Date: 2008-09-01 17:36 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/71df74bef5ba 5026703: RFE: DOC: Are PropertyChangeSupport & VetoableChangeSupport Thread-Safe? --Docs Should Say Reviewed-by: peterz, rupashka ! src/share/classes/java/beans/PropertyChangeSupport.java ! src/share/classes/java/beans/VetoableChangeSupport.java Changeset: 9765266e5aea Author: malenkov Date: 2008-09-03 21:00 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9765266e5aea 6397609: DOC: De-register API required for PropertyEditorManager and/or doc change Reviewed-by: peterz, rupashka + src/share/classes/com/sun/beans/WeakCache.java ! src/share/classes/java/beans/PropertyEditorManager.java + test/java/beans/PropertyEditor/MemoryClassLoader.java + test/java/beans/PropertyEditor/Test6397609.java ! test/java/beans/PropertyEditor/TestEditor.java Changeset: 2055acc62a85 Author: rupashka Date: 2008-09-04 15:15 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2055acc62a85 6278700: JSlider created with BoundedRangeModel fires twice when changed Summary: Removed second registration of listener Reviewed-by: peterz ! src/share/classes/javax/swing/JSlider.java + test/javax/swing/JSlider/6278700/bug6278700.java Changeset: 77dc7ca7879f Author: peytoia Date: 2008-09-08 10:44 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/77dc7ca7879f 6665028: native code of method j*.text.Bidi.nativeBidiChars is using the contents of a primitive array direct Reviewed-by: okutsu ! src/share/native/sun/font/bidi/ubidi.c + test/java/text/Bidi/Bug6665028.java Changeset: 3d8640f597b2 Author: peytoia Date: 2008-09-08 11:49 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3d8640f597b2 6607310: InputContext may cause loading of swing classes even for non-Swing applets Reviewed-by: okutsu ! src/share/classes/sun/awt/im/CompositionArea.java ! src/share/classes/sun/awt/im/InputContext.java Changeset: 9b8e20a3c5f0 Author: peytoia Date: 2008-09-08 13:31 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9b8e20a3c5f0 6645292: [Fmt-Da] Timezone Western Summer Time (Australia) is parsed incorrectly Reviewed-by: okutsu ! src/share/classes/java/text/SimpleDateFormat.java + test/java/text/Format/DateFormat/Bug6645292.java Changeset: 1b0b3a777a6c Author: peytoia Date: 2008-09-08 14:31 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1b0b3a777a6c 4823811: [Fmt-Da] SimpleDateFormat patterns don't allow embedding of some literal punctuation Reviewed-by: okutsu ! src/share/classes/java/text/SimpleDateFormat.java + test/java/text/Format/DateFormat/Bug4823811.java Changeset: 21346d9b372a Author: peytoia Date: 2008-09-08 14:48 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/21346d9b372a 6650748: (tz) Java runtime doesn't detect VET time zone correctly on Windows Reviewed-by: okutsu ! src/windows/lib/tzmappings Changeset: 67c41d740e6d Author: peytoia Date: 2008-09-08 15:21 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/67c41d740e6d 6466476: (tz) Introduction of tzdata2005r can introduce incompatility issues with some JDK1.1 3-letter TZ Ids Reviewed-by: okutsu ! make/java/java/FILES_java.gmk + src/share/classes/sun/util/calendar/TzIDOldMapping.java ! src/share/classes/sun/util/calendar/ZoneInfo.java + test/java/util/TimeZone/OldIDMappingTest.java + test/java/util/TimeZone/OldIDMappingTest.sh Changeset: 66b0b1231530 Author: peytoia Date: 2008-09-08 17:35 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/66b0b1231530 6730743: (tz) Support tzdata2008e Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/backward ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/iso3166.tab ! make/sun/javazic/tzdata/leapseconds ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/southamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java Changeset: 32fb1f4f40b8 Author: rupashka Date: 2008-09-10 19:16 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/32fb1f4f40b8 6587742: filling half of a JSlider's track is no longer optional Summary: now OceanTheme uses the JSlider.isFilled property like other themes Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/metal/MetalSliderUI.java + test/javax/swing/JSlider/6587742/bug6587742.html + test/javax/swing/JSlider/6587742/bug6587742.java Changeset: af375b98f9b3 Author: lana Date: 2008-09-24 08:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/af375b98f9b3 Merge ! make/java/java/FILES_java.gmk - make/tools/auto_multi/Makefile - make/tools/src/build/tools/automulti/AutoMulti.java - make/tools/src/build/tools/automulti/README.txt - make/tools/src/build/tools/automulti/TestALFGenerator.java - make/tools/src/build/tools/automulti/TestALFLookAndFeel.java - src/share/classes/javax/swing/colorchooser/DefaultHSBChooserPanel.java - src/share/classes/javax/swing/colorchooser/DefaultRGBChooserPanel.java - src/share/classes/javax/swing/colorchooser/SyntheticImage.java - test/javax/swing/JFileChooser/4252173/bug4252173.java - test/javax/swing/JFileChooser/6524424/bug6524424.html - test/javax/swing/JFileChooser/6524424/bug6524424.java Changeset: fac669fa0f24 Author: lana Date: 2008-10-13 17:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fac669fa0f24 Merge ! make/java/java/FILES_java.gmk - make/tools/auto_multi/Makefile - make/tools/src/build/tools/automulti/AutoMulti.java - make/tools/src/build/tools/automulti/README.txt - make/tools/src/build/tools/automulti/TestALFGenerator.java - make/tools/src/build/tools/automulti/TestALFLookAndFeel.java - src/share/classes/javax/swing/colorchooser/DefaultHSBChooserPanel.java - src/share/classes/javax/swing/colorchooser/DefaultRGBChooserPanel.java - src/share/classes/javax/swing/colorchooser/SyntheticImage.java - test/javax/swing/JFileChooser/4252173/bug4252173.java - test/javax/swing/JFileChooser/6524424/bug6524424.html - test/javax/swing/JFileChooser/6524424/bug6524424.java Changeset: cc5f810b5af8 Author: tbell Date: 2008-10-17 08:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cc5f810b5af8 Merge - make/tools/auto_multi/Makefile - make/tools/src/build/tools/automulti/AutoMulti.java - make/tools/src/build/tools/automulti/README.txt - make/tools/src/build/tools/automulti/TestALFGenerator.java - make/tools/src/build/tools/automulti/TestALFLookAndFeel.java - src/share/classes/javax/swing/colorchooser/DefaultHSBChooserPanel.java - src/share/classes/javax/swing/colorchooser/DefaultRGBChooserPanel.java - src/share/classes/javax/swing/colorchooser/SyntheticImage.java - test/javax/swing/JFileChooser/4252173/bug4252173.java - test/javax/swing/JFileChooser/6524424/bug6524424.html - test/javax/swing/JFileChooser/6524424/bug6524424.java Changeset: 5eab86fc2ea8 Author: tbell Date: 2008-10-17 16:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5eab86fc2ea8 Merge From tim.bell at sun.com Sun Oct 19 02:58:47 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 19 Oct 2008 02:58:47 +0000 Subject: hg: jdk7/tl/langtools: 3 new changesets Message-ID: <20081019025856.66BDED60E@hg.openjdk.java.net> Changeset: 31f03e49d18d Author: xdono Date: 2008-10-09 11:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/31f03e49d18d Added tag jdk7-b37 for changeset 24a47c3062fe ! .hgtags Changeset: 3fd42dfa6f27 Author: tbell Date: 2008-10-10 13:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3fd42dfa6f27 Merge Changeset: acc41893695b Author: tbell Date: 2008-10-17 16:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/acc41893695b Merge - src/share/classes/com/sun/tools/javac/util/Messages.java From i30817 at gmail.com Sun Oct 19 21:13:35 2008 From: i30817 at gmail.com (Paulo Levi) Date: Sun, 19 Oct 2008 22:13:35 +0100 Subject: Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin) In-Reply-To: <212322090810171326n7f2d689eh660f23868b3cad88@mail.gmail.com> References: <212322090810171249u5d7cd272gb51e0ce545802be9@mail.gmail.com> <212322090810171258y2c50bda0o1c26f56650b90d1b@mail.gmail.com> <1ccfd1c10810171308l3852223ci692e9dcddcc613ca@mail.gmail.com> <212322090810171326n7f2d689eh660f23868b3cad88@mail.gmail.com> Message-ID: <212322090810191413t440de971naa2112a5ab7ecec4@mail.gmail.com> Well maybe there SHOULD be a way that the method didn't exist in the earlier version. A way that failed at compile time when the user of the api tried to use that CharSequence. What is wrong about having a field in the class definition (version) and the platform having a series of of Interface alterations declared (since version). Then it could raise a error on the client, if he tried to use the method on a compiled api (or even better not show the method). Is this impossible? From i30817 at gmail.com Mon Oct 20 00:33:24 2008 From: i30817 at gmail.com (Paulo Levi) Date: Mon, 20 Oct 2008 01:33:24 +0100 Subject: RandomAccessFile closeability. Message-ID: <212322090810191733m66ec2a66h119b1fef8109d016@mail.gmail.com> Hi a bug, i've been seeing: First a simplification: Two different RandomAccessFile objects, inited in "r" mode and pointing to the same file appear to be interfering on on their reads (concurrent threads). They both manipulate the file pointer i guess, but i expected nothing bad to happen, because they are in read mode. The real story: The library i'm using is more than a "RandomAccessFile", so i'm not actually sure the error occurs here or in some static state somewhere. I'd like to fix this so its transparent to the clients of the api i'm building (me!) so i'd like to find the bug, or if this is a known issue i guess i can make a factory + map of live RandomAccessFiles. Asking if the situation described above is a known bug of RandomAccessFile? From Alan.Bateman at Sun.COM Mon Oct 20 07:38:11 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Mon, 20 Oct 2008 08:38:11 +0100 Subject: RandomAccessFile closeability. In-Reply-To: <212322090810191733m66ec2a66h119b1fef8109d016@mail.gmail.com> References: <212322090810191733m66ec2a66h119b1fef8109d016@mail.gmail.com> Message-ID: <48FC3563.7070305@sun.com> Paulo Levi wrote: > Hi a bug, i've been seeing: > First a simplification: > Two different RandomAccessFile objects, inited in "r" mode and > pointing to the same file appear to be interfering on on their reads > (concurrent threads). They both manipulate the file pointer i guess, > but i expected nothing bad to happen, because they are in read mode. > > The real story: > The library i'm using is more than a "RandomAccessFile", so i'm not > actually sure the error occurs here or in some static state somewhere. > > I'd like to fix this so its transparent to the clients of the api i'm > building (me!) so i'd like to find the bug, or if this is a known > issue i guess i can make a factory + map of live RandomAccessFiles. > > Asking if the situation described above is a known bug of RandomAccessFile? > This does not sound familiar. Are you 100% sure you don't have concurrent threads seeking and reading with the same RandomAccessFile instance? Do you have a test case that demonstrates the issue? -Alan. From bradford.wetmore at sun.com Mon Oct 20 20:26:29 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Mon, 20 Oct 2008 20:26:29 +0000 Subject: hg: jdk7/tl/jdk: 7 new changesets Message-ID: <20081020202810.9A52AD678@hg.openjdk.java.net> Changeset: 486b917ed417 Author: mullan Date: 2008-10-07 13:41 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/486b917ed417 6752764: PIT B37: CertPath/CertPathValidatorTest/KeyParamsInheritanceTest failed Summary: fix regression introduced by 6465942 Reviewed-by: vinnie ! src/share/classes/sun/security/provider/certpath/BasicChecker.java Changeset: 3c234822b837 Author: mullan Date: 2008-10-07 13:48 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3c234822b837 Merge - src/share/classes/com/sun/jmx/interceptor/MBeanServerSupport.java - src/share/classes/java/nio/channels/package.html - src/share/classes/org/jcp/xml/dsig/internal/package.html - src/share/classes/sun/nio/ch/OptionAdaptor.java - src/share/classes/sun/nio/ch/SocketOpts.java - src/share/classes/sun/nio/ch/SocketOptsImpl.java - src/share/classes/sun/nio/ch/exceptions - src/share/javavm/include/opcodes.h - src/share/javavm/include/opcodes.length - src/share/javavm/include/opcodes.list - src/share/javavm/include/opcodes.weight - src/share/javavm/include/opcodes.wide - src/share/javavm/include/sys_api.h - src/share/javavm/include/typedefs.h - src/solaris/javavm/include/typedefs_md.h - src/windows/javavm/include/typedefs_md.h Changeset: 8b2d7e577d4a Author: mullan Date: 2008-10-07 14:44 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8b2d7e577d4a Merge Changeset: 3f051f3ba5bb Author: weijun Date: 2008-10-17 13:02 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3f051f3ba5bb 6706974: Add krb5 test infrastructure Reviewed-by: valeriep + test/sun/security/krb5/auto/Action.java + test/sun/security/krb5/auto/BasicKrb5Test.java + test/sun/security/krb5/auto/CleanState.java + test/sun/security/krb5/auto/Context.java + test/sun/security/krb5/auto/CrossRealm.java + test/sun/security/krb5/auto/KDC.java + test/sun/security/krb5/auto/KerberosHashEqualsTest.java + test/sun/security/krb5/auto/OneKDC.java + test/sun/security/krb5/auto/basic.sh Changeset: 064e6a087f77 Author: wetmore Date: 2008-10-17 00:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/064e6a087f77 Merge Changeset: 0bf6c9c6fdc5 Author: weijun Date: 2008-10-20 10:32 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bf6c9c6fdc5 6761072: new krb5 tests fail on multiple platforms Reviewed-by: xuelei ! test/sun/security/krb5/auto/BasicKrb5Test.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/OneKDC.java Changeset: 7df3f9183f67 Author: wetmore Date: 2008-10-20 01:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7df3f9183f67 Merge From jonathan.gibbons at sun.com Mon Oct 20 20:44:34 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Mon, 20 Oct 2008 20:44:34 +0000 Subject: hg: jdk7/tl/langtools: 6759996: ignore empty entries on paths Message-ID: <20081020204438.3B29BD695@hg.openjdk.java.net> Changeset: 8ae974495e73 Author: jjg Date: 2008-10-20 13:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8ae974495e73 6759996: ignore empty entries on paths Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/file/Paths.java + test/tools/javac/T6759996.java From i30817 at gmail.com Mon Oct 20 21:19:31 2008 From: i30817 at gmail.com (Paulo Levi) Date: Mon, 20 Oct 2008 22:19:31 +0100 Subject: RandomAccessFile closeability. In-Reply-To: <48FC3563.7070305@sun.com> References: <212322090810191733m66ec2a66h119b1fef8109d016@mail.gmail.com> <48FC3563.7070305@sun.com> Message-ID: <212322090810201419y1f7c6db7n51c1b429343a0403@mail.gmail.com> Now, i'm pretty sure it is the second option (some shared state somewhere in the library). I've searched google and the only problems i can find are of the "same object" variety, and the problem appears reliably (across computers) and it's definitely not the same object, so it's probably some shared state in the library or my usage of it. Sorry about the wasted cycles - i should have deduced this before asking. From Joe.Darcy at Sun.COM Tue Oct 21 01:59:09 2008 From: Joe.Darcy at Sun.COM (Joe Darcy) Date: Mon, 20 Oct 2008 18:59:09 -0700 Subject: SecurityException in AnnotationInvocationHandler.getMemberMethods In-Reply-To: <1ccfd1c10810161246l51643ddfi7d13e094ad11ccb4@mail.gmail.com> References: <1ccfd1c10810161246l51643ddfi7d13e094ad11ccb4@mail.gmail.com> Message-ID: <48FD376D.9080105@sun.com> Hello. On 10/16/08 12:46 PM, Martin Buchholz wrote: > Hi all, > > This is a bug report with fix. > Joe Darcy, please file a bug and review this change, > I've filed 6761678 "(ann) SecurityException in AnnotationInvocationHandler.getMemberMethods" for this issue. The problem seems similar to 6370080 "(ann) Method.getAnnotations() sometimes throw SecurityException: doPrivileged or javadoc missing?," which was fixed in JDK 6 and a JDK 5 update release. Martin, can you, Toby, and Josh review any other uses of reflection in the src/share/classes/sun/reflect/annotation package for similar problems so we can address any other such issues now? I've looked over the change and the use of getMemberMethods in equalsImpl and don't see a problem. However, I'd like the security team to give it a once over too; security-dev folk, please take a look at this. Thanks, -Joe > and perhaps provide a small test case (it is impractical > to share the test we have at Google). > > Description: > > sun/reflect/annotation/AnnotationInvocationHandler.java.getMemberMethods > might throw if there is a security manager that does not allow > getDeclaredMethods. > > The author of this code (Josh Bloch) confirms that the intent was for the > doPrivileged block in this method to prevent security exceptions. > The methods cannot escape to untrusted code. > > Evaluation: > > Yes. Fix provided courtesy of Toby Reyelts and Josh Bloch at Google. > > # HG changeset patch > # User martin > # Date 1224185752 25200 > # Node ID 68730f05449cd4f39ce1cb82adc6c4e57f87554f > # Parent 214ebdcf7252d4862449fe0ae295e6c60a127315 > SecurityException in AnnotationInvocationHandler.getMemberMethods > Summary: Move call to getDeclaredMethods inside doPrivileged > Reviewed-by: > Contributed-by: jjb at google.com > > diff --git a/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java > b/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java > --- a/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java > +++ b/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java > @@ -272,14 +272,14 @@ > */ > private Method[] getMemberMethods() { > if (memberMethods == null) { > - final Method[] mm = type.getDeclaredMethods(); > - AccessController.doPrivileged(new PrivilegedAction() { > - public Void run() { > - AccessibleObject.setAccessible(mm, true); > - return null; > - } > - }); > - memberMethods = mm; > + memberMethods = AccessController.doPrivileged( > + new PrivilegedAction() { > + public Method[] run() { > + final Method[] mm = type.getDeclaredMethods(); > + AccessibleObject.setAccessible(mm, true); > + return mm; > + } > + }); > } > return memberMethods; > } > From Joe.Darcy at Sun.COM Tue Oct 21 02:01:23 2008 From: Joe.Darcy at Sun.COM (Joe Darcy) Date: Mon, 20 Oct 2008 19:01:23 -0700 Subject: SecurityException in AnnotationInvocationHandler.getMemberMethods In-Reply-To: <48FD376D.9080105@sun.com> References: <1ccfd1c10810161246l51643ddfi7d13e094ad11ccb4@mail.gmail.com> <48FD376D.9080105@sun.com> Message-ID: <48FD37F3.9070208@sun.com> PS Martin, I haven't written tests that setup and use a security manager, etc., that should go along with this fix. Having a stand-alone regression test along those lines would be helpful. Thanks, -Joe On 10/20/08 06:59 PM, Joe Darcy wrote: > Hello. > > On 10/16/08 12:46 PM, Martin Buchholz wrote: >> Hi all, >> >> This is a bug report with fix. >> Joe Darcy, please file a bug and review this change, >> > > I've filed 6761678 "(ann) SecurityException in > AnnotationInvocationHandler.getMemberMethods" for this issue. The > problem seems similar to 6370080 "(ann) Method.getAnnotations() > sometimes throw SecurityException: doPrivileged or javadoc missing?," > which was fixed in JDK 6 and a JDK 5 update release. > > Martin, can you, Toby, and Josh review any other uses of reflection in > the src/share/classes/sun/reflect/annotation package for similar > problems so we can address any other such issues now? > > I've looked over the change and the use of getMemberMethods in > equalsImpl and don't see a problem. However, I'd like the security > team to give it a once over too; security-dev folk, please take a look > at this. > > Thanks, > > -Joe >> and perhaps provide a small test case (it is impractical >> to share the test we have at Google). >> >> Description: >> >> sun/reflect/annotation/AnnotationInvocationHandler.java.getMemberMethods >> might throw if there is a security manager that does not allow >> getDeclaredMethods. >> >> The author of this code (Josh Bloch) confirms that the intent was for >> the >> doPrivileged block in this method to prevent security exceptions. >> The methods cannot escape to untrusted code. >> >> Evaluation: >> >> Yes. Fix provided courtesy of Toby Reyelts and Josh Bloch at Google. >> >> # HG changeset patch >> # User martin >> # Date 1224185752 25200 >> # Node ID 68730f05449cd4f39ce1cb82adc6c4e57f87554f >> # Parent 214ebdcf7252d4862449fe0ae295e6c60a127315 >> SecurityException in AnnotationInvocationHandler.getMemberMethods >> Summary: Move call to getDeclaredMethods inside doPrivileged >> Reviewed-by: >> Contributed-by: jjb at google.com >> >> diff --git >> a/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >> >> b/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >> >> --- >> a/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >> >> +++ >> b/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >> >> @@ -272,14 +272,14 @@ >> */ >> private Method[] getMemberMethods() { >> if (memberMethods == null) { >> - final Method[] mm = type.getDeclaredMethods(); >> - AccessController.doPrivileged(new >> PrivilegedAction() { >> - public Void run() { >> - AccessibleObject.setAccessible(mm, true); >> - return null; >> - } >> - }); >> - memberMethods = mm; >> + memberMethods = AccessController.doPrivileged( >> + new PrivilegedAction() { >> + public Method[] run() { >> + final Method[] mm = type.getDeclaredMethods(); >> + AccessibleObject.setAccessible(mm, true); >> + return mm; >> + } >> + }); >> } >> return memberMethods; >> } >> > From jaroslav.tulach at sun.com Tue Oct 21 13:34:47 2008 From: jaroslav.tulach at sun.com (Jaroslav Tulach) Date: Tue, 21 Oct 2008 15:34:47 +0200 Subject: Technical review was: [PATCH] Enhance ServiceLoader to understand factory methods References: Message-ID: OK, so now, after Mark's reply, we know that it is possible to include such little, compatible extensions of an existing APIs into the Maintenance JSR. Good. Now please tell me, what shall I do to make it happen[1]? Will Mark or someone else from core-libs@ do a technical review of my patch? By when? -jst [1] I'd like my patch to not be dropped just because, we wait and wait and wait and then it will be "too late". Jaroslav Tulach wrote: > Proposal: Enhance ServiceLoader to understand factory methods > > Justification: A lot of our services in NetBeans are final classes. Still, > we > would like to use the META-INF/services registration to register their > providers. Currently this does not work, we either need to unfinalize the > classes (which restricts future evolution options) or use different ways > of registering the providers. We propose simple and backward compatible > extension to current ServiceLoader registration scheme. If accepted, > NetBeans'll eliminate our non-standard registration methods, while keeping > benefits of final classes. Moreover the same techniques will be available > to any JavaSE project. > > Risks: API change includes simple, compatible extension. New code is able > to accept old registrations. Old code (JDK6) will generate > ServiceConfigurationError in case of seeing new registration, however. > > Test: I have found tests in test/java/util/ServiceLoader/ directory and > I've modified them to verify also our new usecase. All of them are > passing, if I run them by running ./basic.sh script - I am not sure if > that is the right way of running your tests. > > I am attaching my current patch. Let me know what shall I change to allow > this > to be integrated to OpenJDK7. Thanks a lot. > > Jaroslav Tulach > NetBeans Platform Architect From Alan.Bateman at Sun.COM Tue Oct 21 14:25:29 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Tue, 21 Oct 2008 15:25:29 +0100 Subject: Technical review was: [PATCH] Enhance ServiceLoader to understand factory methods In-Reply-To: References: Message-ID: <48FDE659.4000406@sun.com> Jaroslav Tulach wrote: > OK, so now, after Mark's reply, we know that it is possible to include such > little, compatible extensions of an existing APIs into the Maintenance JSR. > Good. Now please tell me, what shall I do to make it happen[1]? > > Will Mark or someone else from core-libs@ do a technical review of my patch? > By when? > -jst > > [1] I'd like my patch to not be dropped just because, we wait and wait and > wait and then it will be "too late". > If it goes ahead then I'm happen to help get it to the finish line. One thing I didn't see in the patch is the proposed spec updates -- ie: updates to the class description to allow for the configuration file to contain the names of static factory methods that create instances of the service type. I also suspect we might have to re-visit other places that make use of this facility. The reason is that most usages were originally users of sun.misc.Service and so have their own descriptions as to how their respective providers are loaded. Rather than duplicating the description then it might be better to change them to reference ServiceLoader. -Alan. From i30817 at gmail.com Tue Oct 21 18:04:02 2008 From: i30817 at gmail.com (Paulo Levi) Date: Tue, 21 Oct 2008 19:04:02 +0100 Subject: Is InputMap serializable or not? Message-ID: <212322090810211104x5526900cqf5917c5a017c6ad1@mail.gmail.com> Hi. I found that the component input map advertises itself as serializable, but it is really not, because somehow it seems to hold a reference to a not serializable ActionMap. A test case, sorry about the write/read functions, they were copied from a utility class (as you can see i had to replace the logging class): package ui; import java.io.BufferedInputStream; import java.io.BufferedOutputStream; import java.io.Closeable; import java.io.FileInputStream; import java.io.FileOutputStream; import java.io.ObjectInputStream; import java.io.ObjectOutputStream; import java.io.Serializable; import java.util.concurrent.Callable; import java.util.logging.Level; import java.util.logging.Logger; import javax.swing.InputMap; import javax.swing.JTextPane; import javax.swing.KeyStroke; import static junit.framework.Assert.*; import org.junit.After; import org.junit.AfterClass; import org.junit.Before; import org.junit.BeforeClass; import org.junit.Test; import util.io.IoUtils; /** * * @author i30817 */ public class ApplicationTest { public ApplicationTest() { } @BeforeClass public static void setUpClass() throws Exception { } @AfterClass public static void tearDownClass() throws Exception { } @Before public void setUp() { } @After public void tearDown() { } /** * Test of read method, of class Application. */ @Test public void testInputMapSerialization() { JTextPane editor = new JTextPane(); InputMap map = editor.getInputMap(); KeyStroke keystroke = KeyStroke.getKeyStroke("shift SPACE"); map.put(keystroke, "test"); writeObjects("InputMap", map); InputMap other = readObject("InputMap", new Callable(){ public Object call() throws Exception { return new InputMap(); } }); assertEquals("test", other.get(keystroke)); } /** * If possible reads an object, if not tries to instanciate the * object with the given Callable. This allows lazy instantiation. * This funtion can only read 1 object per file, to allow encapsulation * of the inputstreams. * If an exception occurs in the lazy instantiation it returns null. * Remember that if using Externalizable transient fields/static scopes * fields ARE initalized. The use of the default constructor assures that. * The order of inicialization is: * Externalizable : default constructor, readExternal * Serializable : first non-serializable super class default constructor, * readObject * So with externalizable you need to be carefull to replace the super state * and not to use it in the default constructor. * In serializable, you need to replace the constructor state. */ @SuppressWarnings(value = "unchecked") public static T readObject(String objectLocation, Callable t) { ObjectInputStream s = null; try { s = new ObjectInputStream(new BufferedInputStream(new FileInputStream(objectLocation))); return (T) s.readObject(); } catch (Throwable ex) { Logger.getLogger(IoUtils.class.getName()).log(Level.WARNING, "Couldnt read object", ex); if (t != null) { try { return (T) t.call(); } catch (Throwable e) { Logger.getLogger(ApplicationTest.class.getName()).log(Level.SEVERE, "Couldnt create object", e); } } } finally { close(s); } return null; } /** * If possible writes objects. Disallows null objects */ public static void writeObjects(String objectLocation, Serializable... obj) { ObjectOutputStream s = null; try { s = new ObjectOutputStream(new BufferedOutputStream(new FileOutputStream(objectLocation))); for (Serializable a : obj) { if (a != null) { s.writeObject(a); } } s.flush(); } catch (Throwable ex) { Logger.getLogger(ApplicationTest.class.getName()).log(Level.SEVERE, "Couldnt write object", ex); } finally { close(s); } } /** * Close closeables. Use this in a finally clause. */ public static void close(Closeable... closeables) { for (Closeable c : closeables) { if (c != null) { try { c.close(); } catch (Throwable ex) { Logger.getLogger(ApplicationTest.class.getName()).log(Level.WARNING, "Couldnt close Closeable", ex); } } } } } From Sean.Mullan at Sun.COM Tue Oct 21 20:12:12 2008 From: Sean.Mullan at Sun.COM (Sean Mullan) Date: Tue, 21 Oct 2008 16:12:12 -0400 Subject: [security-dev 00357]: Re: SecurityException in AnnotationInvocationHandler.getMemberMethods In-Reply-To: <48FD376D.9080105@sun.com> References: <1ccfd1c10810161246l51643ddfi7d13e094ad11ccb4@mail.gmail.com> <48FD376D.9080105@sun.com> Message-ID: <48FE379C.30200@sun.com> I looked at the code changes and it seems fine to me. --Sean Joe Darcy wrote: > Hello. > > On 10/16/08 12:46 PM, Martin Buchholz wrote: >> Hi all, >> >> This is a bug report with fix. >> Joe Darcy, please file a bug and review this change, >> > > I've filed 6761678 "(ann) SecurityException in > AnnotationInvocationHandler.getMemberMethods" for this issue. The > problem seems similar to 6370080 "(ann) Method.getAnnotations() > sometimes throw SecurityException: doPrivileged or javadoc missing?," > which was fixed in JDK 6 and a JDK 5 update release. > > Martin, can you, Toby, and Josh review any other uses of reflection in > the src/share/classes/sun/reflect/annotation package for similar > problems so we can address any other such issues now? > > I've looked over the change and the use of getMemberMethods in > equalsImpl and don't see a problem. However, I'd like the security team > to give it a once over too; security-dev folk, please take a look at this. > > Thanks, > > -Joe >> and perhaps provide a small test case (it is impractical >> to share the test we have at Google). >> >> Description: >> >> sun/reflect/annotation/AnnotationInvocationHandler.java.getMemberMethods >> might throw if there is a security manager that does not allow >> getDeclaredMethods. >> >> The author of this code (Josh Bloch) confirms that the intent was for the >> doPrivileged block in this method to prevent security exceptions. >> The methods cannot escape to untrusted code. >> >> Evaluation: >> >> Yes. Fix provided courtesy of Toby Reyelts and Josh Bloch at Google. >> >> # HG changeset patch >> # User martin >> # Date 1224185752 25200 >> # Node ID 68730f05449cd4f39ce1cb82adc6c4e57f87554f >> # Parent 214ebdcf7252d4862449fe0ae295e6c60a127315 >> SecurityException in AnnotationInvocationHandler.getMemberMethods >> Summary: Move call to getDeclaredMethods inside doPrivileged >> Reviewed-by: >> Contributed-by: jjb at google.com >> >> diff --git >> a/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >> >> b/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >> >> --- >> a/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >> >> +++ >> b/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >> >> @@ -272,14 +272,14 @@ >> */ >> private Method[] getMemberMethods() { >> if (memberMethods == null) { >> - final Method[] mm = type.getDeclaredMethods(); >> - AccessController.doPrivileged(new PrivilegedAction() { >> - public Void run() { >> - AccessibleObject.setAccessible(mm, true); >> - return null; >> - } >> - }); >> - memberMethods = mm; >> + memberMethods = AccessController.doPrivileged( >> + new PrivilegedAction() { >> + public Method[] run() { >> + final Method[] mm = type.getDeclaredMethods(); >> + AccessibleObject.setAccessible(mm, true); >> + return mm; >> + } >> + }); >> } >> return memberMethods; >> } >> > From martinrb at google.com Wed Oct 22 00:58:33 2008 From: martinrb at google.com (Martin Buchholz) Date: Tue, 21 Oct 2008 17:58:33 -0700 Subject: SecurityException in AnnotationInvocationHandler.getMemberMethods In-Reply-To: <48FD37F3.9070208@sun.com> References: <1ccfd1c10810161246l51643ddfi7d13e094ad11ccb4@mail.gmail.com> <48FD376D.9080105@sun.com> <48FD37F3.9070208@sun.com> Message-ID: <1ccfd1c10810211758u10bfbbf7j2b8b4fcfb050ef20@mail.gmail.com> If I had known when I started how hard it would be, I would never have started writing one... Where are annotations tests supposed to go? They seem under-test-covered. I've put it into a new directory, test/java/lang/annotation Please review. The following fails with current openjdk, passes with proposed fix. /* * Copyright 2008 Sun Microsystems, Inc. All Rights Reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, * CA 95054 USA or visit www.sun.com if you need additional information or * have any questions. */ /* * @test * @bug 6761678 * @summary Check properties of Annotations returned from * getParameterAnnotations, including freedom from security * exceptions. * @author Martin Buchholz */ import java.lang.annotation.Annotation; import java.lang.annotation.ElementType; import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; import java.lang.annotation.Target; import java.lang.reflect.Method; import java.security.Permission; import java.security.Policy; import java.security.ProtectionDomain; @Retention(RetentionPolicy.RUNTIME) @Target({ ElementType.FIELD, ElementType.PARAMETER }) @interface Named { String value(); } public class ParameterAnnotations { // A security policy that differs from the default only in that it // allows a security manager to be uninstalled. static class MyPolicy extends Policy { final Policy defaultPolicy; MyPolicy(Policy defaultPolicy) { this.defaultPolicy = defaultPolicy; } public boolean implies(ProtectionDomain pd, Permission p) { return p.getName().equals("setSecurityManager") || defaultPolicy.implies(pd, p); } } public void nop(@Named("foo") Object foo, @Named("bar") Object bar) { } void test(String[] args) throws Throwable { // Test without a security manager test1(); // Test with a security manager Policy defaultPolicy = Policy.getPolicy(); Policy.setPolicy(new MyPolicy(defaultPolicy)); System.setSecurityManager(new SecurityManager()); try { test1(); } finally { System.setSecurityManager(null); Policy.setPolicy(defaultPolicy); } } void test1() throws Throwable { for (Method m : thisClass.getMethods()) { if (m.getName().equals("nop")) { Annotation[][] ann = m.getParameterAnnotations(); equal(ann.length, 2); Annotation foo = ann[0][0]; Annotation bar = ann[1][0]; equal(foo.toString(), "@Named(value=foo)"); equal(bar.toString(), "@Named(value=bar)"); check(foo.equals(foo)); check(! foo.equals(bar)); } } } //--------------------- Infrastructure --------------------------- volatile int passed = 0, failed = 0; void pass() {passed++;} void fail() {failed++; Thread.dumpStack();} void fail(String msg) {System.err.println(msg); fail();} void unexpected(Throwable t) {failed++; t.printStackTrace();} void check(boolean cond) {if (cond) pass(); else fail();} void equal(Object x, Object y) { if (x == null ? y == null : x.equals(y)) pass(); else fail(x + " not equal to " + y);} static Class thisClass = new Object(){}.getClass().getEnclosingClass(); public static void main(String[] args) throws Throwable { try {thisClass.getMethod("instanceMain",String[].class) .invoke(thisClass.newInstance(), (Object) args);} catch (Throwable e) {throw e.getCause();}} public void instanceMain(String[] args) throws Throwable { try {test(args);} catch (Throwable t) {unexpected(t);} System.out.printf("%nPassed = %d, failed = %d%n%n", passed, failed); if (failed > 0) throw new AssertionError("Some tests failed");} } Martin On Mon, Oct 20, 2008 at 19:01, Joe Darcy wrote: > PS Martin, I haven't written tests that setup and use a security manager, > etc., that should go along with this fix. Having a stand-alone regression > test along those lines would be helpful. > > Thanks, > > -Joe > > On 10/20/08 06:59 PM, Joe Darcy wrote: >> >> Hello. >> >> On 10/16/08 12:46 PM, Martin Buchholz wrote: >>> >>> Hi all, >>> >>> This is a bug report with fix. >>> Joe Darcy, please file a bug and review this change, >>> >> >> I've filed 6761678 "(ann) SecurityException in >> AnnotationInvocationHandler.getMemberMethods" for this issue. The problem >> seems similar to 6370080 "(ann) Method.getAnnotations() sometimes throw >> SecurityException: doPrivileged or javadoc missing?," which was fixed in JDK >> 6 and a JDK 5 update release. >> >> Martin, can you, Toby, and Josh review any other uses of reflection in the >> src/share/classes/sun/reflect/annotation package for similar problems so we >> can address any other such issues now? >> >> I've looked over the change and the use of getMemberMethods in equalsImpl >> and don't see a problem. However, I'd like the security team to give it a >> once over too; security-dev folk, please take a look at this. >> >> Thanks, >> >> -Joe >>> >>> and perhaps provide a small test case (it is impractical >>> to share the test we have at Google). >>> >>> Description: >>> >>> sun/reflect/annotation/AnnotationInvocationHandler.java.getMemberMethods >>> might throw if there is a security manager that does not allow >>> getDeclaredMethods. >>> >>> The author of this code (Josh Bloch) confirms that the intent was for the >>> doPrivileged block in this method to prevent security exceptions. >>> The methods cannot escape to untrusted code. >>> >>> Evaluation: >>> >>> Yes. Fix provided courtesy of Toby Reyelts and Josh Bloch at Google. >>> >>> # HG changeset patch >>> # User martin >>> # Date 1224185752 25200 >>> # Node ID 68730f05449cd4f39ce1cb82adc6c4e57f87554f >>> # Parent 214ebdcf7252d4862449fe0ae295e6c60a127315 >>> SecurityException in AnnotationInvocationHandler.getMemberMethods >>> Summary: Move call to getDeclaredMethods inside doPrivileged >>> Reviewed-by: >>> Contributed-by: jjb at google.com >>> >>> diff --git >>> a/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >>> >>> b/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >>> --- >>> a/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >>> +++ >>> b/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >>> @@ -272,14 +272,14 @@ >>> */ >>> private Method[] getMemberMethods() { >>> if (memberMethods == null) { >>> - final Method[] mm = type.getDeclaredMethods(); >>> - AccessController.doPrivileged(new PrivilegedAction() { >>> - public Void run() { >>> - AccessibleObject.setAccessible(mm, true); >>> - return null; >>> - } >>> - }); >>> - memberMethods = mm; >>> + memberMethods = AccessController.doPrivileged( >>> + new PrivilegedAction() { >>> + public Method[] run() { >>> + final Method[] mm = type.getDeclaredMethods(); >>> + AccessibleObject.setAccessible(mm, true); >>> + return mm; >>> + } >>> + }); >>> } >>> return memberMethods; >>> } >>> >> > > From Christopher.Hegarty at Sun.COM Wed Oct 22 08:11:03 2008 From: Christopher.Hegarty at Sun.COM (Christopher Hegarty - Sun Microsystems Ireland) Date: Wed, 22 Oct 2008 09:11:03 +0100 Subject: Is InputMap serializable or not? In-Reply-To: <212322090810211104x5526900cqf5917c5a017c6ad1@mail.gmail.com> References: <212322090810211104x5526900cqf5917c5a017c6ad1@mail.gmail.com> Message-ID: <48FEE017.3060105@sun.com> I think this observation is best directed to the swing-dev at openjdk.java.net alias since the issue seems to be in javax.swing.InputMap. -Chris. Paulo Levi wrote: > Hi. I found that the component input map advertises itself as > serializable, but it is really not, because somehow it seems to hold a > reference to a not serializable ActionMap. > > A test case, sorry about the write/read functions, they were copied > from a utility class (as you can see i had to replace the logging > class): > > > package ui; > > import java.io.BufferedInputStream; > import java.io.BufferedOutputStream; > import java.io.Closeable; > import java.io.FileInputStream; > import java.io.FileOutputStream; > import java.io.ObjectInputStream; > import java.io.ObjectOutputStream; > import java.io.Serializable; > import java.util.concurrent.Callable; > import java.util.logging.Level; > import java.util.logging.Logger; > import javax.swing.InputMap; > import javax.swing.JTextPane; > import javax.swing.KeyStroke; > import static junit.framework.Assert.*; > import org.junit.After; > import org.junit.AfterClass; > import org.junit.Before; > import org.junit.BeforeClass; > import org.junit.Test; > import util.io.IoUtils; > > > /** > * > * @author i30817 > */ > public class ApplicationTest { > > public ApplicationTest() { > } > > @BeforeClass > public static void setUpClass() throws Exception { > } > > @AfterClass > public static void tearDownClass() throws Exception { > } > > @Before > public void setUp() { > } > > @After > public void tearDown() { > } > > /** > * Test of read method, of class Application. > */ > @Test > public void testInputMapSerialization() { > JTextPane editor = new JTextPane(); > InputMap map = editor.getInputMap(); > KeyStroke keystroke = KeyStroke.getKeyStroke("shift SPACE"); > map.put(keystroke, "test"); > writeObjects("InputMap", map); > InputMap other = readObject("InputMap", new Callable(){ > > public Object call() throws Exception { > return new InputMap(); > } > > }); > > assertEquals("test", other.get(keystroke)); > > } > > /** > * If possible reads an object, if not tries to instanciate the > * object with the given Callable. This allows lazy instantiation. > * This funtion can only read 1 object per file, to allow encapsulation > * of the inputstreams. > * If an exception occurs in the lazy instantiation it returns null. > * Remember that if using Externalizable transient fields/static scopes > * fields ARE initalized. The use of the default constructor assures that. > * The order of inicialization is: > * Externalizable : default constructor, readExternal > * Serializable : first non-serializable super class default constructor, > * readObject > * So with externalizable you need to be carefull to replace the super state > * and not to use it in the default constructor. > * In serializable, you need to replace the constructor state. > */ > @SuppressWarnings(value = "unchecked") > public static T readObject(String objectLocation, Callable t) { > ObjectInputStream s = null; > try { > s = new ObjectInputStream(new BufferedInputStream(new > FileInputStream(objectLocation))); > return (T) s.readObject(); > } catch (Throwable ex) { > Logger.getLogger(IoUtils.class.getName()).log(Level.WARNING, > "Couldnt read object", ex); > if (t != null) { > try { > return (T) t.call(); > } catch (Throwable e) { > > Logger.getLogger(ApplicationTest.class.getName()).log(Level.SEVERE, > "Couldnt create object", e); > } > } > } finally { > close(s); > } > return null; > } > > /** > * If possible writes objects. Disallows null objects > */ > public static void writeObjects(String objectLocation, > Serializable... obj) { > ObjectOutputStream s = null; > try { > s = new ObjectOutputStream(new BufferedOutputStream(new > FileOutputStream(objectLocation))); > for (Serializable a : obj) { > if (a != null) { > s.writeObject(a); > } > } > s.flush(); > } catch (Throwable ex) { > Logger.getLogger(ApplicationTest.class.getName()).log(Level.SEVERE, > "Couldnt write object", ex); > } finally { > close(s); > } > } > > /** > * Close closeables. Use this in a finally clause. > */ > public static void close(Closeable... closeables) { > for (Closeable c : closeables) { > if (c != null) { > try { > c.close(); > } catch (Throwable ex) { > > Logger.getLogger(ApplicationTest.class.getName()).log(Level.WARNING, > "Couldnt close Closeable", ex); > } > } > } > } > } From Eamonn.McManus at Sun.COM Wed Oct 22 16:55:03 2008 From: Eamonn.McManus at Sun.COM (Eamonn McManus) Date: Wed, 22 Oct 2008 18:55:03 +0200 Subject: Maintenance Reviews was: [PATCH] Enhance ServiceLoader to understand factory methods In-Reply-To: References: <48F79C5D.6020802@sun.com> <20081017042413.F176D2C39D@callebaut.niobe.net> Message-ID: <48FF5AE7.8080500@sun.com> An HTML attachment was scrubbed... URL: From Joe.Darcy at Sun.COM Wed Oct 22 18:24:45 2008 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Wed, 22 Oct 2008 11:24:45 -0700 Subject: SecurityException in AnnotationInvocationHandler.getMemberMethods In-Reply-To: <1ccfd1c10810211758u10bfbbf7j2b8b4fcfb050ef20@mail.gmail.com> References: <1ccfd1c10810161246l51643ddfi7d13e094ad11ccb4@mail.gmail.com> <48FD376D.9080105@sun.com> <48FD37F3.9070208@sun.com> <1ccfd1c10810211758u10bfbbf7j2b8b4fcfb050ef20@mail.gmail.com> Message-ID: <48FF6FED.60900@sun.com> Martin Buchholz wrote: > If I had known when I started how hard it would be, > I would never have started writing one... > That is the case with many endeavors ;-) > Where are annotations tests supposed to go? > They seem under-test-covered. > I've put it into a new directory, test/java/lang/annotation > Recently I moved over the existing closed regression tests for annotations to test/java/lang/annotation: http://mail.openjdk.java.net/pipermail/jdk6-dev/2008-October/000231.html so I'll find a home for your tests in there. The newly-opened tests will be in the b13 source drop. Thanks, -Joe > Please review. The following fails with > current openjdk, passes with proposed fix. > > /* > * Copyright 2008 Sun Microsystems, Inc. All Rights Reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > * under the terms of the GNU General Public License version 2 only, as > * published by the Free Software Foundation. > * > * This code is distributed in the hope that it will be useful, but WITHOUT > * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > * version 2 for more details (a copy is included in the LICENSE file that > * accompanied this code). > * > * You should have received a copy of the GNU General Public License version > * 2 along with this work; if not, write to the Free Software Foundation, > * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. > * > * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, > * CA 95054 USA or visit www.sun.com if you need additional information or > * have any questions. > */ > > /* > * @test > * @bug 6761678 > * @summary Check properties of Annotations returned from > * getParameterAnnotations, including freedom from security > * exceptions. > * @author Martin Buchholz > */ > > import java.lang.annotation.Annotation; > import java.lang.annotation.ElementType; > import java.lang.annotation.Retention; > import java.lang.annotation.RetentionPolicy; > import java.lang.annotation.Target; > import java.lang.reflect.Method; > import java.security.Permission; > import java.security.Policy; > import java.security.ProtectionDomain; > > @Retention(RetentionPolicy.RUNTIME) > @Target({ ElementType.FIELD, ElementType.PARAMETER }) > @interface Named { > String value(); > } > > public class ParameterAnnotations { > > // A security policy that differs from the default only in that it > // allows a security manager to be uninstalled. > static class MyPolicy extends Policy { > final Policy defaultPolicy; > MyPolicy(Policy defaultPolicy) { > this.defaultPolicy = defaultPolicy; > } > public boolean implies(ProtectionDomain pd, Permission p) { > return p.getName().equals("setSecurityManager") || > defaultPolicy.implies(pd, p); > } > } > > public void nop(@Named("foo") Object foo, > @Named("bar") Object bar) { > } > > void test(String[] args) throws Throwable { > // Test without a security manager > test1(); > > // Test with a security manager > Policy defaultPolicy = Policy.getPolicy(); > Policy.setPolicy(new MyPolicy(defaultPolicy)); > System.setSecurityManager(new SecurityManager()); > try { > test1(); > } finally { > System.setSecurityManager(null); > Policy.setPolicy(defaultPolicy); > } > } > > void test1() throws Throwable { > for (Method m : thisClass.getMethods()) { > if (m.getName().equals("nop")) { > Annotation[][] ann = m.getParameterAnnotations(); > equal(ann.length, 2); > Annotation foo = ann[0][0]; > Annotation bar = ann[1][0]; > equal(foo.toString(), "@Named(value=foo)"); > equal(bar.toString(), "@Named(value=bar)"); > check(foo.equals(foo)); > check(! foo.equals(bar)); > } > } > } > > //--------------------- Infrastructure --------------------------- > volatile int passed = 0, failed = 0; > void pass() {passed++;} > void fail() {failed++; Thread.dumpStack();} > void fail(String msg) {System.err.println(msg); fail();} > void unexpected(Throwable t) {failed++; t.printStackTrace();} > void check(boolean cond) {if (cond) pass(); else fail();} > void equal(Object x, Object y) { > if (x == null ? y == null : x.equals(y)) pass(); > else fail(x + " not equal to " + y);} > static Class thisClass = new Object(){}.getClass().getEnclosingClass(); > public static void main(String[] args) throws Throwable { > try {thisClass.getMethod("instanceMain",String[].class) > .invoke(thisClass.newInstance(), (Object) args);} > catch (Throwable e) {throw e.getCause();}} > public void instanceMain(String[] args) throws Throwable { > try {test(args);} catch (Throwable t) {unexpected(t);} > System.out.printf("%nPassed = %d, failed = %d%n%n", passed, failed); > if (failed > 0) throw new AssertionError("Some tests failed");} > } > > Martin > > On Mon, Oct 20, 2008 at 19:01, Joe Darcy wrote: > >> PS Martin, I haven't written tests that setup and use a security manager, >> etc., that should go along with this fix. Having a stand-alone regression >> test along those lines would be helpful. >> >> Thanks, >> >> -Joe >> >> On 10/20/08 06:59 PM, Joe Darcy wrote: >> >>> Hello. >>> >>> On 10/16/08 12:46 PM, Martin Buchholz wrote: >>> >>>> Hi all, >>>> >>>> This is a bug report with fix. >>>> Joe Darcy, please file a bug and review this change, >>>> >>>> >>> I've filed 6761678 "(ann) SecurityException in >>> AnnotationInvocationHandler.getMemberMethods" for this issue. The problem >>> seems similar to 6370080 "(ann) Method.getAnnotations() sometimes throw >>> SecurityException: doPrivileged or javadoc missing?," which was fixed in JDK >>> 6 and a JDK 5 update release. >>> >>> Martin, can you, Toby, and Josh review any other uses of reflection in the >>> src/share/classes/sun/reflect/annotation package for similar problems so we >>> can address any other such issues now? >>> >>> I've looked over the change and the use of getMemberMethods in equalsImpl >>> and don't see a problem. However, I'd like the security team to give it a >>> once over too; security-dev folk, please take a look at this. >>> >>> Thanks, >>> >>> -Joe >>> >>>> and perhaps provide a small test case (it is impractical >>>> to share the test we have at Google). >>>> >>>> Description: >>>> >>>> sun/reflect/annotation/AnnotationInvocationHandler.java.getMemberMethods >>>> might throw if there is a security manager that does not allow >>>> getDeclaredMethods. >>>> >>>> The author of this code (Josh Bloch) confirms that the intent was for the >>>> doPrivileged block in this method to prevent security exceptions. >>>> The methods cannot escape to untrusted code. >>>> >>>> Evaluation: >>>> >>>> Yes. Fix provided courtesy of Toby Reyelts and Josh Bloch at Google. >>>> >>>> # HG changeset patch >>>> # User martin >>>> # Date 1224185752 25200 >>>> # Node ID 68730f05449cd4f39ce1cb82adc6c4e57f87554f >>>> # Parent 214ebdcf7252d4862449fe0ae295e6c60a127315 >>>> SecurityException in AnnotationInvocationHandler.getMemberMethods >>>> Summary: Move call to getDeclaredMethods inside doPrivileged >>>> Reviewed-by: >>>> Contributed-by: jjb at google.com >>>> >>>> diff --git >>>> a/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >>>> >>>> b/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >>>> --- >>>> a/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >>>> +++ >>>> b/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >>>> @@ -272,14 +272,14 @@ >>>> */ >>>> private Method[] getMemberMethods() { >>>> if (memberMethods == null) { >>>> - final Method[] mm = type.getDeclaredMethods(); >>>> - AccessController.doPrivileged(new PrivilegedAction() { >>>> - public Void run() { >>>> - AccessibleObject.setAccessible(mm, true); >>>> - return null; >>>> - } >>>> - }); >>>> - memberMethods = mm; >>>> + memberMethods = AccessController.doPrivileged( >>>> + new PrivilegedAction() { >>>> + public Method[] run() { >>>> + final Method[] mm = type.getDeclaredMethods(); >>>> + AccessibleObject.setAccessible(mm, true); >>>> + return mm; >>>> + } >>>> + }); >>>> } >>>> return memberMethods; >>>> } >>>> >>>> >> From Joe.Darcy at Sun.COM Thu Oct 23 17:02:01 2008 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Thu, 23 Oct 2008 10:02:01 -0700 Subject: SecurityException in AnnotationInvocationHandler.getMemberMethods In-Reply-To: <48FF6FED.60900@sun.com> References: <1ccfd1c10810161246l51643ddfi7d13e094ad11ccb4@mail.gmail.com> <48FD376D.9080105@sun.com> <48FD37F3.9070208@sun.com> <1ccfd1c10810211758u10bfbbf7j2b8b4fcfb050ef20@mail.gmail.com> <48FF6FED.60900@sun.com> Message-ID: <4900AE09.1010207@sun.com> Joseph D. Darcy wrote: > Martin Buchholz wrote: >> If I had known when I started how hard it would be, >> I would never have started writing one... >> > > That is the case with many endeavors ;-) > >> Where are annotations tests supposed to go? >> They seem under-test-covered. >> I've put it into a new directory, test/java/lang/annotation >> > > Recently I moved over the existing closed regression tests for > annotations to test/java/lang/annotation: > > http://mail.openjdk.java.net/pipermail/jdk6-dev/2008-October/000231.html > so I'll find a home for your tests in there. The newly-opened tests > will be in the b13 source drop. Martin, I've reviewed your test and code and Sean Mullan has reviewed the code too. I verified the test fails with the current build and passes with change. I've putback the code changes and test into OpenJDK 6 b13. The test lives at test/java/lang/annotations/ParameterAnnotations.java; the other annotation tests will go in that directory once I move them over in JDK 7 too. I think you're clear to commit this fix to the JDK 7 repository too. -Joe > > Thanks, > > -Joe > >> Please review. The following fails with >> current openjdk, passes with proposed fix. >> >> /* >> * Copyright 2008 Sun Microsystems, Inc. All Rights Reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> * under the terms of the GNU General Public License version 2 only, as >> * published by the Free Software Foundation. >> * >> * This code is distributed in the hope that it will be useful, but >> WITHOUT >> * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License >> * version 2 for more details (a copy is included in the LICENSE file >> that >> * accompanied this code). >> * >> * You should have received a copy of the GNU General Public License >> version >> * 2 along with this work; if not, write to the Free Software >> Foundation, >> * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. >> * >> * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa >> Clara, >> * CA 95054 USA or visit www.sun.com if you need additional >> information or >> * have any questions. >> */ >> >> /* >> * @test >> * @bug 6761678 >> * @summary Check properties of Annotations returned from >> * getParameterAnnotations, including freedom from security >> * exceptions. >> * @author Martin Buchholz >> */ >> >> import java.lang.annotation.Annotation; >> import java.lang.annotation.ElementType; >> import java.lang.annotation.Retention; >> import java.lang.annotation.RetentionPolicy; >> import java.lang.annotation.Target; >> import java.lang.reflect.Method; >> import java.security.Permission; >> import java.security.Policy; >> import java.security.ProtectionDomain; >> >> @Retention(RetentionPolicy.RUNTIME) >> @Target({ ElementType.FIELD, ElementType.PARAMETER }) >> @interface Named { >> String value(); >> } >> >> public class ParameterAnnotations { >> >> // A security policy that differs from the default only in that it >> // allows a security manager to be uninstalled. >> static class MyPolicy extends Policy { >> final Policy defaultPolicy; >> MyPolicy(Policy defaultPolicy) { >> this.defaultPolicy = defaultPolicy; >> } >> public boolean implies(ProtectionDomain pd, Permission p) { >> return p.getName().equals("setSecurityManager") || >> defaultPolicy.implies(pd, p); >> } >> } >> >> public void nop(@Named("foo") Object foo, >> @Named("bar") Object bar) { >> } >> >> void test(String[] args) throws Throwable { >> // Test without a security manager >> test1(); >> >> // Test with a security manager >> Policy defaultPolicy = Policy.getPolicy(); >> Policy.setPolicy(new MyPolicy(defaultPolicy)); >> System.setSecurityManager(new SecurityManager()); >> try { >> test1(); >> } finally { >> System.setSecurityManager(null); >> Policy.setPolicy(defaultPolicy); >> } >> } >> >> void test1() throws Throwable { >> for (Method m : thisClass.getMethods()) { >> if (m.getName().equals("nop")) { >> Annotation[][] ann = m.getParameterAnnotations(); >> equal(ann.length, 2); >> Annotation foo = ann[0][0]; >> Annotation bar = ann[1][0]; >> equal(foo.toString(), "@Named(value=foo)"); >> equal(bar.toString(), "@Named(value=bar)"); >> check(foo.equals(foo)); >> check(! foo.equals(bar)); >> } >> } >> } >> >> //--------------------- Infrastructure --------------------------- >> volatile int passed = 0, failed = 0; >> void pass() {passed++;} >> void fail() {failed++; Thread.dumpStack();} >> void fail(String msg) {System.err.println(msg); fail();} >> void unexpected(Throwable t) {failed++; t.printStackTrace();} >> void check(boolean cond) {if (cond) pass(); else fail();} >> void equal(Object x, Object y) { >> if (x == null ? y == null : x.equals(y)) pass(); >> else fail(x + " not equal to " + y);} >> static Class thisClass = new >> Object(){}.getClass().getEnclosingClass(); >> public static void main(String[] args) throws Throwable { >> try {thisClass.getMethod("instanceMain",String[].class) >> .invoke(thisClass.newInstance(), (Object) args);} >> catch (Throwable e) {throw e.getCause();}} >> public void instanceMain(String[] args) throws Throwable { >> try {test(args);} catch (Throwable t) {unexpected(t);} >> System.out.printf("%nPassed = %d, failed = %d%n%n", passed, failed); >> if (failed > 0) throw new AssertionError("Some tests failed");} >> } >> >> Martin >> >> On Mon, Oct 20, 2008 at 19:01, Joe Darcy wrote: >> >>> PS Martin, I haven't written tests that setup and use a security >>> manager, >>> etc., that should go along with this fix. Having a stand-alone >>> regression >>> test along those lines would be helpful. >>> >>> Thanks, >>> >>> -Joe >>> >>> On 10/20/08 06:59 PM, Joe Darcy wrote: >>> >>>> Hello. >>>> >>>> On 10/16/08 12:46 PM, Martin Buchholz wrote: >>>> >>>>> Hi all, >>>>> >>>>> This is a bug report with fix. >>>>> Joe Darcy, please file a bug and review this change, >>>>> >>>>> >>>> I've filed 6761678 "(ann) SecurityException in >>>> AnnotationInvocationHandler.getMemberMethods" for this issue. The >>>> problem >>>> seems similar to 6370080 "(ann) Method.getAnnotations() sometimes >>>> throw >>>> SecurityException: doPrivileged or javadoc missing?," which was >>>> fixed in JDK >>>> 6 and a JDK 5 update release. >>>> >>>> Martin, can you, Toby, and Josh review any other uses of reflection >>>> in the >>>> src/share/classes/sun/reflect/annotation package for similar >>>> problems so we >>>> can address any other such issues now? >>>> >>>> I've looked over the change and the use of getMemberMethods in >>>> equalsImpl >>>> and don't see a problem. However, I'd like the security team to >>>> give it a >>>> once over too; security-dev folk, please take a look at this. >>>> >>>> Thanks, >>>> >>>> -Joe >>>> >>>>> and perhaps provide a small test case (it is impractical >>>>> to share the test we have at Google). >>>>> >>>>> Description: >>>>> >>>>> sun/reflect/annotation/AnnotationInvocationHandler.java.getMemberMethods >>>>> >>>>> might throw if there is a security manager that does not allow >>>>> getDeclaredMethods. >>>>> >>>>> The author of this code (Josh Bloch) confirms that the intent was >>>>> for the >>>>> doPrivileged block in this method to prevent security exceptions. >>>>> The methods cannot escape to untrusted code. >>>>> >>>>> Evaluation: >>>>> >>>>> Yes. Fix provided courtesy of Toby Reyelts and Josh Bloch at Google. >>>>> >>>>> # HG changeset patch >>>>> # User martin >>>>> # Date 1224185752 25200 >>>>> # Node ID 68730f05449cd4f39ce1cb82adc6c4e57f87554f >>>>> # Parent 214ebdcf7252d4862449fe0ae295e6c60a127315 >>>>> SecurityException in AnnotationInvocationHandler.getMemberMethods >>>>> Summary: Move call to getDeclaredMethods inside doPrivileged >>>>> Reviewed-by: >>>>> Contributed-by: jjb at google.com >>>>> >>>>> diff --git >>>>> a/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >>>>> >>>>> >>>>> b/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >>>>> >>>>> --- >>>>> a/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >>>>> >>>>> +++ >>>>> b/src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java >>>>> >>>>> @@ -272,14 +272,14 @@ >>>>> */ >>>>> private Method[] getMemberMethods() { >>>>> if (memberMethods == null) { >>>>> - final Method[] mm = type.getDeclaredMethods(); >>>>> - AccessController.doPrivileged(new >>>>> PrivilegedAction() { >>>>> - public Void run() { >>>>> - AccessibleObject.setAccessible(mm, true); >>>>> - return null; >>>>> - } >>>>> - }); >>>>> - memberMethods = mm; >>>>> + memberMethods = AccessController.doPrivileged( >>>>> + new PrivilegedAction() { >>>>> + public Method[] run() { >>>>> + final Method[] mm = >>>>> type.getDeclaredMethods(); >>>>> + AccessibleObject.setAccessible(mm, true); >>>>> + return mm; >>>>> + } >>>>> + }); >>>>> } >>>>> return memberMethods; >>>>> } >>>>> >>>>> >>> > From maurizio.cimadamore at sun.com Thu Oct 23 17:33:10 2008 From: maurizio.cimadamore at sun.com (maurizio.cimadamore at sun.com) Date: Thu, 23 Oct 2008 17:33:10 +0000 Subject: hg: jdk7/tl/langtools: 5 new changesets Message-ID: <20081023173320.0765AD99E@hg.openjdk.java.net> Changeset: 6508d7e812e1 Author: mcimadamore Date: 2008-10-23 17:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6508d7e812e1 6732484: Bound error on wildcard code Summary: Check.checkExtends should cope with captured type-variables Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/wildcards/T6732484.java Changeset: 4d2d8b6459e1 Author: mcimadamore Date: 2008-10-23 17:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4d2d8b6459e1 6711619: javac doesn't allow access to protected members in intersection types Summary: Accordingly to new accessibility rules all members of intersection types (but private ones) should be accessible Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/generics/6531090/T6531090b.java + test/tools/javac/generics/6711619/T6711619a.java + test/tools/javac/generics/6711619/T6711619a.out + test/tools/javac/generics/6711619/T6711619b.java + test/tools/javac/generics/6711619/T6711619b.out Changeset: db77bf6adb53 Author: mcimadamore Date: 2008-10-23 18:00 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/db77bf6adb53 6487370: javac incorrectly gives ambiguity warning with override-equivalent abstract inherited methods Summary: Javac should not compare erased return types when checking for ambiguity errors during overload resolution Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/generics/6487370/T6487370.java Changeset: 433ee48257c0 Author: mcimadamore Date: 2008-10-23 18:10 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/433ee48257c0 6548436: Incorrect inconvertible types error Summary: Types.rewrite quantifiers should cope with captured type-variables properly Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/cast/6548436/T6548436a.java + test/tools/javac/cast/6548436/T6548436b.java + test/tools/javac/cast/6548436/T6548436c.java + test/tools/javac/cast/6548436/T6548436d.java Changeset: c6e3fc6dda61 Author: mcimadamore Date: 2008-10-23 18:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c6e3fc6dda61 6557954: Inner class type parameters doesn't get substituted when checking type well-formedness Summary: Validator.visitTypeApply should substitute all formal typevars with actual parameters Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/T6557954.java From ole.ersoy at gmail.com Thu Oct 23 18:14:54 2008 From: ole.ersoy at gmail.com (Ole Ersoy) Date: Thu, 23 Oct 2008 13:14:54 -0500 Subject: Is sun.net.www.protocol.jar.JarURLConnection Supported? Message-ID: <4900BF1E.7030106@gmail.com> Hi, I hope this is the right list. Just wondering whether sun.net.www.protocol.jar.JarURLConnection is supported by OpenJDK. I'm using java-1.7.0-icedtea, and when loading resources with weblets (https://weblets.dev.java.net) occasionally I get the exception: java.io.FileNotFoundException: JAR entry resources/v120/dojo/runner.js not found in /var/lib/tomcat/webapps/dojo.webapp/WEB-INF/lib/dojo-1.2.0.jar sun.net.www.protocol.jar.JarURLConnection.connect(JarURLConnection.java:140) I'll post the summary posted on weblet's dev mailing list below in case it's interesting. Thanks, - Ole SUMMARY OF WHAT WORKS AND WHAT DOES NOT: This url works: http://localhost/dojo.webapp/resources/javascript/dojo/dojo.js I also sampled loading resources from dojox and dijit and those work as well. However this one does not: http://localhost/dojo.webapp/resources/javascript/util/doh/runner.js I opened up the deployed jar in konquerer: /var/lib/tomcat/webapps/dojo.webapp/WEB-INF/lib/dojo-1.2.0.jar Just to double check that runner.js is where it should be and it is. Another weird thing. I copied runner.js into the dojo directory and tried this: http://localhost/dojo.webapp/resources/javascript/dojo/runner.js That also results in a: ======================================================================== java.io.FileNotFoundException: JAR entry resources/v120/dojo/runner.js not found in /var/lib/tomcat/webapps/dojo.webapp/WEB-INF/lib/dojo-1.2.0.jar sun.net.www.protocol.jar.JarURLConnection.connect(JarURLConnection.java:140) ======================================================================== Another thing. If I try to load a non existing resource like this: http://localhost/dojo.webapp/resources/javascript/nonexistingresource.js I just get a 404 saying this: ======================================================================== HTTP Status 404 - type Status report message description The requested resource () is not available. ======================================================================== From Alan.Bateman at Sun.COM Thu Oct 23 18:38:08 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Thu, 23 Oct 2008 19:38:08 +0100 Subject: Is sun.net.www.protocol.jar.JarURLConnection Supported? In-Reply-To: <4900BF1E.7030106@gmail.com> References: <4900BF1E.7030106@gmail.com> Message-ID: <4900C490.1070209@sun.com> Ole Ersoy wrote: > Hi, > > I hope this is the right list. Just wondering whether > sun.net.www.protocol.jar.JarURLConnection is supported by OpenJDK. In the URL spec it lists the protocol handlers that are required to be present. The "jar" protocol is required (and JarURLConnection is the implementation). The net-dev at openjdk.java.net mailing list is where this code is developed and maintained. You also also find help in the networking forum on java.sun.com. -Alan. From Jaroslav.Tulach at Sun.COM Thu Oct 23 06:31:49 2008 From: Jaroslav.Tulach at Sun.COM (Jaroslav Tulach) Date: Thu, 23 Oct 2008 08:31:49 +0200 Subject: Maintenance Reviews was: [PATCH] Enhance ServiceLoader to understand factory methods In-Reply-To: <48FF5AE7.8080500@sun.com> References: <48F79C5D.6020802@sun.com> <48FF5AE7.8080500@sun.com> Message-ID: <200810230831.49658.jaroslav.tulach@sun.com> Dne Wednesday 22 October 2008 18:55:03 Eamonn McManus napsal(a): > Jaroslav, > > I can act as sponsor for this change. Excellent. I'll prepare better description of the change over the weekend. Thanks. -jst > > My understanding from looking at the code is that the change is as follows. > Today, you can supply an implementation of the SPI com.example.Foo by > putting a jar file in the classpath (etc) that contains a file called > META-INF/services/com.example.Foo which might contain lines like: > > com.example.providers.Bar > > To instantiate this provider, ServiceLoader loads the class > com.example.providers.Bar and instantiates its public no-arg constructor. > The Bar class must be a subtype of com.example.Foo. > > With your proposed change, the above will still be possible, but > additionally the file can contain lines like: > > com.example.providers.Bar.baz() > > To instantiate this provider, ServiceLoader loads the class > com.example.providers.Bar and calls its public static method baz(). The Bar > class does not have to be a subtype of com.example.Foo but the return type > of baz() does. > > Can you say a bit more about the rationale here? I understand why SPIs > should be defined with abstract classes rather than interfaces, but > ServiceLoader already supports both classes and interfaces. I can see why > final classes might be of interest (so you can add new methods without > fearing a clash with an existing subclass method name), and I guess you > have in mind that such classes could have their behaviour defined via > constructor parameters, with each new version adding a new constructor; but > rather than guessing it would be nice to see an example. > > Regards, > > ?amonn McManus ? JMX Spec Lead ? http://weblogs.java.net/blog/emcmanus > > > Jaroslav Tulach wrote: > Thanks for the clarification, Mark. I've heard about some umbrella JSR for > each release of the JDK before and I was hoping that my proposed change > could be covered as part of it. Thanks for confirming that such aggregation > is possible. > > > With regard to this particular proposal, as the original author of ... > > > OK, I can promise that I will work hard on polishing my proposal. I can > improve the code, I can add more documentation, I can write more tests, > change the new API semantics, etc. I just need a sponsor to tell me what to > change and where and then take and apply my final patch. > > Thanks in advance for your help. > -jst > > Dne Friday 17 October 2008 06:24:13 Mark Reinhold napsal(a): > > Date: Fri, 17 Oct 2008 05:56:13 +1000 > From: david.holmes at sun.com > > If this is a modification to the API not just a patch for the > implementation then the short answer is No. > > Well, not exactly. > > > ????????????????????????????????????? ? ? ?API changes have to be made > via a JSR. > > ... or in a Maintenance Review of an existing JSR. > > Small API revisions and additions do not require their own JSR; that > would be ridiculously inefficient. ?Instead we roll them up into a > series of Maintenance Reviews of the previous Platform JSR [1]. > > There have already been many small API changes in the JDK 7 codebase. > Suggested patches for further such changes are welcome, and will be > discussed and judged on their own technical merit. ?All implemented > changes will, in due course, be aggregated into an appropriate JCP > Maintenance Review. > > With regard to this particular proposal, as the original author of > the class in question I suppose I should have an opinion about it, > but that's a topic for a different message. > > - Mark > > > [1] > > > http://weblogs.java.net/blog/mreinhold/archive/2006/03/mustang_mainten.html From maurizio.cimadamore at sun.com Fri Oct 24 11:51:10 2008 From: maurizio.cimadamore at sun.com (maurizio.cimadamore at sun.com) Date: Fri, 24 Oct 2008 11:51:10 +0000 Subject: hg: jdk7/tl/langtools: 4 new changesets Message-ID: <20081024115118.BC5A7DABC@hg.openjdk.java.net> Changeset: 5e54a59bcee7 Author: mcimadamore Date: 2008-10-24 12:45 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5e54a59bcee7 6680106: StackOverFlowError for Cyclic inheritance in TypeParameters with ArrayType Bounds Summary: Javac ends up in an infinite loop while attributing mutually referring array type-parameter bounds Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/generics/typevars/6680106/T6680106.java + test/tools/javac/generics/typevars/6680106/T6680106.out Changeset: a23e1dc02698 Author: mcimadamore Date: 2008-10-24 12:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a23e1dc02698 6746184: javac fails to compile call to public varargs method Summary: javac's resolution process should go through all steps described in JLS 15.12.2.2 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/varargs/T6746184.java Changeset: ddd75a295501 Author: mcimadamore Date: 2008-10-24 12:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ddd75a295501 6758789: Some method resolution diagnostic should be improved Summary: Recent work on diagnostics left out some resolution corner cases Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/Formattable.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/6758789/T6758789a.java + test/tools/javac/6758789/T6758789a.out + test/tools/javac/6758789/T6758789b.java + test/tools/javac/6758789/T6758789b.out ! test/tools/javac/generics/inference/6718364/T6718364.out Changeset: 638d45788c9e Author: mcimadamore Date: 2008-10-24 12:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/638d45788c9e 6762569: Javac crashes with AssertionError in Types.containedBy Summary: Types.containedBy should be more liberal with UndetVars Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java - test/tools/javac/generics/wildcards/6651719/T6651719b.java + test/tools/javac/generics/wildcards/6762569/T6762569a.java + test/tools/javac/generics/wildcards/6762569/T6762569b.java From martinrb at google.com Sat Oct 25 03:40:33 2008 From: martinrb at google.com (martinrb at google.com) Date: Sat, 25 Oct 2008 03:40:33 +0000 Subject: hg: jdk7/tl/jdk: 6761678: (ann) SecurityException in AnnotationInvocationHandler.getMemberMethods Message-ID: <20081025034106.0E556DB03@hg.openjdk.java.net> Changeset: 64da1f751c0f Author: martin Date: 2008-10-24 20:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/64da1f751c0f 6761678: (ann) SecurityException in AnnotationInvocationHandler.getMemberMethods Summary: Move call to getDeclaredMethods inside doPrivileged Reviewed-by: darcy, mullan Contributed-by: jjb at google.com ! src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java + test/java/lang/annotation/ParameterAnnotations.java From rdifalco at tripwire.com Sat Oct 25 16:37:35 2008 From: rdifalco at tripwire.com (Robert DiFalco) Date: Sat, 25 Oct 2008 09:37:35 -0700 Subject: RMI DGC questions Message-ID: <1C21C32F5F592D48B16F28C7877D9BC10370DB84@SVMAIL01.tripwire.com> I'm thinking of making a change but wanted to gather some background first. I would like to change DGC so that all sockets will uses a single thread and reference queue. When there is work to be done, only then will that work be sent to a thread pool. My big question is, why hasn't this been done before? It appears to be a relatively simple change to make that would result in saving a thread per connection? People are always complaining about these renew clean threads and they really cut down on scalability, so I want to find out what has prevented people from making this change in the past to make sure I am not overlooking something. Also, is there a straight forward soup to nuts article on downloading, modifying code, building, testing, and submitting the change for the core libraries? Do I have to build everything or is there a way to just build my effected jars and use binary plugs so that I don't have to rebuild native code? Can I just copy that rebuilt jar over to my JRE in order to test? TIA, Robert From tim.bell at sun.com Sun Oct 26 04:32:10 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 26 Oct 2008 04:32:10 +0000 Subject: hg: jdk7/tl: Added tag jdk7-b38 for changeset cc47a76899ed Message-ID: <20081026043210.5B811DB38@hg.openjdk.java.net> Changeset: ab523b49de1f Author: xdono Date: 2008-10-23 10:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/ab523b49de1f Added tag jdk7-b38 for changeset cc47a76899ed ! .hgtags From tim.bell at sun.com Sun Oct 26 04:33:36 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 26 Oct 2008 04:33:36 +0000 Subject: hg: jdk7/tl/corba: 3 new changesets Message-ID: <20081026043339.9F2F3DB3D@hg.openjdk.java.net> Changeset: a067bf2329ef Author: tbell Date: 2008-10-15 21:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/a067bf2329ef 6759959: VS2008 errors compiling corba sources Summary: Update Makefiles to deal with newer Visual Studio releases Reviewed-by: ohair ! make/common/Defs-windows.gmk ! make/common/shared/Compiler-msvc.gmk Changeset: 08be802754b0 Author: xdono Date: 2008-10-16 10:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/08be802754b0 Merge Changeset: 55078b6661e2 Author: xdono Date: 2008-10-23 10:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/55078b6661e2 Added tag jdk7-b38 for changeset 08be802754b0 ! .hgtags From tim.bell at sun.com Sun Oct 26 04:36:05 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 26 Oct 2008 04:36:05 +0000 Subject: hg: jdk7/tl/hotspot: Added tag jdk7-b38 for changeset d9bc824aa078 Message-ID: <20081026043609.339E8DB42@hg.openjdk.java.net> Changeset: 69e855d955f5 Author: xdono Date: 2008-10-23 10:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/69e855d955f5 Added tag jdk7-b38 for changeset d9bc824aa078 ! .hgtags From tim.bell at sun.com Sun Oct 26 04:39:14 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 26 Oct 2008 04:39:14 +0000 Subject: hg: jdk7/tl/jaxp: Added tag jdk7-b38 for changeset e9f750f0a3a0 Message-ID: <20081026043916.5550DDB47@hg.openjdk.java.net> Changeset: 831b80be6cea Author: xdono Date: 2008-10-23 10:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/831b80be6cea Added tag jdk7-b38 for changeset e9f750f0a3a0 ! .hgtags From tim.bell at sun.com Sun Oct 26 04:41:19 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 26 Oct 2008 04:41:19 +0000 Subject: hg: jdk7/tl/jaxws: Added tag jdk7-b38 for changeset 9ce439969184 Message-ID: <20081026044121.3BCF2DB4C@hg.openjdk.java.net> Changeset: 077bc9b1b035 Author: xdono Date: 2008-10-23 10:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/077bc9b1b035 Added tag jdk7-b38 for changeset 9ce439969184 ! .hgtags From tim.bell at sun.com Sun Oct 26 05:04:24 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 26 Oct 2008 05:04:24 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20081026050509.116EEDB6E@hg.openjdk.java.net> Changeset: dcd40f60ffd3 Author: xdono Date: 2008-10-23 10:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dcd40f60ffd3 Added tag jdk7-b38 for changeset cc5f810b5af8 ! .hgtags Changeset: 4e51997582ef Author: tbell Date: 2008-10-23 21:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4e51997582ef Merge Changeset: 1a324821b463 Author: tbell Date: 2008-10-24 20:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1a324821b463 Merge From tim.bell at sun.com Sun Oct 26 05:06:41 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 26 Oct 2008 05:06:41 +0000 Subject: hg: jdk7/tl/langtools: 3 new changesets Message-ID: <20081026050648.86430DB73@hg.openjdk.java.net> Changeset: c7315642fa1b Author: xdono Date: 2008-10-23 10:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c7315642fa1b Added tag jdk7-b38 for changeset 3fd42dfa6f27 ! .hgtags Changeset: 3fb51e47622b Author: tbell Date: 2008-10-23 21:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3fb51e47622b Merge Changeset: 8d7fa40da0eb Author: tbell Date: 2008-10-24 20:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8d7fa40da0eb Merge - test/tools/javac/generics/wildcards/6651719/T6651719b.java From eamonn.mcmanus at sun.com Mon Oct 27 13:05:59 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Mon, 27 Oct 2008 13:05:59 +0000 Subject: hg: jdk7/tl/jdk: 6763639: Remove "rawtypes" warnings from JMX code Message-ID: <20081027130621.4E826DB9E@hg.openjdk.java.net> Changeset: 76ecb928e83a Author: emcmanus Date: 2008-10-27 14:02 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/76ecb928e83a 6763639: Remove "rawtypes" warnings from JMX code Reviewed-by: dfuchs ! make/netbeans/jmx/build.xml ! src/share/classes/com/sun/jmx/event/LeaseManager.java ! src/share/classes/com/sun/jmx/event/LeaseRenewer.java ! src/share/classes/com/sun/jmx/interceptor/DefaultMBeanServerInterceptor.java ! src/share/classes/com/sun/jmx/mbeanserver/ClassLoaderRepositorySupport.java ! src/share/classes/com/sun/jmx/mbeanserver/ConvertingMethod.java ! src/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java ! src/share/classes/com/sun/jmx/mbeanserver/JmxMBeanServer.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanInstantiator.java ! src/share/classes/com/sun/jmx/mbeanserver/MXBeanIntrospector.java ! src/share/classes/com/sun/jmx/mbeanserver/ObjectInputStreamWithLoader.java ! src/share/classes/com/sun/jmx/mbeanserver/SecureClassLoaderRepository.java ! src/share/classes/com/sun/jmx/mbeanserver/Util.java ! src/share/classes/com/sun/jmx/mbeanserver/WeakIdentityHashMap.java ! src/share/classes/com/sun/jmx/remote/internal/ArrayNotificationBuffer.java ! src/share/classes/com/sun/jmx/remote/internal/ClientNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/internal/ProxyInputStream.java ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/internal/Unmarshal.java ! src/share/classes/com/sun/jmx/remote/security/FileLoginModule.java ! src/share/classes/com/sun/jmx/remote/security/JMXPluggableAuthenticator.java ! src/share/classes/com/sun/jmx/remote/security/MBeanServerFileAccessController.java ! src/share/classes/com/sun/jmx/remote/util/ClassLoaderWithRepository.java ! src/share/classes/com/sun/jmx/remote/util/ClassLogger.java ! src/share/classes/com/sun/jmx/remote/util/EnvHelp.java ! src/share/classes/com/sun/jmx/remote/util/EventClientConnection.java ! src/share/classes/com/sun/jmx/remote/util/OrderClassLoaders.java ! src/share/classes/javax/management/AttributeList.java ! src/share/classes/javax/management/DefaultLoaderRepository.java ! src/share/classes/javax/management/JMRuntimeException.java ! src/share/classes/javax/management/JMX.java ! src/share/classes/javax/management/MBeanAttributeInfo.java ! src/share/classes/javax/management/MBeanConstructorInfo.java ! src/share/classes/javax/management/MBeanInfo.java ! src/share/classes/javax/management/MBeanOperationInfo.java ! src/share/classes/javax/management/MBeanServerFactory.java ! src/share/classes/javax/management/MBeanServerInvocationHandler.java ! src/share/classes/javax/management/StandardMBean.java ! src/share/classes/javax/management/event/EventClientDelegate.java ! src/share/classes/javax/management/event/EventSubscriber.java ! src/share/classes/javax/management/loading/DefaultLoaderRepository.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/javax/management/loading/MLetObjectInputStream.java ! src/share/classes/javax/management/modelmbean/DescriptorSupport.java ! src/share/classes/javax/management/modelmbean/ModelMBeanConstructorInfo.java ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/javax/management/openmbean/ArrayType.java ! src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java ! src/share/classes/javax/management/openmbean/CompositeType.java ! src/share/classes/javax/management/openmbean/OpenMBeanAttributeInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenMBeanParameterInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenType.java ! src/share/classes/javax/management/openmbean/SimpleType.java ! src/share/classes/javax/management/openmbean/TabularDataSupport.java ! src/share/classes/javax/management/openmbean/TabularType.java ! src/share/classes/javax/management/relation/MBeanServerNotificationFilter.java ! src/share/classes/javax/management/relation/RelationService.java ! src/share/classes/javax/management/relation/RelationSupport.java ! src/share/classes/javax/management/relation/Role.java ! src/share/classes/javax/management/relation/RoleList.java ! src/share/classes/javax/management/relation/RoleResult.java ! src/share/classes/javax/management/relation/RoleUnresolved.java ! src/share/classes/javax/management/relation/RoleUnresolvedList.java ! src/share/classes/javax/management/remote/JMXConnectorFactory.java ! src/share/classes/javax/management/remote/rmi/NoCallStackClassLoader.java ! src/share/classes/javax/management/remote/rmi/RMIConnection.java ! src/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/share/classes/javax/management/remote/rmi/RMIServerImpl.java ! src/share/classes/javax/management/timer/Timer.java From jaroslav.tulach at sun.com Mon Oct 27 16:12:35 2008 From: jaroslav.tulach at sun.com (Jaroslav Tulach) Date: Mon, 27 Oct 2008 17:12:35 +0100 Subject: Maintenance Reviews was: [PATCH] Enhance ServiceLoader to understand factory methods References: <48F79C5D.6020802@sun.com> <20081017042413.F176D2C39D@callebaut.niobe.net> <48FF5AE7.8080500@sun.com> Message-ID: Eamonn McManus wrote: >

I can act as sponsor for this change.
Excellent, thanks Eamonn. > Can you say a bit more about the rationale here? I understand why > SPIs should be defined with abstract classes rather than interfaces, > but ServiceLoader already supports both classes and interfaces. I want to provide a compatible addition to existing behaviour. As such, what used to work can still continue to be used. > I can > see why final classes might be of interest (so you can add new methods > without fearing a clash with an existing subclass method name), One of the things that NetBeans learned in the past is that API for clients shall be separated from the API for providers to simplify classes/interfaces evolution. This is not really easy to do with current ServiceLoader design. TheService class in visible to both, the providers (obviously) as well as clients (everyone can call ServiceLoader.load(TheService.class)). This makes TheService class evolution tricky. We are usually workarounding the problem just like in case of FileOwnerQuery (the API for clients) and FileOwnerQueryImplementation (this is the service class): http://bits.netbeans.org/dev/javadoc/org-netbeans-modules-projectapi/org/netbeans/api/project/FileOwnerQuery.html http://bits.netbeans.org/dev/javadoc/org-netbeans-modules-projectapi/org/netbeans/spi/project/FileOwnerQueryImplementation.html However this is not bulletproof, malicious client code can access FileOwnerQueryImplementation directly. With the enhanced ServiceLoader this could be eliminated: public final class FileOwnerQuery { public static FileOwnerQuery create(Implementation impl) { return ...; } public static Project getOwner(URI uri) { for (FileOwnerQuery q : ServiceLoader.load(FileOwnerQuery.class).iterator()) { // do something with q } } public interface Implementation { // some methods for the provider } } Then people providing some implementation could: public final class MyFileOwnerQueryImpl implements FileOwnerQuery.Implementation { public static getDefault() { return FileOwnerQuery.create(new MyFileOwnerQueryImpl()); } // some methods implemented } and in META-INF/services/org.nb.FileOwnerQuery have: com.mymodule.MyFileOwnerQueryImpl.getDefault() This may not sound like a big improvement and it really is not for the first version. However, as soon as you find out that the Implementation interface is completely wrong you can add: public final class FileOwnerQuery { public static FileOwnerQuery create(DifferentImplementation impl) { return ...; } public interface DifferentImplementation { // some other methods for the provider } } and that is all. The registration stays the same, just people implement the different class and thus call the other create(...) method. This is much simpler than with current ServiceLoader. When we faced this situation we needed to... http://bits.netbeans.org/dev/javadoc/org-netbeans-api-java-classpath/org/netbeans/spi/java/queries/SourceForBinaryQueryImplementation.html http://bits.netbeans.org/dev/javadoc/org-netbeans-api-java-classpath/org/netbeans/spi/java/queries/SourceForBinaryQueryImplementation2.html ... create the "2" interface, but that interface needed to extended the "1" interface, which was quite limiting. In short our NetBeans experience tells us that static "factory methods" can simplify services evolution and I'd like to contribute this to OpenJDK. > and I > guess you have in mind that such classes could have their behaviour > defined via constructor parameters, with each new version adding a new > constructor; but rather than guessing it would be nice to see an > example. Another nice thing is that now it is possible to create "service providers" without subclassing. For example we have: http://bits.netbeans.org/dev/javadoc/org-netbeans-modules-projectuiapi/org/netbeans/spi/project/ui/PrivilegedTemplates.html which is sort of service. Right now every module needs to create own subclass. With the factory method registration we could define: public final class PrivilegedTemplatesFactory { private PrivilegedTemplatesFactory() {} public static PrivilegedTemplates create(String... names) { ... } } and then the "service providers" could: public class SomeImplClass { public static String[] myPrivilegedTemplates() { return PrivilegedTemplatesFactory.create("Jaroslav", "Tulach"); } } and register it in META-INF/org.nb.PrivilegedTemplates as my.module.SomeImplClass.myPrivilegedTemplates() This could be also useful in certain situations. Are these use-cases convincing enough? Shall I document them in some OpenJDK source/documentation file? -jst PS: The last example could be made even more generic, if we allowed simple constants to be arguments to the factory methods, like having META-INF/org.nb.PrivilegedTemplates with org.nb.PrivilegedTemplatesFactory.create("Jaroslav", "Tulach") but that is probably too complicated for discussion, specification and even implementation, and as far as I remember NetBeans does not need that. > Jaroslav Tulach wrote: >

>
Thanks for the clarification, Mark. I've heard about some
>   umbrella JSR for
> each release of the JDK before and I was hoping that my proposed change
> could be covered as part of it. Thanks for confirming that such
> aggregation is possible.
> 
>   
>
>
With regard to this particular proposal, as the original
>     author of ... 
>
>

> OK, I can promise that I will work hard on polishing my proposal. I can
> improve the code, I can add more documentation, I can write more tests,
> change the new API semantics, etc. I just need a sponsor to tell me what
> to change and where and then take and apply my final patch.
> 
> Thanks in advance for your help.
> -jst
> 
> Dne Friday 17 October 2008 06:24:13 Mark Reinhold napsal(a):
>   
>
>
>
Date: Fri, 17 Oct 2008 05:56:13 +1000
> From: 
href="mailto:david.holmes at sun.com">david.holmes at sun.com
> 
> If this is a modification to the API not just a patch for the
> implementation then the short answer is No.
>       
>
>
Well, not exactly.
> 
>     
>
>
      
wrap="">                                     
>            API changes have to be made
> via a JSR.
>       
>
>
... or in a Maintenance Review of an existing JSR.
> 
> Small API revisions and additions do not require their own JSR; that
> would be ridiculously inefficient.  Instead we roll them up into a
> series of Maintenance Reviews of the previous Platform JSR [1].
> 
> There have already been many small API changes in the JDK 7 codebase.
> Suggested patches for further such changes are welcome, and will be
> discussed and judged on their own technical merit.  All implemented
> changes will, in due course, be aggregated into an appropriate JCP
> Maintenance Review.
> 
> With regard to this particular proposal, as the original author of
> the class in question I suppose I should have an opinion about it,
> but that's a topic for a different message.
> 
> - Mark
> 
> 
> [1]
> 
>     
>
>
  
href="http://weblogs.java.net/blog/mreinhold/archive/2006/03/mustang_mainten.html">http://weblogs.java.net/blog/mreinhold/archive/2006/03/mustang_mainten.html
> 
> 
>   
>
> > From jonathan.gibbons at sun.com Mon Oct 27 21:28:24 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Mon, 27 Oct 2008 21:28:24 +0000 Subject: hg: jdk7/tl/langtools: 6764226: ListTest fails on javap output with bad characters Message-ID: <20081027212827.88D76DBB1@hg.openjdk.java.net> Changeset: 5ebe90e0afff Author: jjg Date: 2008-10-27 14:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5ebe90e0afff 6764226: ListTest fails on javap output with bad characters Reviewed-by: darcy ! test/tools/javap/ListTest.java From maurizio.cimadamore at sun.com Tue Oct 28 13:07:37 2008 From: maurizio.cimadamore at sun.com (maurizio.cimadamore at sun.com) Date: Tue, 28 Oct 2008 13:07:37 +0000 Subject: hg: jdk7/tl/langtools: 6763518: Impossible to suppress raw-type warnings Message-ID: <20081028130740.EBB6FDBDB@hg.openjdk.java.net> Changeset: 4f7b344a1ce0 Author: mcimadamore Date: 2008-10-28 14:05 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4f7b344a1ce0 6763518: Impossible to suppress raw-type warnings Summary: Check.validate(Type) should be invoked after -Xlint is augmented in Attr.visitVarDef Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/6304921/T6304921.out + test/tools/javac/warnings/T6763518.java From christopher.hegarty at sun.com Tue Oct 28 16:17:58 2008 From: christopher.hegarty at sun.com (christopher.hegarty at sun.com) Date: Tue, 28 Oct 2008 16:17:58 +0000 Subject: hg: jdk7/tl/jdk: 6756771: com.sun.net.httpserver.HttpServer should handle POSTs larger than 2Gig Message-ID: <20081028161829.A0512DBEE@hg.openjdk.java.net> Changeset: 98ac3d398ed6 Author: chegar Date: 2008-10-28 16:14 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98ac3d398ed6 6756771: com.sun.net.httpserver.HttpServer should handle POSTs larger than 2Gig Summary: update implementation to use long instead of int Reviewed-by: michaelm ! src/share/classes/sun/net/httpserver/ExchangeImpl.java ! src/share/classes/sun/net/httpserver/FixedLengthInputStream.java ! src/share/classes/sun/net/httpserver/Request.java ! src/share/classes/sun/net/httpserver/ServerImpl.java + test/com/sun/net/httpserver/bugs/FixedLengthInputStream.java From eamonn.mcmanus at sun.com Tue Oct 28 17:23:47 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Tue, 28 Oct 2008 17:23:47 +0000 Subject: hg: jdk7/tl/jdk: 6763051: MXBean: Incorrect type names for parametrized dealing with arrays (openType); ... Message-ID: <20081028172409.748EDDBF9@hg.openjdk.java.net> Changeset: 58e52eb46bd3 Author: emcmanus Date: 2008-10-28 18:21 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/58e52eb46bd3 6763051: MXBean: Incorrect type names for parametrized dealing with arrays (openType) 6713777: developer diagnosability of errors in uncompliant mxbean interfaces Reviewed-by: dfuchs ! src/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java ! src/share/classes/com/sun/jmx/mbeanserver/MXBeanIntrospector.java ! src/share/classes/javax/management/MBeanServerInvocationHandler.java + test/javax/management/mxbean/ExceptionDiagnosisTest.java ! test/javax/management/mxbean/TypeNameTest.java From peter.jones at sun.com Tue Oct 28 19:40:25 2008 From: peter.jones at sun.com (Peter Jones) Date: Tue, 28 Oct 2008 15:40:25 -0400 Subject: RMI DGC questions In-Reply-To: <1C21C32F5F592D48B16F28C7877D9BC10370DB84@SVMAIL01.tripwire.com> References: <1C21C32F5F592D48B16F28C7877D9BC10370DB84@SVMAIL01.tripwire.com> Message-ID: <20081028194025.GA11341@east> On Sat, Oct 25, 2008 at 09:37:35AM -0700, Robert DiFalco wrote: > I'm thinking of making a change but wanted to gather some background > first. I would like to change DGC so that all sockets will uses a single > thread and reference queue. When there is work to be done, only then > will that work be sent to a thread pool. > > My big question is, why hasn't this been done before? It appears to be a > relatively simple change to make that would result in saving a thread > per connection? People are always complaining about these renew clean > threads and they really cut down on scalability, so I want to find out > what has prevented people from making this change in the past to make > sure I am not overlooking something. It sounds like you want to implement this RFE: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5053529 (Note that the word "object" has been inappropriately replaced by "customer" in the public version of that bug report.) It would certainly be great to have this done. I would say that it has been an issue of engineering resources rather than technical impediment. It may seem like a relatively simple change-- involving only one class, sun.rmi.transport.DGCClient-- but it's not entirely trivial either, there are some subtleties to that class. Moreover, I think that there is currently negligible test coverage of the code in that class, so a concern is that such a rework of its concurrency is risky without improving its test coverage as well. > Also, is there a straight forward soup to nuts article on downloading, > modifying code, building, testing, and submitting the change for the > core libraries? Do I have to build everything or is there a way to just > build my effected jars and use binary plugs so that I don't have to > rebuild native code? Can I just copy that rebuilt jar over to my JRE in > order to test? Have you looked at the links under "Hack on the JDK itself" at http://openjdk.java.net/ ? Others might have additional pointers. As far as building a subset, personally I would typically just build the whole "jdk" repository (as opposed to "hotspot", etc.) for core library changes, but that still involves building native code. -- Peter From eamonn.mcmanus at sun.com Thu Oct 30 16:50:26 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Thu, 30 Oct 2008 16:50:26 +0000 Subject: hg: jdk7/tl/jdk: 6252609: Two different default descriptor forms defined for ModelMBeanInfoSupport; ... Message-ID: <20081030165053.205F8DCF7@hg.openjdk.java.net> Changeset: 8dcde0b16199 Author: emcmanus Date: 2008-10-30 17:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8dcde0b16199 6252609: Two different default descriptor forms defined for ModelMBeanInfoSupport 6253137: Documentation for NotificationListener's handback parameter is confusing 6368691: javadoc for JMX Descriptors has bugs and is very hard to navigate. 6602699: support for async notification of mbeaninfo update 6759612: [javadoc] EventClient.NOTIFS_LOST has a garbled href to addEventClientListener 6759619: Clarify what EventClient.getEventClientNotificationInfo does 6759622: Clarify what EventClient.getListeners list does Summary: Documentation fixes, plus simple bugfix for 6759619. Reviewed-by: dfuchs ! src/share/classes/javax/management/Descriptor.java ! src/share/classes/javax/management/MBeanInfo.java ! src/share/classes/javax/management/MBeanServer.java ! src/share/classes/javax/management/NotificationListener.java ! src/share/classes/javax/management/event/EventClient.java ! src/share/classes/javax/management/modelmbean/DescriptorSupport.java ! src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanConstructorInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanNotificationInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanOperationInfo.java ! test/javax/management/eventService/CustomForwarderTest.java ! test/javax/management/mxbean/TypeNameTest.java From eamonn.mcmanus at sun.com Thu Oct 30 17:22:31 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Thu, 30 Oct 2008 17:22:31 +0000 Subject: hg: jdk7/tl/jdk: 6450848: make it easier to get the ObjectName of a JMX Proxy Message-ID: <20081030172256.C8202DCFE@hg.openjdk.java.net> Changeset: cdfb6f963a60 Author: emcmanus Date: 2008-10-30 18:19 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cdfb6f963a60 6450848: make it easier to get the ObjectName of a JMX Proxy Summary: Rework proxy javadoc to explain how to do this. Reviewed-by: sjiang ! src/share/classes/javax/management/JMX.java From sean.mullan at sun.com Thu Oct 30 22:58:18 2008 From: sean.mullan at sun.com (sean.mullan at sun.com) Date: Thu, 30 Oct 2008 22:58:18 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20081030225904.1B640DD13@hg.openjdk.java.net> Changeset: 4ff842aee1fd Author: mullan Date: 2008-10-30 17:24 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4ff842aee1fd 6764553: com.sun.org.apache.xml.internal.security.utils.IdResolver is not thread safe Reviewed-by: valeriep ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/IdResolver.java Changeset: f246770bcc78 Author: mullan Date: 2008-10-30 17:28 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f246770bcc78 Merge From david.lloyd at redhat.com Fri Oct 31 01:39:35 2008 From: david.lloyd at redhat.com (David M. Lloyd) Date: Thu, 30 Oct 2008 20:39:35 -0500 Subject: [PATCH 1/1] Modify standard HTML doclet to correctly label nested members Message-ID: <490A61D7.3080008@redhat.com> Currently, nested enum members are labeled as "static class"; furthermore, nested elements of interfaces and elements that *are* interfaces are redundantly labeled "static". This simple patch would cause nested members to be properly labeled. -- Index: tl/langtools/src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java =================================================================== --- tl/langtools/src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java Thu Oct 30 20:36:49 CDT 2008 +++ tl/langtools/src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java Thu Oct 30 20:36:49 CDT 2008 @@ -181,6 +181,8 @@ writer.space(); if (member.isClass()) { print("class"); + } else if (member.isEnum()) { + print("enum"); } else { print("interface"); } @@ -227,7 +229,8 @@ if (member.isMethod() && ((MethodDoc)member).isAbstract()) { print("abstract "); } - if (member.isStatic()) { + if (member.isStatic() && !member.isEnum() && !member.isInterface() && !member.containingClass().isInterface()) { + // enums, interfaces, and interface members are always implicitly static or not static print("static"); } } From rdifalco at tripwire.com Fri Oct 31 16:35:22 2008 From: rdifalco at tripwire.com (Robert DiFalco) Date: Fri, 31 Oct 2008 09:35:22 -0700 Subject: RMI DGC questions In-Reply-To: <20081028194025.GA11341@east> References: <1C21C32F5F592D48B16F28C7877D9BC10370DB84@SVMAIL01.tripwire.com> <20081028194025.GA11341@east> Message-ID: <1C21C32F5F592D48B16F28C7877D9BC10370DBA3@SVMAIL01.tripwire.com> Right, that is the RFE. Thanks for the info Peter. This is a pretty large issue for use as those threads cause servers with many client calls and call backs to run out of memory unnecessarily. I notice there are a few subtleties that I can see (class loading, timing, multiple modifiers to the pending list, etc) but I'm sure there are others I can't. It's unfortunate that the test coverage is weak. A simple approach (that would have less unintended consequences) would be a shared reference queue with a single thread but still spawn a thread per usual if there is actual LiveRef DGC and Lease work to be done (keeping the processing code in the polling loop essentially the same). But still, it would be difficult to ensure I wasn't changing (possibly undocumented) behavior that people have relied on. A property setting to switch between the old and new behavior could mitigate some of the risk around that. Are you familiar enough with (or remember enough about) the code to verify that this is a good approach to take? -----Original Message----- From: Peter Jones [mailto:peter.jones at sun.com] Sent: Tuesday, October 28, 2008 12:40 PM To: Robert DiFalco Cc: core-libs-dev at openjdk.java.net Subject: Re: RMI DGC questions On Sat, Oct 25, 2008 at 09:37:35AM -0700, Robert DiFalco wrote: > I'm thinking of making a change but wanted to gather some background > first. I would like to change DGC so that all sockets will uses a > single thread and reference queue. When there is work to be done, only > then will that work be sent to a thread pool. > > My big question is, why hasn't this been done before? It appears to be > a relatively simple change to make that would result in saving a > thread per connection? People are always complaining about these renew > clean threads and they really cut down on scalability, so I want to > find out what has prevented people from making this change in the past > to make sure I am not overlooking something. It sounds like you want to implement this RFE: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5053529 (Note that the word "object" has been inappropriately replaced by "customer" in the public version of that bug report.) It would certainly be great to have this done. I would say that it has been an issue of engineering resources rather than technical impediment. It may seem like a relatively simple change-- involving only one class, sun.rmi.transport.DGCClient-- but it's not entirely trivial either, there are some subtleties to that class. Moreover, I think that there is currently negligible test coverage of the code in that class, so a concern is that such a rework of its concurrency is risky without improving its test coverage as well. > Also, is there a straight forward soup to nuts article on downloading, > modifying code, building, testing, and submitting the change for the > core libraries? Do I have to build everything or is there a way to > just build my effected jars and use binary plugs so that I don't have > to rebuild native code? Can I just copy that rebuilt jar over to my > JRE in order to test? Have you looked at the links under "Hack on the JDK itself" at http://openjdk.java.net/ ? Others might have additional pointers. As far as building a subset, personally I would typically just build the whole "jdk" repository (as opposed to "hotspot", etc.) for core library changes, but that still involves building native code. -- Peter From eamonn.mcmanus at sun.com Fri Oct 31 16:37:37 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Fri, 31 Oct 2008 16:37:37 +0000 Subject: hg: jdk7/tl/jdk: 6766173: Spec should say that createMBean wraps a constructor RuntimeException in a RuntimeMBeanException Message-ID: <20081031163805.A5D6BDD52@hg.openjdk.java.net> Changeset: 8d17cc67a857 Author: emcmanus Date: 2008-10-31 17:34 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8d17cc67a857 6766173: Spec should say that createMBean wraps a constructor RuntimeException in a RuntimeMBeanException Summary: JMX spec clarification Reviewed-by: dfuchs ! src/share/classes/javax/management/MBeanServerConnection.java ! src/share/classes/javax/management/namespace/MBeanServerSupport.java ! test/javax/management/MBeanServer/MBeanExceptionTest.java