[8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

[Naoto Sato]

Hi Kelly,

The shell script in question is pretty likely to be removed, or at least 
rewritten when we make modifications for Jigsaw packaging of the locale 
data. Right now the script creates the pre-baked locale list based on 
the existing resource bundle source files in the repository, but that 
locale list will have to be created at the run time, not build time.

Naoto

On 12/07/13 13:20, Kelly O'Hair wrote:
>
> Something seems strange here:
>     http://cr.openjdk.java.net/~naoto/6336885/webrev.00/make/java/java/localegen.sh.sdiff.html
> It's like someone was avoiding overall quotes, but using them to add spaces somehow...
> I sure would like to get rid of this shell logic, seems like there are lots repeated logic that
> this script does over and over or could be done with makefile pattern subst's instead of exec's.
> ---
>
> Overall, just looking at the makefiles, the build-infra team may need some time to fully absorb this into the
> new makefiles, some of it will be trivial, not sure all of it will be.
>
> Not sure how to proceed here, the build-infra team does need an action item to deal with this, maybe
> before it gets integrated because I suspect the new makefiles will break with all the filename or
> directory changes. But I hate to hold up your integration plans.
>
> I'd like to get some advice from Erik on this before saying anything further.
>
> -kto
>
> On Jul 10, 2012, at 1:42 PM, Naoto Sato wrote:
>
>> Hello,
>>
>> Please review the JDK8 changes for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data (http://openjdk.java.net/jeps/127). The webrev is located at:
>>
>> http://cr.openjdk.java.net/~naoto/6336885/webrev.00/
>>
>> The main bug id for this enhancement is:
>>
>> 6336885: RFE: Locale Data Deployment Enhancements
>>
>> Along with this, the following bugs/enhancements are also implemented in this change:
>>
>> 4609153 Provide locale data for Indic locales
>> 5104387 Support for gl_ES locale (galician language)
>> 6337471 desktop/system locale preferences support
>> 7056139 (cal) SPI support for locale-dependent Calendar parameters
>> 7058206 Provide CalendarData SPI for week params and display field value names
>> 7073852 Support multiple scripts for digits and decimal symbols per locale
>> 7079560 [Fmt-Da] Context dependent month names support in SimpleDateFormat
>> 7171324 getAvailableLocales() of locale sensitive services should return the actual availability of locales
>> 7151414 (cal) Support calendar type identification
>> 7168528 LocaleServiceProvider needs to be aware of Locale extensions
>> 7171372 (cal) locale's default Calendar should be created if unknown calendar is specified
>>
>> Please note that packaging changes that relate to Jigsaw module system aren't included in this changeset.
>>
>> Naoto Sato and Masayoshi Okutsu
>