RFR: JDK9: 8029388: java.exe consumes argument intended for launched java class
kumar.x.srinivasan at oracle.com
Thu Dec 12 02:09:53 UTC 2013
Thanks for the review.
> On 12/11/2013 3:21 PM, Kumar Srinivasan wrote:
>> Please review a fix for Windows launcher where it consumes
>> application args
>> -d32 and -d64, the fix is to stop the scan when it hits the
>> Application sentinel
>> ie. class-name or jar-name.
> Nit: can we start checking from argv and skip argv? line 194
> no need to check i > 0 then.
Yes, we can start from 1 instead of 0.
> Nit: line 95 - an extra space before "dmodel". A general question -
> doExec handles the case when the cmd
Will fix that.
> terminates with an exception. I was wondering if the generated Args
> class should just throw an exception if it doesn't match the expected
> value (i.e. have Args class to do the verification). I pondered a
> little bit when reading the verifyOption method before I read the
> createOptionsJar method.
I have tried to keep the generated classes as simple as possible,
and errors in these are hard to track down.
> Otherwise, looks good.
More information about the core-libs-dev