RFR: JDK 9: 8024033: [launcher] remove solaris dual mode support
kumar.x.srinivasan at oracle.com
Thu Dec 12 16:15:50 UTC 2013
Thanks for the review.
> Hi Kumar,
> Will be glad to see this "feature" purged from the sources!
> I believe the comments on lines 135 to 167 in the new file still need
> some updating.
> The comment block on line 261 - 273 may need revising too.
Got it, I will fix those.
> Otherwise, looks fine.
> On 12/11/2013 01:12 PM, Kumar Srinivasan wrote:
>> On 12/11/2013 12:25 PM, Martin Buchholz wrote:
>>> Although I have a small emotional attachment to the idea of fat
>>> binaries, there doesn't seem to be too much support for this in the
>>> larger java community, and probably the larger unix community will
>>> be 64-bit only relatively soon. So ... OK.
>>> There's one remaining mention of "LD_LIBRARY_PATH_32". Maybe you
>>> want to scrub that as well?
>>> 589 (void)UnsetEnv((wanted == 32) ?
>>> "LD_LIBRARY_PATH_32" : "LD_LIBRARY_PATH_64");
>> Good catch I will scrub that.
>> Thanks Martin.
>>> On Wed, Dec 11, 2013 at 12:08 PM, Kumar Srinivasan
>>> <kumar.x.srinivasan at oracle.com
>>> <mailto:kumar.x.srinivasan at oracle.com>> wrote:
>>> Hello Joe, Martin, et. al.,
>>> In JDK8, solaris 32-bit support was removed entirely, this is the
>>> only platform that required
>>> dual-mode support, ie. 32-bit and 64-bit binaries co-located in
>>> the same binary hierarchy
>>> on the disk. In JDK 8 the DUAL_MODE support was disabled in the
>>> launcher, using compile
>>> time conditionals, however in JDK9 we wish to remove the logic
>>> entirely, this is messy and
>>> makes the launcher cleaner and easier to maintain.
More information about the core-libs-dev