RFR (JAXP) 8029955 : AIOB in XMLEntityScanner.scanLiteral upon parsing literals with > 100 LF chars
huizhe.wang at oracle.com
Tue Dec 17 17:26:43 UTC 2013
On 12/17/2013 4:10 AM, Daniel Fuchs wrote:
> Hi Joe,
> The fix looks good - though I wonder at whether incrementing
> whiteSpaceLookup by a fix amount wouldn't be better than
> doubling its length.
Both would be okay. The case, as demonstrated in the report, that there
are hundreds of LFs in an attribute, is very rare.
> best regards,
> -- daniel
> On 12/16/13 8:31 PM, huizhe wang wrote:
>> This is a quick fix for a whitespace buffer that was not adjusted
>> properly in one of the two cases. The buffer, whiteSpaceLookup, is
>> filled in two cases and adjusted properly the 2nd time. The code is
>> moved into a method storeWhiteSpace so that it's shared for the 1st case
>> as well.
>> Note at line 1175, there is no need to save character 0x20 since all
>> whitespace characters will later be replaced with character 0x20.
More information about the core-libs-dev