RFR for JDK-6963118 Intermittent test failure: test/java/nio/channels/Selector/Wakeup.java fail intermittently (win)

Alan Bateman Alan.Bateman at oracle.com
Fri Dec 20 15:03:56 UTC 2013

On 20/12/2013 04:18, David Holmes wrote:
> :
> Increasing the timeouts seems okay but how confident are you that this 
> is sufficient for a wide range of platforms. In other tests we often 
> see timeouts of a few seconds get extended even further, so three 
> seconds is not so big.
> Also the yield loops:
> while (sleeper.entries < 5)
>     Thread.yield();
> would be better as sleep loops (as used elsewhere) to avoid potential 
> issues with yield being a no-op on some platforms (Yes I see it is 
> already used that way elsewhere in the test but the sleep is better :) ).
Kalyan started another thread on this one and in the latest revision 
then the timeout has been increased to 10 seconds.

I agree, it would be better to use a small sleep rather than yield.


More information about the core-libs-dev mailing list