Review request for JDK-8007405: Update parameter reflection API in accordance with spec changes

Joe Darcy joe.darcy at oracle.com
Thu Feb 7 05:09:33 UTC 2013


Hi Eric,

The code changes look okay, but some tests for isImplicit should be 
written as soon as there is compiler support for the feature.

Cheers,

-Joe

On 02/05/2013 12:40 PM, Eric McCorkle wrote:
> Clarification here: the issue's title is a bit more narrow than the
> scope of the fix.  It addresses some javadoc comments and handling of
> nameless parameters as well.
>
> On 02/05/13 14:58, Eric McCorkle wrote:
>> Hello, please review this patch, which implements some spec changes for
>> parameter reflection in the java.lang.reflect API.
>>
>> This patch changes the SYNTHESIZED flag to MANDATED, and changes the
>> associated methods.  It also updates some javadoc comments.
>>
>> The webrev is here:
>> http://cr.openjdk.java.net/~emc/8007405/
>>
>> The bug report is here:
>> http://bugs.sun.com/view_bug.do?bug_id=8007405
>>
>> The latest version of the spec is here:
>> http://cr.openjdk.java.net/~abuckley/8misc.pdf
>>
>> Thanks,
>> Eric




More information about the core-libs-dev mailing list