Request for review: 8007454 Wrong parameters in Win32 native code.
alexey.utkin at oracle.com
Mon Feb 18 15:16:08 UTC 2013
On 04.02.2013 18:25, Alan Bateman wrote:
> On 04/02/2013 12:28, Alexey Utkin wrote:
>> Please review the fix.
>> Bug description:
>> The suggested fix:
>> Old version of code for the [Java_java_lang_ProcessImpl_create]
>> function could not work right in some cases. The
>> [SetHandleInformation] call worked partially and just because
>> HANDLE_FLAG_INHERIT == TRUE == 1 and FALSE == 0.
> As the parameter is a DWORD then it shouldn't be using a BOOLEAN so I
> agree with that.
> Can you explain why HANDLE_FLAG_PROTECT_FROM_CLOSE is needed?
Hmm... That was my mistake.
HANDLE_FLAG_PROTECT_FROM_CLOSE bit has to be removed from mask.
I mixed the variable names and did not understand clearly the handles
My tests with redirected, direct and terminated input/output modes prove
that the number of opened
handles has GC-related saturation value.
More information about the core-libs-dev