RFR: 8005545: Add System property to identify ARCH specific details such as ARM hard-float binaries
bob.vandette at oracle.com
Fri Feb 22 21:35:14 UTC 2013
Looks good to me.
On Feb 22, 2013, at 4:33 PM, Vladimir Danushevsky wrote:
> Thanks, webrev updated
> On Feb 22, 2013, at 5:57 AM, Alan Bateman wrote:
>> On 21/02/2013 22:02, Vladimir Danushevsky wrote:
>>> http://cr.openjdk.java.net/~vladidan/8005545/webrev.00/ <http://cr.openjdk.java.net/%7Evladidan/8005545/webrev.00/>
>>> Separate change to the build script (e.g. in ARM Hard-Float ABI case):
>>> setenv ARCHABIPROPNAME gnueabihf
>>> -DARCHABIPROPNAME="\"$(ARCHABIPROPNAME)\"" is passed to the CFLAGS
>> I agree with Bob on the naming, otherwise it looks okay to me.
>> On the release file and Images.gmk then jdk/tl was sync'ed up yesterday so you will probably need to re-base the patch.
More information about the core-libs-dev