Review request for 8016101, javadoc typos for SerialRef and SerialStruct

Lance Andersen - Oracle Lance.Andersen at oracle.com
Thu Jun 6 20:41:52 UTC 2013


Hi Aleksey,

The change is 2 lines, not worth a webrev.  Here it is again in case it was truncated in last email (looked OK on my end)

 
new-host-2:serial lanceandersen$ hg diff
diff -r b4742d038100 src/share/classes/javax/sql/rowset/serial/SerialRef.java
--- a/src/share/classes/javax/sql/rowset/serial/SerialRef.java	Tue May 28 15:22:30 2013 +0200
+++ b/src/share/classes/javax/sql/rowset/serial/SerialRef.java	Thu Jun 06 16:01:07 2013 -0400
@@ -202,7 +202,7 @@
     }
 
     /**
-     * Returns a clone of this {@code SerialRef}. .
+     * Returns a clone of this {@code SerialRef}.
      * The underlying {@code Ref} object will be set to null.
      *
      * @return  a clone of this SerialRef
diff -r b4742d038100 src/share/classes/javax/sql/rowset/serial/SerialStruct.java
--- a/src/share/classes/javax/sql/rowset/serial/SerialStruct.java	Tue May 28 15:22:30 2013 +0200
+++ b/src/share/classes/javax/sql/rowset/serial/SerialStruct.java	Thu Jun 06 16:01:07 2013 -0400
@@ -87,6 +87,7 @@
      * object for custom mapping the SQL structured type or any of its
      * attributes that are SQL structured types.
      *
+     * @param in an instance of {@code Struct} 
      * @param map a <code>java.util.Map</code> object in which
      *        each entry consists of 1) a <code>String</code> object
      *        giving the fully qualified name of a UDT and 2) the
On Jun 6, 2013, at 4:34 PM, Aleksey Shipilev wrote:

> Hi Lance,
> 
> On 06/07/2013 12:09 AM, Lance Andersen - Oracle wrote:
>> Need a reviewer for this minor javadoc update for bug 8016101
> 
> (not a reviewer) The patch appears to be truncated, can you submit it as
> patch/webrev somewhere on the web (e.g. cr.openjdk.java.net)?
> 
> -Aleksey.
> 

-------------- next part --------------

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com



More information about the core-libs-dev mailing list