RFR : 7129185 : (L) Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}

[Martin Buchholz]

Looks good.

+        catch (Throwable e) {
+            if (e instanceof Error) {
+                throw (Error) e;
+            } else if (e instanceof RuntimeException) {
+                throw (RuntimeException) e;
+            } else {
+                throw new RuntimeException(e);
+            }


You can take advantage of those new-fangled language features to make this
a little less boilerplatey.

        catch (Error|RuntimeException e) { throw e; }
        catch (Throwable e) { throw new RuntimeException(e); }



On Tue, Jun 18, 2013 at 5:59 PM, Mike Duigou <mike.duigou at oracle.com> wrote:

> I have now updated MOAT to test the Collections wrappers. I hope that
> adding additional classes doesn't take the already long runtime of this
> class over the timeout threshold.
>
> The revised webrev, which includes only changes to tests, is here:
>
> http://cr.openjdk.java.net/~mduigou/JDK-7129185/6/webrev/
>
> The very pleasing news is that nothing failed!
>
> Mike
>
> On Jun 18 2013, at 15:34 , Martin Buchholz wrote:
>
> >
> > Looking at MOAT.java, I'm a little surprised that I didn't
> systematically test the implementations in Collections.java, even though
> e.g. it has a section for empty collections.  How hard would it be to add
> such support?
>
>