RFR 7131192: BigInteger.doubleValue() is depressingly slow

David Chase david.r.chase at oracle.com
Fri Jun 21 01:08:07 UTC 2013

On 2013-06-20, at 4:53 PM, Martin Buchholz <martinrb at google.com> wrote:

> I am an openjdk Reviewer, and this change Looks Good To Me.
> Thanks Louis, David, Brian.
> Again I suggest we make it easier to give out reviewer bits.  For example, David may not have been making many direct contributions to openjdk, but he certainly has related expertise and a track record.

Thanks for the vote of confidence, and I somewhat agree, but I think it's a tricky call to make.  I have a long track record with compilers, too, but knowing your way around a particular incredibly complex compiler (actually, pair of compilers and an interpreter) doesn't come automatically just because you spent decades with your nose up the wrong end of several other differently complex compilers.

Specialized domain knowledge (FP, sync-free data structures, finite field arithmetic, parallelizing recurrences) is different -- it's a pain to learn, but once you learn it, it applies in many places.


More information about the core-libs-dev mailing list