RFR: tests for JDK-8032884

[Miroslav Kos]

Hi Chris,
the test moved: http://cr.openjdk.java.net/~mkos/8032884/jdk.02/

Thanks
Miran



On 02/04/14 15:47, Chris Hegarty wrote:
> On 02/04/14 14:32, Miroslav Kos wrote:
>> In the test, I need to do following steps:
>>
>> 1. compile schema file using xjc tool
>> 2. compile generated sources
>> 3. load generated class and via reflection API verify generated methods
>
> In which case, what you have is fine then.
>
>> Although I know how to run tool directly from the test, it seems to me
>> not very elegant to run compiler directly from the test - or is there
>> other way how to compile generated sources from the test?
>>
>> Regrading moving test - no problem, but I would suggest
>> javax/xml/bind/xjc in this case - xjc is JAXB tool, not JAX-WS. Do you
>> agree?
>
> Agreed.
>
> -Chris.
>
>>
>> Thanks
>> Miran
>>
>>
>>
>> On 01/04/14 18:50, Chris Hegarty wrote:
>>> The tests looks fine to me.
>>>
>>> Trivially, you could eliminate the shell script and run xic from
>>> ProcessBuilder?
>>>
>>> Also, does it make sense to move the test to
>>> jdk/test/javax/xml/ws/xjc? With the other jaxws tests, or is xjc
>>> different.
>>>
>>> -Chris,.
>>>
>>> On 1 Apr 2014, at 16:21, Miroslav Kos <miroslav.kos at oracle.com> wrote:
>>>
>>>> Hi everybody,
>>>>
>>>> I'd like to ask for review of following tests:
>>>> http://cr.openjdk.java.net/~mkos/8032884/jdk.01/
>>>>
>>>> Original bug (already fixed): Bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8032884
>>>> Issue fixing the bug (bulk update):
>>>> https://bugs.openjdk.java.net/browse/JDK-8036030
>>>>
>>>> The test verifies the source code generated by xjc tool.
>>>>
>>>> Thanks
>>>> Miran
>>