RFR: Checking for JNI Exceptions in jni_util.c
roger riggs
roger.riggs at oracle.com
Tue Feb 4 18:11:27 UTC 2014
Hi Alan,
Thanks for the review and suggestions; the webrev has been updated
with the recommendations.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-check_exception-8030993/
Thanks, Roger
On 2/4/2014 10:12 AM, Alan Bateman wrote:
> On 04/02/2014 14:33, roger riggs wrote:
>> Please review these cleanups to check for JNI pending exceptions in
>> jni_util.c.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~rriggs/webrev-check_exception-8030993/
> This mostly looks okay, I just wonder about the jclass declarations at
> L686 and 690 as I assume these are declaration-after-use warnings with
> some compilers.
>
> Also there is JNU_ClassString use at L760 that I assume should be
> replaced with strClazz.
>
> -Alan.
More information about the core-libs-dev
mailing list