RFR: 7152892: some jtreg tests fail with permission denied

Mandy Chung mandy.chung at oracle.com
Mon Feb 10 15:43:17 UTC 2014


On 2/7/2014 10:44 AM, Rob McKenna wrote:
> Hi folks,
>
> When files are copied by our test harness the permissions are left 
> unchanged. This can cause trouble for a few tests when the test folder 
> is read only.
>
> http://cr.openjdk.java.net/~robm/7152892/webrev.01/

AIX is missing in your change in Assert.sh.   Assert.sh doesn't
seem to be necessary.  I think it can replace the shell test
with @build to compile the classes.  It may also need to change
"java Assert" with the right classpath (I haven't checked in details)
in Assert.java (which execs the java command). Do you mind looking
into the possibility to remove Assert.sh?

$ hg diff Assert.java
diff --git a/test/java/lang/ClassLoader/Assert.java b/test/java/lang/ClassLoader/Assert.java
--- a/test/java/lang/ClassLoader/Assert.java
+++ b/test/java/lang/ClassLoader/Assert.java
@@ -24,7 +24,8 @@
  /*
   * @test
   * @bug 4290640 4785473
- * @run shell/timeout=300 Assert.sh
+ * @build package1.Class1 package2.Class2 package1.package3.Class3 Assert
+ * @run main/othervm Assert
   * @summary Test the assertion facility
   * @author Mike McCloskey
   */


Mandy




More information about the core-libs-dev mailing list