RFR 9: 8034903: Add Logging of Process.start arguments and resulting pid

[Paul Benedict]

Roger, I only have two suggested improvements:

1) solaris/../ProcessImpl.java should use Objects.toString() rather than
the tenary operator for a string choice. You did this alright in
/windows/../ProcessImpl.java

2) /windows/../ProcessImpl.java doesn't need to specify "null" for
Objects.toString() since that is its default output for null input.

Cheers,
Paul


On Thu, Feb 13, 2014 at 3:26 PM, roger riggs <roger.riggs at oracle.com> wrote:

> Hi,
>
> Having folks stumbling over process creation and problems of quoting,
> especially on windows, it seems useful to log the native commands and
> arguments.
> They are proposed to be logged using the PlatformLogger at Level.FINE
> which will not be logged by default. The environment is useful in some
> cases,
> but verbose, that it should be Logged at FINER.  The pid of the spawned
> process
> logged as well for traceability.
>
> Please take a look at this first draft and comment on whether it is useful,
> a good idea and any improvements needed.
>
> Webrev:
>    http://cr.openjdk.java.net/~rriggs/webrev-log-processcreate/
>
> Thanks, Roger
>
>


-- 
Cheers,
Paul