JDK 9 RFR of JDK-8035279: Clean up internal deprecations in BigInteger
Alan Bateman
Alan.Bateman at oracle.com
Thu Feb 20 08:13:08 UTC 2014
On 19/02/2014 21:44, Brian Burkhalter wrote:
> This patch concerns cleaning up some ugly internal deprecations.
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8035279
> Webrev: http://cr.openjdk.java.net/~bpb/8035279/webrev.00/
>
> All JTREG BigInteger tests pass, and the serialized form has been unaltered as verified by bidirectional read-write testing between Java 7 and this version.
>
> I would appreciate scrutiny of the arithmetic to make sure that I've made no silly errors. Also I would be interested in opinions as to whether the "volatile" keyword should in fact be used for the affected instance variables.
>
It's not clear (to me) that these should be volatile. I also wonder
about setting the initial value too as volatile could make this
expensive in some environments.
Are you sure there isn't any serialization impact? Zeros has also meant
these are uninitialized so I just wonder about deserializing on an older
JDK.
-Alan.
More information about the core-libs-dev
mailing list