RFR: 8035618 : Four api/org_omg/CORBA TCK tests fail under plugin only

Mandy Chung mandy.chung at oracle.com
Wed Feb 26 22:15:41 UTC 2014


Looks good to me.

Mandy

On 2/26/2014 1:47 PM, Seán Coffey wrote:
> Good points Alan. Changes uploaded here :
> http://cr.openjdk.java.net/~coffeys/webrev.8035618.v2/webrev/
>
> regards,
> Sean.
>
> On 26/02/14 18:54, Alan Bateman wrote:
>> On 26/02/2014 16:50, Seán Coffey wrote:
>>> Looking to push a fix to JDK 8. A CORBA issue was discovered during 
>>> TCK-Plugin testing. The NPE seen should be handled and the 
>>> defaultPresentationManager should be returned where necessary.
>>>
>>> Bug ID : https://bugs.openjdk.java.net/browse/JDK-8035618
>>> webrev : http://cr.openjdk.java.net/~coffeys/webrev.8035618/webrev/
>> The AppContext usage looks okay but I worry that changing this method 
>> to synchronized will lead to contention. At least for the non 
>> security manager then can this be changed so that the 
>> defaultPresentationManager is initialized via a holder class and 
>> changed to volatile and initialized via the usual double checked 
>> locking idiom. There are other options but I think this one is the 
>> important case and should not be synchronized.
>>
>> -Alan.
>>
>




More information about the core-libs-dev mailing list