JDK 9 RFR of JDK-8132854: Adjust tier 1 and 2 definitions for nio-related intrinsics
joe darcy
joe.darcy at oracle.com
Mon Aug 3 03:19:57 UTC 2015
Hello,
With the fix for
JDK-8076112: Add @HotSpotIntrinsicCandidate annotation to
indicate methods for which Java Runtime has intrinsics
the sources for the libraries clearly indicate which methods might have
intrinsic support in HotSpot, that is, which methods might have their
Java source implementation replaced by some other code sequence
maintained in HotSpot, such as a special-purpose processor-specific
instruction.
To ease testing, it would be help if all the intrinsified methods were
included in the tier 1 test group. Most of the intrinics are in
java.lang, java.math, and java.util, packages whose tests are already in
tier 1. Two nio-related classes are marked with @HotSpotIntrinsicCandidate:
./java.base/share/classes/sun/nio/cs/ISO_8859_1.java #
implEncodeISOArray marked
./java.base/share/classes/java/nio/Buffer.java # index check
Therefore, I propose moving the tests that directly cover those areas to
tier 1:
--- a/test/TEST.groups Mon Aug 03 09:25:02 2015 +0800
+++ b/test/TEST.groups Sun Aug 02 20:16:00 2015 -0700
@@ -28,11 +28,15 @@
tier1 = \
:jdk_lang \
:jdk_util \
+ sun/nio/cs/ISO8859x.java \
+ java/nio/Buffer \
:jdk_math
tier2 = \
:jdk_io \
:jdk_nio \
+ -sun/nio/cs/ISO8859x.java \
+ -java/nio/Buffer \
:jdk_net \
:jdk_time \
:jdk_security \
Full webrev at
http://cr.openjdk.java.net/~darcy/8132854.0/
Thanks,
-Joe
More information about the core-libs-dev
mailing list