RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

Chris Hegarty chris.hegarty at oracle.com
Thu Dec 3 10:43:49 UTC 2015


> On 3 Dec 2015, at 5:24 a.m., Amy Lu <amy.lu at oracle.com> wrote:
> 
> (I'm not a reviewer)

Thanks for looking at this Amy, all eyes are welcome.

> Just a minor question.
> 
> jdk/test/sun/misc/Encode/GetBytes.java also use sun.misc.BASE64Encoder and BASE64Decoder, but is not included in this fix.
> Missed? or justbecause this test will be totally removed soon in a separate bugid?

Since this test is specifically designed to test the coder 
functionality, then it will be proposed to be removed when the coders are.

Thanks,
-Chris.

> Thanks,
> Amy
> 
>> On 12/2/15 11:03 PM, Chris Hegarty wrote:
>> Updated to remove all use of reflection. If someone really
>> wants to run S11N on an older JDK, then it is a simple
>> edit to uncomment/comment 3 lines.
>> 
>> http://cr.openjdk.java.net/~chegar/Base64-test-updates.01/webrev/
>> 
>> -Chris.
>> 
>>> On 02/12/15 14:15, Chris Hegarty wrote:
>>>> On 02/12/15 14:03, Alan Bateman wrote:
>>>> 
>>>>> On 02/12/2015 12:08, Chris Hegarty wrote:
>>>>> The regression tests in the jdk should be updated, where possible, to
>>>>> use java.util.Base64.
>>>>> 
>>>>> http://cr.openjdk.java.net/~chegar/Base64-test-updates/webrev/
>>>> Should S11N be updated to serialize with JDK 8 so that the core
>>>> reflection code isn't needed?
>>> 
>>> This is certainly possible and would make the test simpler, but
>>> I followed the comments in the test ( it needs to be runnable on
>>> older JDKs ).  I think this is a reasonable requirement since the
>>> test contains bytes array that were generated on older JDKs. Of
>>> course, the test could contain the older JDK code commented out.
>>> If someone really wants to run it with 1.6, then they just make
>>> the simple edits.
>>> 
>>> I'm ok with any of these solutions, or just removing the possibility
>>> of running on older JDKs.
>>> 
>>> -Chris.
> 



More information about the core-libs-dev mailing list