RFR 9: 8138696 : java.lang.ref.Cleaner - an easy to use alternative to finalization

Roger Riggs Roger.Riggs at Oracle.com
Fri Dec 4 17:58:59 UTC 2015


Hi Kim,

Corrected

Thanks for all the review,  Roger


On 12/4/2015 12:56 PM, Kim Barrett wrote:
> On Dec 4, 2015, at 11:56 AM, Roger Riggs <roger.riggs at oracle.com> wrote:
>> Hi Mandy,
>>
>> The webrev[1] and javadoc[2] are updated in to address your comments.
>>
>> Thanks, Roger
>>
>> [1] http://cr.openjdk.java.net/~rriggs/webrev-cleaner-8138696/
>> [2] http://cr.openjdk.java.net/~rriggs/cleaner-doc/index.html
>>
> One tiny nit:
> src/java.base/share/classes/jdk/internal/misc/CleanerImpl.java
>   136                 // Cleanable the thread locals
>
> "Cleanable" seems like the wrong word here.
>
> All of my previous points have been addressed.
>
> Looks good to me.
>




More information about the core-libs-dev mailing list