RFR [9] Moved sun.misc.ProxyGenerator to jdk.internal.reflect

Chris Hegarty chris.hegarty at oracle.com
Tue Dec 15 19:39:13 UTC 2015


On 15 Dec 2015, at 19:26, Mandy Chung <mandy.chung at oracle.com> wrote:

>> On Dec 15, 2015, at 10:41 AM, Chris Hegarty <chris.hegarty at oracle.com> wrote:
>> 
>> 
>> Webrev updated in-place.
> 
> Thank you for moving it to java.lang.reflect.
> 
> Formatting nit: since you make generateProxyClass method package-private, line 323 & 335-336 needs to be adjusted to align with the line above.
> 
> Thanks for renaming the system property.  Do you mind renaming it to “jdk.proxy.ProxyGenerator.saveGeneratedFiles” as “java.” may be interpreted as standard system property?  “jdk.proxy” may not be the best candidate that we can revisit later. 

I’ll do this before pushing.

Thanks,
-Chris.


More information about the core-libs-dev mailing list