RFR(S): JDK-8073175, 8073174: Fix native warnings in libjli and libfdlibm

Christos Zoulas christos at zoulas.com
Sun Feb 15 16:22:18 UTC 2015


On Feb 15,  6:52pm, dmitry.samersoff at oracle.com (Dmitry Samersoff) wrote:
-- Subject: RFR(S): JDK-8073175, 8073174: Fix native warnings in libjli and l

| Hi Everyone,
| 
| It's my $0.02 to the warning cleanup work. Please review:
| 
| http://cr.openjdk.java.net/~dsamersoff/JDK-8073175/webrev.01
| http://cr.openjdk.java.net/~dsamersoff/JDK-8073174/webrev.01
| 
| Notes:
| 
| 1.
| There are two common ways to cast pointer to int: intptr_t (perfectly
| safe, more-or-less portable) and size_t (perfectly portable,
| more-or-less safe)
| 
| So I use size_t in shared code, intptr_t in UNIX specific code.
| 

Why are you using a signed and an unsigned type? You should probably
be using uintptr_t for consistency.

christos



More information about the core-libs-dev mailing list