RFR: 8068790: ZipEntry/JarEntry.setCreation/LastAccessTime(null) don't throw NPE as specified
Seán Coffey
sean.coffey at oracle.com
Fri Feb 20 15:04:15 UTC 2015
Looks fine to me Claes. From a supportability point of view, could I
suggest that the exception string be made more informative ? (for cases
where the stack may not be present - logs etc.)
i.e. "lastModifiedTime", "lastAccessTime", "creationTime".
Will you be porting this to jdk8u-dev also ?
regards,
Sean.
On 20/02/15 12:54, Claes Redestad wrote:
> Hi all,
>
> please review this simple fix to do the right null checks in a few
> ZipEntry methods.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8068790
> webrev: http://cr.openjdk.java.net/~redestad/jdk9/8068790/webrev.0/
>
> /Claes
More information about the core-libs-dev
mailing list