RFR: 8068790: ZipEntry/JarEntry.setCreation/LastAccessTime(null) don't throw NPE as specified

Claes Redestad claes.redestad at oracle.com
Sat Feb 21 13:04:11 UTC 2015


On 2015-02-20 17:34, Seán Coffey wrote:
>
> On 20/02/15 15:24, Claes Redestad wrote:
>> On 2015-02-20 16:04, Seán Coffey wrote:
>>> Looks fine to me Claes. From a supportability point of view, could I 
>>> suggest that the exception string be made more informative ? (for 
>>> cases where the stack may not be present - logs etc.)
>>> i.e. "lastModifiedTime", "lastAccessTime", "creationTime".
>>
>> Thanks!
>>
>> Updated webrev: 
>> http://cr.openjdk.java.net/~redestad/jdk9/8068790/webrev.1/
>>
>>>
>>> Will you be porting this to jdk8u-dev also ?
>>
>> That seems appropriate. I'm not a JDK8 committer, though.
> Thanks for updating. I guess JDK-8065536 can be closed out as a 
> duplicate now also. I've created a backport record for jdk8u and can 
> pull this one back once you've pushed to JDK 9.

Thanks for reviewing! Pushed and closed JDK-8065536 as a duplicate of this.

/Claes

>
> regards,
> Sean.
>>
>> /Claes
>




More information about the core-libs-dev mailing list