JDK 9 RFR of 8059175: Zero BigDecimal with negative scale prints leading zeroes in String.format

Joseph D. Darcy joe.darcy at oracle.com
Wed Jan 7 22:10:09 UTC 2015


On 1/7/2015 9:39 AM, Brian Burkhalter wrote:
> On Jan 7, 2015, at 1:23 AM, Paul Sandoz <paul.sandoz at oracle.com> wrote:
>
>>> In java.util.Formatter.BigDecimalLayout.layout() trailing zeroes are erroneously appended when the unscaled value of the BigDecimal is zero and the scale is negative. Some other minor changes are included to make the logic in the method clearer.
>>>
>> Look good.
>>
>> I minor comment, ignore if you wish. If you wanna clean it up further you can merge into one if/else if/else sequence.
> Thanks for the suggestion; I like that better also. An updated version is here:
>
> http://cr.openjdk.java.net/~bpb/8059175/webrev.01/
>
> For the sake of formality, a +1 on this minor tweak from a Reviewer would be appreciated.
>
>

+1

-Joe



More information about the core-libs-dev mailing list