RFR 8139056: Add convenience methods to Statement.java

[Lance Andersen]

Hi Roger,
On Oct 20, 2015, at 5:33 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:

> Hi Lance,
> 
> The logic looks correct but enquoteLiteral is going to create an lot of garbage Strings,
> about one for every character.   I'm not sure Streams are the right tool for this task.
> 
> Can't String.replace("'", "''") do the same job?

Yes, I could use replace, but talked myself into Streams :-)

I can change it though for the initial push (after sending another webrev)

Best
Lance
> 
> Roger
> 
> 
> On 10/20/2015 4:19 PM, Lance Andersen wrote:
>> Hi,
>> 
>> Looking for a reviewer for http://cr.openjdk.java.net/~lancea/8139056/webrev.00/.
>> 
>> This change Adds two convenience methods to Statement.java:
>>  - enquoteLiteral which returns a string enclosed in single quotes where all occurrences of a single quote are converted to two single quotes
>>  - enquoteIdentifier returns a SQL identifier
>> 
>> 
>> The CCC has been approved.
>> 
>> Best
>> Lance
>> 
>> 
>> 
>> 
>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com
>> 
>> 
>> 
> 



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com