[9] RFR: 8139743 regular JAX-* sync-up from standalone repos

Miroslav Kos miroslav.kos at oracle.com
Tue Oct 27 10:34:33 UTC 2015 

Thanks, good catch - fixed:
http://cr.openjdk.java.net/~mkos/8139743/jaxws.04/index.html
http://cr.openjdk.java.net/~mkos/8139743/specdiff.04/index.html

Regarding PipeClonerImpl - yes, there is no change - originally there 
was probably some unintentional change (?)

Thanks
Miran



On 26/10/15 20:09, Lance Andersen wrote:
> Hi Miran
>
> Overall looks OK.  Couple quick points:
>
>
> Does the picture look correct at 
> http://cr.openjdk.java.net/~mkos/8139743/specdiff.03/com/sun/xml/internal/bind/v2/package-summary.html 
> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.03/com/sun/xml/internal/bind/v2/package-summary.html>? 
>  Might be made more readable
>
> http://cr.openjdk.java.net/~mkos/8139743/specdiff.03/com/sun/xml/internal/ws/api/pipe/PipeClonerImpl.html 
> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.03/com/sun/xml/internal/ws/api/pipe/PipeClonerImpl.html> is 
> not in the specdiff  and not in the webrev.  Intentional?
>
>
> Best
> Lance
>
>
> On Oct 23, 2015, at 11:07 AM, Miroslav Kos <miroslav.kos at oracle.com 
> <mailto:miroslav.kos at oracle.com>> wrote:
>
>> Hi Lance,
>> here is the new version - all the issues addressed, except for ones 
>> with extraspace - it looks it's only in specdiff, not in javadoc.
>>
>> http://cr.openjdk.java.net/~mkos/8139743/jaxws.03/
>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.03/
>>
>>
>> Thanks a lot for catching all these
>> Miran
>>
>>
>>
>>
>>
>> On 21/10/15 21:55, Lance Andersen wrote:
>>> Hi Miran
>>>
>>> I just made a pass through the spec diff and have a few 
>>> comments/questions:
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/tools/internal/jxc/gen/config/NGCCRuntime.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/tools/internal/jxc/gen/config/NGCCRuntime.html> 
>>>  is the &lt, &gt correct in the new version?
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/tools/internal/xjc/generator/bean/PackageOutlineImpl.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/tools/internal/xjc/generator/bean/PackageOutlineImpl.html> : 
>>>  still a period in @see for getMostUsedNamespaceURI
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/tools/internal/xjc/model/CPropertyInfo.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/tools/internal/xjc/model/CPropertyInfo.html>: 
>>>  extra space before the period in getName
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/tools/internal/xjc/reader/Const.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/tools/internal/xjc/reader/Const.html> : 
>>> Extra space before the comma
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/tools/internal/xjc/reader/relaxng/package-summary.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/tools/internal/xjc/reader/relaxng/package-summary.html>: 
>>> The package summary changes seem wrong (extra and for example)
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/tools/internal/xjc/reader/relaxng/RELAXNGInternalizationLogic.ReferenceFinder.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/tools/internal/xjc/reader/relaxng/RELAXNGInternalizationLogic.ReferenceFinder.html>: 
>>>  change seems wrong (extra and for example)
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/model/core/ElementInfo.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/model/core/ElementInfo.html>: 
>>> extra semi-colon after <contentMemoryType> I believe
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/model/impl/ElementInfoImpl.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/model/impl/ElementInfoImpl.html>  extra 
>>> semi-colon after <contentMemoryType> I believe
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/model/impl/ElementInfoImpl.PropertyImpl.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/model/impl/ElementInfoImpl.PropertyImpl.html> looks 
>>> like @XmlElement was changed incorrectly?
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/model/impl/ElementPropertyInfoImpl.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/model/impl/ElementPropertyInfoImpl.html>  looks 
>>> like @XmlElement was changed incorrectly?
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/model/impl/RuntimeElementInfoImpl.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/model/impl/RuntimeElementInfoImpl.html> extra 
>>> semi-colon?
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/model/impl/RuntimeElementInfoImpl.RuntimePropertyImpl.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/model/impl/RuntimeElementInfoImpl.RuntimePropertyImpl.html>  looks 
>>> like @XmlElement was changed incorrectly?
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/model/runtime/RuntimeElementPropertyInfo.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/model/runtime/RuntimeElementPropertyInfo.html>  looks 
>>> like @XmlElement was changed incorrectly?
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/MarshallerImpl.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/MarshallerImpl.html> extra 
>>> space before ')'
>>>
>>> did you really mean to change & to &  in the following:
>>> ------------------------
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/FastInfosetStreamWriterOutput.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/FastInfosetStreamWriterOutput.html> 
>>>
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/ForkXmlOutput.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/ForkXmlOutput.html> 
>>>
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/IndentingUTF8XmlOutput.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/IndentingUTF8XmlOutput.html> 
>>>
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/MTOMXmlOutput.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/MTOMXmlOutput.html> 
>>>
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/SAXOutput.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/SAXOutput.html>
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/StAXExStreamWriterOutput.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/StAXExStreamWriterOutput.html>
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/UTF8XmlOutput.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/UTF8XmlOutput.html>
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/XMLEventWriterOutput.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/XMLEventWriterOutput.html>
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/XMLStreamWriterOutput.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/XMLStreamWriterOutput.html>
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/XmlOutput.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/bind/v2/runtime/output/XmlOutput.html>
>>>
>>> ------------------------
>>>
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/com/sun/xml/internal/ws/api/pipe/PipeClonerImpl.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/com/sun/xml/internal/ws/api/pipe/PipeClonerImpl.html> - 
>>> looks like this was missing from the specdiff
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/javax/xml/bind/Marshaller.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/javax/xml/bind/Marshaller.html> extra 
>>> space before ')'
>>>
>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/javax/xml/bind/helpers/AbstractMarshallerImpl.html 
>>> <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/javax/xml/bind/helpers/AbstractMarshallerImpl.html> extra 
>>> space before ')'
>>>
>>> Best,
>>> Lance
>>>
>>> On Oct 21, 2015, at 12:42 PM, Miroslav Kos <miroslav.kos at oracle.com> 
>>> wrote:
>>>
>>>> Hi Lance,
>>>> yes, it makes sense - after creating it and reviewing I fixed 
>>>> additional issues - please, check new version of a patch:
>>>> http://cr.openjdk.java.net/~mkos/8139743/jaxws.02/
>>>> http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/
>>>>
>>>> Thanks
>>>> Miran
>>>>
>>>> On 16/10/15 18:12, Lance Andersen wrote:
>>>>> Hi Miran
>>>>>
>>>>> On Oct 16, 2015, at 11:49 AM, Miroslav Kos 
>>>>> <miroslav.kos at oracle.com> wrote:
>>>>>
>>>>>> Hi Lance,
>>>>>> the javadoc fixes are just about formal issues (<tt>...</tt> for 
>>>>>> {@code .. }, broken links etc.) - there are no other changes.
>>>>>
>>>>> Understand, but the specdiff makes it easier to see that there are 
>>>>> no untended changes especially with the size.
>>>>>
>>>>> Best
>>>>> Lance
>>>>>>
>>>>>> Thanks
>>>>>> Miran
>>>>>>
>>>>>>
>>>>>> On 16/10/15 17:26, Lance Andersen wrote:
>>>>>>> Hi Miran
>>>>>>>
>>>>>>> Can you please provide a specdiff as that makes it easier for 
>>>>>>> javadoc review
>>>>>>>
>>>>>>> Best
>>>>>>> Lance
>>>>>>> On Oct 16, 2015, at 11:14 AM, Miroslav Kos 
>>>>>>> <miroslav.kos at oracle.com> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>> there is a bulk update of JAX-B/WS from upstream projects -
>>>>>>>> webrev: http://cr.openjdk.java.net/~mkos/8139743/jaxws.01/ 
>>>>>>>> <http://cr.openjdk.java.net/%7Emkos/8139743/jaxws.01/>
>>>>>>>> more details in issue desc: 
>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8139743
>>>>>>>>
>>>>>>>> Could I ask for a review?
>>>>>>>>
>>>>>>>> It's quite big (2570  lines changed):
>>>>>>>> * many javadoc fixes
>>>>>>>> * some performance and other fixes for SAAJ
>>>>>>>> * findbugs issues
>>>>>>>>
>>>>>>>> There are issue list in the JBS, many of listed bugs were fixed 
>>>>>>>> in JDK already (they are on the list because of backporting to 
>>>>>>>> standalone)
>>>>>>>>
>>>>>>>> Thanks
>>>>>>>> Miran
>>>>>>>>
>>>>>>>
>>>>>>> <Mail Attachment.gif> 
>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
>>>>>>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>>> Oracle Java Engineering
>>>>>>> 1 Network Drive
>>>>>>> Burlington, MA 01803
>>>>>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>> <Mail Attachment.gif> 
>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
>>>>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>> Oracle Java Engineering
>>>>> 1 Network Drive
>>>>> Burlington, MA 01803
>>>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>> <Mail Attachment.gif> 
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
>>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>>
>>>
>>>
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>

More information about the core-libs-dev mailing list