RFR 9:8148775 : Spec for j.l.ProcessBuilder.Redirect.DISCARD need to be improved

Martin Buchholz martinrb at google.com
Fri Feb 12 23:10:18 UTC 2016


Still looks good!

On Fri, Feb 12, 2016 at 3:08 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> Thanks,  Martin
>
> Updated in place.
>
>
>
>
> On 2/12/2016 5:48 PM, Martin Buchholz wrote:
>
> looks good.
> The previous line
>
> Redirect.DISCARD.file() the filename appropriate for the operating system
>  557          * and may be null &&
>
> could use the word "is"
>
> On Fri, Feb 12, 2016 at 2:42 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
>
> Please review a minor javadoc cleanup to remove a reference to a method
> (append)
> of the implementation.
>
> Webrev:
>    http://cr.openjdk.java.net/~rriggs/webrev-discard-8148775/
>
> Issue:
>   https://bugs.openjdk.java.net/browse/JDK-8148775
>
> Thanks, Roger
>
>



More information about the core-libs-dev mailing list