RFR 9:8148775 : Spec for j.l.ProcessBuilder.Redirect.DISCARD need to be improved

Chris Hegarty chris.hegarty at oracle.com
Mon Feb 15 09:47:38 UTC 2016



On 12/02/16 23:10, Martin Buchholz wrote:
> Still looks good!

+1.

-Chris.

> On Fri, Feb 12, 2016 at 3:08 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
>> Thanks,  Martin
>>
>> Updated in place.
>>
>>
>>
>>
>> On 2/12/2016 5:48 PM, Martin Buchholz wrote:
>>
>> looks good.
>> The previous line
>>
>> Redirect.DISCARD.file() the filename appropriate for the operating system
>>   557          * and may be null &&
>>
>> could use the word "is"
>>
>> On Fri, Feb 12, 2016 at 2:42 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
>>
>> Please review a minor javadoc cleanup to remove a reference to a method
>> (append)
>> of the implementation.
>>
>> Webrev:
>>     http://cr.openjdk.java.net/~rriggs/webrev-discard-8148775/
>>
>> Issue:
>>    https://bugs.openjdk.java.net/browse/JDK-8148775
>>
>> Thanks, Roger
>>
>>



More information about the core-libs-dev mailing list