RFR 8144931: Assert class signatures are correct and refer to valid classes
Vladimir Ivanov
vladimir.x.ivanov at oracle.com
Thu Feb 18 13:09:25 UTC 2016
Reviewed.
Best regards,
Vladimir Ivanov
On 2/18/16 2:18 PM, shilpi.rastogi at oracle.com wrote:
> Thank You Vladimir!
>
> I have done the changes. Please review the updated patch-
>
> http://cr.openjdk.java.net/~srastogi/8144931/webrev.02/
>
> Regards,
> Shilpi
>
> On 2/18/2016 1:58 PM, Vladimir Ivanov wrote:
>> Shilpi,
>>
>> _CLASS suffix looks redundant and you can abbreviate LAMBDA_FORM to LF:
>> LF_HIDDEN_SIG
>> LF_COMPILED_SIG
>> FORCEINLINE_SIG
>> DONTINLINE_SIG
>>
>> Otherwise, looks fine.
>>
>> Best regards,
>> Vladimir Ivanov
>>
>> On 2/17/16 5:47 PM, shilpi rastogi wrote:
>>> Hi All,
>>>
>>> Please review fix for the following bug-
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8144931
>>> http://cr.openjdk.java.net/~srastogi/8144931/webrev.01/
>>>
>>>
>>> Thanks,
>>> Shilpi
>
More information about the core-libs-dev
mailing list