RFR: 8079136: Accessing a nested sublist leads to StackOverflowError

Ivan Gerasimov ivan.gerasimov at oracle.com
Tue Mar 29 17:29:38 UTC 2016


Hello!

After the fix for JDK-8148748 went in, I needed to rebase the fix.
Comparing to the previous webrev, the changes are local to 
ArrayList.spliterator().

http://cr.openjdk.java.net/~igerasim/8079136/09/webrev/

The builds/tests are green.

With kind regards,
Ivan



On 03.02.2016 22:16, Ivan Gerasimov wrote:
> Hello!
>
> Here's the updated webrev with rangeCheckForAdd() restored in both 
> AbstractList and ArrayList.
> http://cr.openjdk.java.net/~igerasim/8079136/07/webrev/
>
> The fix was built/tested successfully on all supported platforms.
>
> Sincerely yours,
> Ivan
>
> On 02.02.2016 9:55, Martin Buchholz wrote:
>> On Mon, Feb 1, 2016 at 10:19 PM, Tagir F. Valeev <amaembo at gmail.com> 
>> wrote:
>>
>>> I have a doubt about replacing rangeCheckForAdd. What if size() ==
>>> Integer.MAX_VALUE? This is not an issue for ArrayList as it's limited
>>> by MAX_ARRAY_SIZE which is Integer.MAX_VALUE - 8.
>> Actually, the limit is Integer.MAX_VALUE.  But it only grows beyond
>> MAX_ARRAY_SIZE if there's no choice.
>>
>
>




More information about the core-libs-dev mailing list