Review request 8153035: GenModuleInfoSource strips away the API

Alan Bateman Alan.Bateman at
Thu Mar 31 06:05:30 UTC 2016

On 30/03/2016 20:09, Mandy Chung wrote:
> GenModuleInfoSource is a build tool that augments with platform-specific declaration such as exports, uses and provides and generates the resulting in gensrc directory.  This utility should really be a simple one that inserts/appends the extra info to the original  The patch replaces the old code and removes the unused files that were used for modules.xml.
At L83 then the IAE message is "invalid -provide argument", I assume 
this should be "-provides".

You want to check the indentation at L71-77 and L81-87 as it looks like 
it has been pasted in without re-aligning.

The rest looks okay.


More information about the core-libs-dev mailing list