[9] RFR: 8166645: Include locales plugin throws InternalError with "*" specified.

Naoto Sato naoto.sato at oracle.com
Tue Oct 4 12:42:58 UTC 2016


Thanks, Mandy. I updated it as you suggested.

http://cr.openjdk.java.net/~naoto/8166645/webrev.02/

Naoto

On 10/3/16 7:53 PM, Mandy Chung wrote:
>
>> On Oct 3, 2016, at 3:17 PM, Naoto Sato <naoto.sato at oracle.com> wrote:
>>
>> According to an internal review, I added some explanation to the modification. No logic modifications.
>>
>> http://cr.openjdk.java.net/~naoto/8166645/webrev.01/
>
> This looks okay.
>
> I suggest to keep Set<String> originals after splitting the input byte array such that
>   325             .filter(t -> original.indexOf(t) != -1)
>
> can be replaced with .filter(originals::contains)
>
> Mandy
>


More information about the core-libs-dev mailing list