RFR 9: 8165641 : Deprecate Object.finalize
Mandy Chung
mandy.chung at oracle.com
Thu Apr 6 14:45:49 UTC 2017
+1
Mandy
> On Apr 6, 2017, at 7:44 AM, Roger Riggs <Roger.Riggs at Oracle.com> wrote:
>
> Thanks Mandy, I'll put you down as a reviewer for the fix. (8165641 was pushed)
>
>
> diff --git a/src/java.base/share/classes/java/lang/Object.java b/src/java.base/share/classes/java/lang/Object.java
> --- a/src/java.base/share/classes/java/lang/Object.java
> +++ b/src/java.base/share/classes/java/lang/Object.java
> @@ -593,7 +593,7 @@ public class Object {
> * finalization if it is no longer necessary; and no ordering is specified
> * among calls to {@code finalize} methods of different objects.
> * Furthermore, there are no guarantees regarding the timing of finalization.
> - * The {@code finalize} method might be called on an finalizable object
> + * The {@code finalize} method might be called on a finalizable object
> * only after an indefinite delay, if at all.
> *
> * Classes whose instances hold non-heap resources should provide a method
>
>
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8178154 <https://bugs.openjdk.java.net/browse/JDK-8178154>
>
>
>
> On 4/5/2017 6:15 PM, Mandy Chung wrote:
>>> On Apr 3, 2017, at 7:44 AM, Roger Riggs <roger.riggs at oracle.com> <mailto:roger.riggs at oracle.com> wrote:
>>>
>>> [1] http://cr.openjdk.java.net/~rriggs/webrev-finalize-deprecate-8165641 <http://cr.openjdk.java.net/~rriggs/webrev-finalize-deprecate-8165641>
>>
>> Typo: s/an finalizable/a finalizable/
>>
>> + * The {@code finalize} method might be called on an finalizable object
>>
>> Otherwise, looks good. No need for a new webrev.
>>
>> Mandy
>
More information about the core-libs-dev
mailing list