RFR(XS) : 8181118 : update java/time tests to use RandomFactory from the top level testlibrary

Roger Riggs Roger.Riggs at Oracle.com
Thu Dec 7 15:27:31 UTC 2017


Hi Igor,

Looks fine.

Is the current jtreg b09?

Also, please break the line (w/ '\`) for exclusiveAccess so side-by-side 
diffs fit on the screen.

Thanks, Roger


On 12/6/2017 7:35 PM, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev/8181118/webrev.00
>> 115 lines changed: 0 ins; 108 del; 7 mod;
> Hi all,
>
> could you please review this small fix for java/time tests? RandomFactory has been moved to the top level testlibrary by 8180805[1], but java/time weren't updated when b/c jtreg didn't use external root for libraries listed in lib.dirs test property file[2]. it has been fixed in jtreg4.2b09, now java/time tests can be updated to use top level testlibrary and @deprecated RandomFactory (from test/jdk/lib/testlibrary) can be removed.
>
> webrev: http://cr.openjdk.java.net/~iignatyev/8181118/webrev.00
> JBS: https://bugs.openjdk.java.net/browse/JDK-8181118
> testing: java/time/jck and java/time/tests
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8180805
> [2] https://bugs.openjdk.java.net/browse/CODETOOLS-7901987
>
> Thanks,
> -- Igor



More information about the core-libs-dev mailing list