RFR 9 test-only RFR 8177328 : java/lang/ClassLoader/securityManager/ClassLoaderTest.java times out with -Xcomp
mandy.chung at oracle.com
Fri May 12 16:11:52 UTC 2017
> On May 11, 2017, at 3:25 PM, Brent Christian <brent.christian at oracle.com> wrote:
> I have one more update, with a couple of suggested changes to simplify the execute() calls:
> * execute() takes a vararg, so explicit String creation can be omitted (mostly).
> * args common to every execute() call are consolidated into a List. (The resulting arg reordering should not affect test execution.)
This looks much cleaner. Thanks for the change.
95 private final List<String> COMMON_ARGS;
This is an instance field and you can use lower case as the convention.
238 return !s.equals("");
You can consider using String::isEmpty.
No need for an updated webrev.
More information about the core-libs-dev