RFR(S) : 8180386: remove jdk.testlibrary.TimeLimitedRunner

Igor Ignatyev igor.ignatyev at oracle.com
Thu May 18 21:37:00 UTC 2017


> On May 18, 2017, at 2:34 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>> On May 15, 2017, at 2:00 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>> 
>> http://cr.openjdk.java.net/~iignatyev//8180386/webrev.00/index.html
>>> lines changed: 2 ins; 88 del; 6 mod; 
>> 
>> Hi all,
>> 
>> could you please review this small fix which removes TimeLimitedRunner class from jdk testlibrary? we have two TimeLimitedRunner classes one in jdk test library and another in the the toplevel test library, there is no difference b/w these two library classes (besides location and package name), so the tests were simply updated to use TimeLimitedRunner from the toplevel test library.
>> 
>> this fix is a part of ongoing effort on merging and cleaning up our test libraries[1].
>> 
>> webrev: http://cr.openjdk.java.net/~iignatyev//8180386/webrev.00/index.html
> 
> This comment is not related to the change.  The package name `jdk.test.lib.wrappers` is odd.  TimeLimitedRunner and InfiniteLoop classes could simply be in the jdk.test.lib package or jdk.test.lib.util package.
> 
> Mandy
> 

agree, I'll file an RFE to find a better package for TimeLimitedRunner and InfiniteLoop classes.

-- Igor



More information about the core-libs-dev mailing list