JDK 10 RFR of 8177809: File.lastModified() is losing milliseconds (always ends in 000)

Vyom Tewari vyom.tewari at oracle.com
Fri May 19 04:05:23 UTC 2017


Hi Brian,

looks good to me, although i am not JDK10 reviewer, one minor comment i 
think you can combine the below two statements to one

rv = (jlong)sb.st_mtimespec.tv_sec * 1000;
rv += (jlong)sb.st_mtimespec.tv_nsec / 1000000; rv= 
(jlong)sb.st_mtimespec.tv_sec * 1000  +(jlong)sb.st_mtimespec.tv_nsec / 1000000;

Thanks,
Vyom


On Friday 19 May 2017 01:04 AM, Brian Burkhalter wrote:
> Oh, I guess I need a +1 from a JDK10 Reviewer.
>
> On May 18, 2017, at 12:23 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
>
>> Hi Brent,
>>
>> On May 18, 2017, at 11:43 AM, Brent Christian <brent.christian at oracle.com> wrote:
>>
>>> This will get some good bake time in 10, a chance for incompatibilities (if any) to be revealed.
>> Good point - thanks!
>>
>> Brian



More information about the core-libs-dev mailing list