JDK 10 RFR of 8177809: File.lastModified() is losing milliseconds (always ends in 000)

Brian Burkhalter brian.burkhalter at oracle.com
Fri May 19 14:36:44 UTC 2017


Hi Vyom,

I agree with you but it’s already pushed and I doubt it is worth an issue just to make this small change.

Thanks,

Brian

On May 18, 2017, at 9:05 PM, Vyom Tewari <vyom.tewari at oracle.com> wrote:

> looks good to me, although i am not JDK10 reviewer, one minor comment i think you can combine the below two statements to one
> 
> rv = (jlong)sb.st_mtimespec.tv_sec * 1000;
> rv += (jlong)sb.st_mtimespec.tv_nsec / 1000000; rv= (jlong)sb.st_mtimespec.tv_sec * 1000  +(jlong)sb.st_mtimespec.tv_nsec / 1000000;



More information about the core-libs-dev mailing list