JDK 9 RFC on test for 6212869: File.setLastModified(long) incorrect after calling TimeZone.setDefault()

Brian Burkhalter brian.burkhalter at oracle.com
Tue May 23 22:56:07 UTC 2017


This discussion has now transitioned to an RFR [1]

Thanks,

Brian

[1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-May/047841.html

On May 23, 2017, at 2:08 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:

> Hi Roger,
> 
> On May 23, 2017, at 1:02 PM, Roger Riggs <Roger.Riggs at Oracle.com> wrote:
> 
>> The bug number does help trace the original/stimulus for the test;
>> you can push the new test as subtask.
> 
> So the new test would have the sub-task issue ID in its @bug tag and the main issue would be resolved CNR?
> 
>> line 36: I would probably add a comment with the readable time.
>> Its nice to know when that if someone had to debug the time on file.
>> 
>> And it's worth a couple of extra characters to add the units (ms) to the error at line 70.
>> 
>> Otherwise looks fine.
> 
> I will make those changes.
> 
> Thanks,
> 
> Brian



More information about the core-libs-dev mailing list